[PATCH] guix: Only attempt to build json builder if json is available.

---

guix/import/stackage.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

John Darrington <john@darrington.wattle.id.au> skribis:

We don’t do that for any of the other (guix import …) modules that uses

(guix import json). What problem does it cause?

Thanks,

Ludo’.

But the other modules are protected in Makefile.am.

The problem it causes, is that it's not possible to build Guix unless

guile-json is present.

--

Avoid eavesdropping. Send strong encrypted email.

PGP Public key ID: 1024D/2DE827B3

fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3

See http://sks-keyservers.netor any PGP keyserver for public key.

On Mon, Mar 13, 2017 at 02:16:27PM +0100, Ludovic Court??s wrote:

John Darrington <john@darrington.wattle.id.au> skribis:

> * guix/import/stackage.scm: avoid loading the json module.

> ---

> guix/import/stackage.scm | 3 ++-

> 1 file changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm

> index 5b25adc..c8f195a 100644

> --- a/guix/import/stackage.scm

> +++ b/guix/import/stackage.scm

> @@ -23,7 +23,6 @@

> #:use-module (srfi srfi-26)

> #:use-module (srfi srfi-34)

> #:use-module (srfi srfi-35)

> - #:use-module (guix import json)

> #:use-module (guix import hackage)

> #:use-module (guix memoization)

> #:use-module (guix packages)

> @@ -31,6 +30,8 @@

> #:export (stackage->guix-package

> %stackage-updater))

>

> +(module-autoload! (current-module) '(guix import json) '(json))

We don???t do that for any of the other (guix import ???) modules that uses

No. But all the others are projected in Makefile.am by "if HAVE_GUILE_JSON" .

(guix import json). What problem does it cause?

It means that one cannot build guix on a foreign system if guile-json is absent.

J'

--

Avoid eavesdropping. Send strong encrypted email.

PGP Public key ID: 1024D/2DE827B3

fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3

See http://sks-keyservers.netor any PGP keyserver for public key.

John Darrington <john@darrington.wattle.id.au> skribis:

Oh right. Then let’s move this one under “if HAVE_GUILE_JSON” as well.

Thanks,

Ludo’.

On Thu, Mar 16, 2017 at 04:40:51PM +0100, Ludovic Court??s wrote:

John Darrington <john@darrington.wattle.id.au> skribis:

> On Mon, Mar 13, 2017 at 02:16:27PM +0100, Ludovic Court??s wrote:

> John Darrington <john@darrington.wattle.id.au> skribis:

>

> > * guix/import/stackage.scm: avoid loading the json module.

> > ---

> > guix/import/stackage.scm | 3 ++-

> > 1 file changed, 2 insertions(+), 1 deletion(-)

> >

> > diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm

> > index 5b25adc..c8f195a 100644

> > --- a/guix/import/stackage.scm

> > +++ b/guix/import/stackage.scm

> > @@ -23,7 +23,6 @@

> > #:use-module (srfi srfi-26)

> > #:use-module (srfi srfi-34)

> > #:use-module (srfi srfi-35)

> > - #:use-module (guix import json)

> > #:use-module (guix import hackage)

> > #:use-module (guix memoization)

> > #:use-module (guix packages)

> > @@ -31,6 +30,8 @@

> > #:export (stackage->guix-package

> > %stackage-updater))

> >

> > +(module-autoload! (current-module) '(guix import json) '(json))

>

> We don???t do that for any of the other (guix import ???) modules that uses

>

> No. But all the others are projected in Makefile.am by "if HAVE_GUILE_JSON" .

Oh right. Then let???s move this one under ???if HAVE_GUILE_JSON??? as well.

No. I tried that. Unfortunately there are other modules which need this one.

J'

--

Avoid eavesdropping. Send strong encrypted email.

PGP Public key ID: 1024D/2DE827B3

fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3

See http://sks-keyservers.netor any PGP keyserver for public key.

John Darrington <john@darrington.wattle.id.au> skribis:

This was fixed later in commit 37fd9567710b0fc0d7b083f8a1eba3528597c2f6.

Thanks,

Ludo’.