[PATCH] re2: add missing '#:modules' imports

  • Done
  • quality assurance status badge
Details
2 participants
  • Leo Famulari
  • Sergei Trofimovich
Owner
unassigned
Submitted by
Sergei Trofimovich
Severity
normal
S
S
Sergei Trofimovich wrote on 7 May 2017 12:48
(address . guix-patches@gnu.org)(name . Sergei Trofimovich)(address . slyfox@inbox.ru)
20170507104837.18103-1-slyfox@inbox.ru
Noticed as a 're2' build failure:

/gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
to match any pattern in form (%modify-phases phases* (delete (quote configure)))

* gnu/packages/regex.scm (re2): add missing '#:modules' imports

Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
---
gnu/packages/regex.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/regex.scm b/gnu/packages/regex.scm
index f55faaf04..779050525 100644
--- a/gnu/packages/regex.scm
+++ b/gnu/packages/regex.scm
@@ -41,7 +41,10 @@
"1s3kdcrz2mwi30k6pz9jkv5vk8b704bz65xgcr67wbn2pn3hpnqr"))))
(build-system gnu-build-system)
(arguments
- `(#:test-target "test"
+ `(#:modules ((guix build gnu-build-system)
+ (guix build utils)
+ (srfi srfi-1))
+ #:test-target "test"
;; There is no configure step, but the Makefile respects a prefix.
;; As ./configure does not know anything about the target CXX
;; we need to specify TARGET-g++ explicitly.
--
2.12.2
L
L
Leo Famulari wrote on 7 May 2017 20:21
(name . Sergei Trofimovich)(address . slyfox@inbox.ru)(address . 26813-done@debbugs.gnu.org)
20170507182129.GA19395@jasmine
On Sun, May 07, 2017 at 11:48:37AM +0100, Sergei Trofimovich wrote:
Toggle quote (9 lines)
> Noticed as a 're2' build failure:
>
> /gnu/store/...-re2-2017-03-01-guile-builder:1:2276: source expression failed
> to match any pattern in form (%modify-phases phases* (delete (quote configure)))
>
> * gnu/packages/regex.scm (re2): add missing '#:modules' imports
>
> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>

Pushed by Danny as 7a4a64e99e65e96a4dc3e65ae691b4c80b7642e8.

Sergei, we use the signed-off-by line to make it easier to see when
somebody has pushed a patch to Savannah on behalf of somebody else
(other projects use it in a variety of different ways). In this case,
Danny signed off on the commit for you. So, no need to sign off on your
Guix contributions :)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlkPZaUACgkQJkb6MLrK
fwgrLw//foktYfVkCYnZSGnmcxv7X781VBYr+5PPciLwHYXv6wzI6mxltycPc2J7
m3qhLIcdBDw5K1iYsfURFjfOO/0uvnfg3gMUnyChWNFYrc3LNGjcn21l2HNbxJy5
9G+G7gp/IQmI/sBjhjnLKuXXOKQHM8mp1EyynbL9sVLJefEu3gItZnUT8fDV+78s
GYs8e/wFlGNde6VQC0EIXQcvqoe82MySj13K+10khFs+xNatzX5ZLVPCSguKIaJR
kBFhA1w5ScV2lvFZVHQSPD4eHve6p9k3gRihzSXlDdShI8JW67V3WsEZPzb4fIoG
3R9ZrCXv8Iw19GEPUkNf6zxtUz7Ia2HvynXLF746DlH3f7Z8IwZCQeraJOX69c3L
t8TKucwR/WuBJLmiPk4QoIU6QpzUlyRHkNmNyv2hRfql3TZbXIUrjD3oKxdNz40S
8qhwgy+o0FwdcUsbPWjeBZ12m9w18ekJA64GVjZ1OCAE4P6Y5Wr+wgcNAvxQeSd+
f/DveZcvkTXiwKY2B9qORAgaA4bFDuB0eLpxRo0u2kph/Yfq4zSUIF1hdcS2Sunq
2+nk3We2FwJmmXTP57aBigJ9UlIyBqgrVuEPM6buYf56OQ7qC2tOQAKQ/L1dOUZI
y7/wq7v39Fjq1/1WVFQxaIjLQ1c7J2SRdnQ5HgExOOs4PnvOnd4=
=FHc5
-----END PGP SIGNATURE-----


Closed
S
S
Sergei Trofimovich wrote on 7 May 2017 21:49
(name . Leo Famulari)(address . leo@famulari.name)(address . 26813-done@debbugs.gnu.org)
20170507204931.72397b52@sf
On Sun, 7 May 2017 14:21:29 -0400
Leo Famulari <leo@famulari.name> wrote:

Toggle quote (6 lines)
> Sergei, we use the signed-off-by line to make it easier to see when
> somebody has pushed a patch to Savannah on behalf of somebody else
> (other projects use it in a variety of different ways). In this case,
> Danny signed off on the commit for you. So, no need to sign off on your
> Guix contributions :)

Got it. Thanks!

--

Sergei
-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSZKa0VG5avZRlY01hxoe52YR/zqgUCWQ96SwAKCRBxoe52YR/z
qo8+AJ9VXnD/rgMq4g2BvNVpzTyEQC3gEwCfcs4avLWdA4tM6qIj5lGJoiZsZew=
=r/QO
-----END PGP SIGNATURE-----


Closed
?