[PATCH] gnu: restic: Fix tests.

  • Done
  • quality assurance status badge
Details
2 participants
  • Oleg Pykhalov
  • Leo Famulari
Owner
unassigned
Submitted by
Oleg Pykhalov
Severity
normal
O
O
Oleg Pykhalov wrote on 8 Aug 2018 07:29
(address . guix-patches@gnu.org)(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
20180808052906.20449-1-go.wigust@gmail.com
* gnu/packages/backup.scm (restic)[arguments]: Replace 'check' phase.
---
gnu/packages/backup.scm | 15 +++++++++++++++
1 file changed, 15 insertions(+)

Toggle diff (35 lines)
diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 0733d9c34..bca070d3f 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -850,6 +850,9 @@ is like a time machine for your data. ")
(build-system go-build-system)
(arguments
`(#:import-path "github.com/restic/restic"
+ #:modules ((srfi srfi-26)
+ (guix build go-build-system)
+ (guix build utils))
#:unpack-path "github.com/restic"
;; We don't need to install the source code for end-user applications.
#:install-source? #f
@@ -862,6 +865,18 @@ is like a time machine for your data. ")
,version)
(invoke "go" "run" "build.go"))))
+ (replace 'check
+ (lambda _
+ (with-directory-excursion (string-append
+ "src/github.com/restic/restic-"
+ ,version)
+ (for-each (cut delete-file <>)
+ '(;; Requires a network.
+ "internal/backend/rest/rest_int_test.go"
+ ;; unexpected error: fusermount: exit status 1
+ "cmd/restic/integration_fuse_test.go"))
+ (invoke "go" "run" "build.go" "--test"))))
+
(replace 'install
(lambda* (#:key outputs #:allow-other-keys)
(let ((out (assoc-ref outputs "out"))
--
2.18.0
L
L
Leo Famulari wrote on 8 Aug 2018 15:22
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 32394@debbugs.gnu.org)
20180808132215.GA16151@jasmine.lan
On Wed, Aug 08, 2018 at 08:29:06AM +0300, Oleg Pykhalov wrote:
Toggle quote (2 lines)
> * gnu/packages/backup.scm (restic)[arguments]: Replace 'check' phase.

Thanks, LGTM! Should we report the issues upstream?
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAltq7oMACgkQJkb6MLrK
fwgEYA/9E/xhZuwcws4xVP1j3RBQos5M9u6J2W0TcjhCGSX5lBtBbx3pEph7p4/B
onKw8cXupkbbb0nIOI3piw5ze3ZKALIxNBklJHOiSBz+Z4b1A4Jxm7Rs3qjPlIZh
wjxa4YEKuN2MEdGueK3WHTcM7l/ELqr8O8ZSsKHtFNp78OeHhsEfU8UwyUTzgvK1
EHqtktWdl6pPc4xgYxmNF3S9z2Cwjt899t9L0sGX5exEUUrU31BSgWEEDd9+bZko
xXwSOFUMa3VSGFcttAoG3XSk4OcTWrdD782poP5yf3Kxg5Y/dgs+tVrgwbvG4raF
EY5P9fk6YWnOJu0THQl4TOR3eq6Ux3dKJ/AKjP6gxdAO/oIEknttZn97u2Cmhs/V
ZIrx02EFh6VBm3u4k/hIRVuLUaDkf/m+3YdRU5dMNAooXcCmczZAliN7R0Q9PC1n
TuCvX3qcZEA0ixqEPO7KvRK2TZU/6Uj8Z4ooM2VVF3UQqBDLjOSpZkT2C8mloTpD
9mtqLv79yrJuoWjJlJwuy95UE55NCbagS0o4HfE3uYlpR+t9LnLNC150vAiNx7bC
MWRceyle7id9jAyVEjJsxzqooP1PDW3dr06Dmh3AHr2x1yKgc3PevpIErKNHxrez
SLg8A1AKUtULBVOum5wVCL0dIpTaahLk3sLJcj0N2A/iJepooqY=
=qIG5
-----END PGP SIGNATURE-----


O
O
Oleg Pykhalov wrote on 8 Aug 2018 19:58
(name . Leo Famulari)(address . leo@famulari.name)(address . 32394@debbugs.gnu.org)
87sh3og2pj.fsf@gmail.com
Hello Leo,

Thank you for review.

Leo Famulari <leo@famulari.name> writes:

Toggle quote (5 lines)
> On Wed, Aug 08, 2018 at 08:29:06AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/backup.scm (restic)[arguments]: Replace 'check' phase.
>
> Thanks, LGTM! Should we report the issues upstream?

I've played little bit more and found that
‘internal/backend/rest/rest_int_test.go’ is actually passes.

Pushed 4976ebddf1a4735ee12808083876f573121993bf as with changes:
Toggle diff (28 lines)
diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index bca070d3f..251dadf84 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -850,9 +850,6 @@ is like a time machine for your data. ")
(build-system go-build-system)
(arguments
`(#:import-path "github.com/restic/restic"
- #:modules ((srfi srfi-26)
- (guix build go-build-system)
- (guix build utils))
#:unpack-path "github.com/restic"
;; We don't need to install the source code for end-user applications.
#:install-source? #f
@@ -870,11 +867,8 @@ is like a time machine for your data. ")
(with-directory-excursion (string-append
"src/github.com/restic/restic-"
,version)
- (for-each (cut delete-file <>)
- '(;; Requires a network.
- "internal/backend/rest/rest_int_test.go"
- ;; unexpected error: fusermount: exit status 1
- "cmd/restic/integration_fuse_test.go"))
+ ;; unexpected error: fusermount: exit status 1
+ (delete-file "cmd/restic/integration_fuse_test.go")
(invoke "go" "run" "build.go" "--test"))))
(replace 'install
I'm not sure about reporting to upstream, because I think fusermount
fail in a build process is Guix specific. WDYT?

Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAltrL0gACgkQckbhHGm3
lWkJkw/9Hps8TtvNDICBVzpSg/Ie39RSBTHd4pewlKlhPxP0guBOgWZPCN5Jx2oP
M2ZkJomb2crIqaojJfiGjVrochEJuFjpq4/zeTv5xus2bDxcLlJOuZsbeMteeQy6
zeO/tw07tZA1XgX+yNvOcS597gyFq8Tf6k3sKLG9mpGOcBuxUFtQ0xeGmX2TGTe5
atyE6LrBgMCds79vgYqFhPKqpKDhr1P4sROeVnqRO3583RwX8DRsfEE9ErClIm5r
SN1Z1YAa5DTSIUxsa/f2EgSSovVx5JcCutERl50qe/jjQtjRZOp7PyBl6tkPZsQK
gREIrDEoNxoHANuohZP23PdffUE8B0chzDe+YtcO371K35GRcOa6lH2gvh09RX1p
6LqQqTf8yqRLDWFHfoV/F40/JVE1i3lD1L+8sEP7vDLy7hAeXoRl3f2eH01A+jyG
RVdWCDIvUDTOive/yGQlHXClrPKLW9lVv79rlw/6MtqVTBhogzKf5chgms4WQ1Rv
AfD13MvioebLoEuC8Cwy6Nj8Tn5oYv0D2VOcNgDB6xQY9uJFu0LKF+9uHMd4Q1XI
4fzlyioRaKFpgPe/EPwuVEEeXi64tdD+dhn3VmVfVRxU7RdJXE/AoMZBzVbVq6na
46cvxeGXrmjD3Xg6oTGtsUt8+KW8RUZlhtjwhUp8CwcR0+F7U+c=
=7nHw
-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 8 Aug 2018 20:50
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 32394@debbugs.gnu.org)
20180808185027.GA3910@jasmine.lan
On Wed, Aug 08, 2018 at 08:58:32PM +0300, Oleg Pykhalov wrote:
Toggle quote (3 lines)
> I'm not sure about reporting to upstream, because I think fusermount
> fail in a build process is Guix specific. WDYT?

Agreed, if it's really specific to Guix then I think we should not report
it.
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAltrO28ACgkQJkb6MLrK
fwhaPxAA4tY1N+8fC7tkr6hvWA/cbKg96boUW7xlXcp/y0N+CahBRcUIcJ1r1Iwc
my0KlWIPZzsqFEBoUhXDF1eI2c5jJjS2UBrsTq+Jn7zwDn2f8mUAP08y57yfGcDk
F58CnVCX712/zRDU2rnXMKAYg+qyPAgmZYPClR9Y7kWKuEHfbwTGwzzdNjmY4wWU
V0Tzs+qYZIBCCGLUOleuf2hoFF6eBHX2LD7++f+LZv/NqeyXQKeDIOCBPkUSgj47
kbIRa+FtIiD12cL54bl/X9Ts09+b4ZRwkFhfZGGviux0Jed22N+eFPcECpwgg0dD
9qt+H26VU2x1LZ/I60JXckzQFaUGY5YVvFkV5E3FOE+rsXyEfurJVfmqRrc/Uu2f
fANIWxQgPfYkIWOw76ApcJdeboPgnOB4vUsUBGjBlfHA95YayFhxUrAI+fzZ0qT7
KTftvWk4H571Hs46WXYaTpyPr33tlUzROg8ojqUe0D3uPqE4cOxLngP0nyzlnVxQ
0XvZiX7ffsfQqkzpa4+AGTMY6FGWITeku1/IbMShJ0L8ch7Byi7gfQ0Fvfud3ZvJ
geDYBEd+jEiW0F/zGgafGCYK5xNiaVstpX3xGaOLoJIvUD92hiD02Eb468O2hxTM
jiKrV/4sK48M0tb3fBkTO9S1u5tpVNp7q6l3rkjwR0ZGmSxUB/Q=
=D45b
-----END PGP SIGNATURE-----


O
O
Oleg Pykhalov wrote on 8 Aug 2018 22:37
control message for bug #32394
(address . control@debbugs.gnu.org)
87r2j8fvca.fsf@gmail.com
tags 32394 fixed
close 32394
O
O
Oleg Pykhalov wrote on 8 Aug 2018 22:44
Re: [bug#32394] [PATCH] gnu: restic: Fix tests.
(name . Leo Famulari)(address . leo@famulari.name)(address . 32394-done@debbugs.gnu.org)
87o9ecfv1i.fsf@gmail.com
Leo Famulari <leo@famulari.name> writes:

Toggle quote (7 lines)
> On Wed, Aug 08, 2018 at 08:58:32PM +0300, Oleg Pykhalov wrote:
>> I'm not sure about reporting to upstream, because I think fusermount
>> fail in a build process is Guix specific. WDYT?
>
> Agreed, if it's really specific to Guix then I think we should not report
> it.

OK, then I close the bug report.

Thanks,
Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAltrVhkACgkQckbhHGm3
lWmSfQ/6Ai0sbsXm4vLv1wNFKmBuw/vcscoF8TRNNibjMfkpxIQ0IeQ9v8knDu9d
eON+BU+SEkqTqXW/vixcua/ELX+hPRJJNVmKXMINln8VC2jA39ziTxD3djaS0NfC
Sc4U4nQj9ScigGs1B5nhNeiR/VeltTGgdZK6nvE/JQperSns7OLZ/kwijHuRmJqs
RhYBU09tq/0FYC6U/c9aYp9OpAF7vTHPmaloUv+h5j6VRMmUGcT0qiGfd4T69oe7
yPwjwaHkgA+AGelhVyN03QQW141mcPz19SD53ikZukRy4WmavczzafScLMMxsSkj
ZJHBEKmn/qNCadsWl74VKGSyiW2ZwwkhHxKCftEjBcu4yA3uSjHiPfUz3Ct6tnEE
FOrgD3jcQr4nC7umMsugvfdspGqDur5d+XYgctLbHRPPHOSomWuZp8VgvQK5bPlS
8CFL00EPUd6bd8NK+dEsoG9WF1sSWwEQCK9+UShlUXnMd4ucatzrRmtPG7mNmRQ4
S3UEYULW5qYjLxvRt+zgLma7PpCp9JypZCRs2jilMAIFFBHGpz389piB71bfRXAE
8rBycv4shSLaBW4tmSRQsIs1DqKo7Ex2+6kld4qsgOjrlwbxI9EVy6i5PRLneGb7
Bd+qLlCxjDt6cf6z5rjBMTsqlWm/eQiZLdOntuG6nfDyiFn0M54=
=nUNU
-----END PGP SIGNATURE-----

Closed
?