guix import github crash

  • Done
  • quality assurance status badge
Details
3 participants
  • Arun Isaac
  • Efraim Flashner
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Efraim Flashner
Severity
normal
E
E
Efraim Flashner wrote on 20 Jan 2019 10:32
(address . bug-guix@gnu.org)
20190120093206.GA15839@macbook41
$ ./pre-inst-env guix refresh mujs
Backtrace:
14 (apply-smob/1 #<catch-closure d12200>)
In ice-9/boot-9.scm:
705:2 13 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
619:8 12 (_ #(#(#<directory (guile-user) daa140>)))
In guix/ui.scm:
1639:12 11 (run-guix-command _ . _)
In ice-9/boot-9.scm:
829:9 10 (catch _ _ #<procedure 7f096bb0d9b0 at guix/ui.scm:617…> …)
829:9 9 (catch _ _ #<procedure 7f096bb0d9c8 at guix/ui.scm:735…> …)
In guix/scripts/refresh.scm:
513:8 8 (_)
In guix/store.scm:
1693:24 7 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
In guix/scripts/refresh.scm:
538:14 6 (_ _)
In srfi/srfi-1.scm:
640:9 5 (for-each #<procedure 1ab7680 at guix/scripts/refresh.…> …)
In guix/scripts/refresh.scm:
346:2 4 (check-for-package-update #<package mujs@1.0.5 gnu/pac…> …)
In guix/import/github.scm:
229:25 3 (latest-release #<package mujs@1.0.5 gnu/packages/javas…>)
172:15 2 (latest-released-version "https://git.ghostscript.com/…"…)
143:19 1 (fetch-releases-or-tags "https://git.ghostscript.com/mu…")
120:2 0 (github-user-slash-repository _)

guix/import/github.scm:120:2: In procedure github-user-slash-repository:
Throw to key `match-error' with args `("match" "no matching pattern" ("" "mujs.git"))'.

mujs isn't a github repo, and it looks like there's some checking to be
done somwhere to make sure that the source is actually from a github
repo before checking the github importer for an update.

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlxEQBIACgkQQarn3Mo9
g1G37Q/9FxYfrffoLSkfVQjzh59TFQsDRN/oUKq0qyDloilqX4zcO1gM1B8rUghD
LkfOjoWCVmUQjlYuT21CG9L/ipI5WDorRv+lB0Fn4E2yDWRjVr46tb9pn9Pz77IO
IYYzAPZUH44u/UQsvK92QttL1yv4QkbDExD5VdRd1dP1MhxS+1+AeUfEul4stZC2
a7+iE38ALb93IygZEsq604BkMpl1y0EPPabyqQTcDj0x1CUDZKPnLNX89SiJPkEa
fjMOZxzMNcM8ogQlZ/5Io2jBOw0G8ugvBoPmcZoOynFCeOGoJttdj3EaDrKVHW9E
iLphFXswy9wVlOpy2uWYnEpEt0Ao6pcHXzcQ1iUhU2dsmekrw2EGTiYt3GjTtUMg
YsIff11x/SrCUt52BDwrO6HAvJe056xd5G8d6nDkhj+HiCisSXLriMTEhYSjztNV
1itkRbuYs9dJPnlnuAtdDg9LBr/IACRcqf2turpQwbGtZw1JBT/BwCozOb+ZZmFj
UN3rVVSnC+S1+Rn5XW4i1ACOJqp3LIE8i0zA6FKP9SvKGnkQmb4zw/bSnnF/d3xP
4fs3lTP8VnYI1pOwgtqkht8OEg8CcJcqDfHP7wIx0KFUkUH9MfoiDx307q5C8DCj
V9lpnth6Ylvc7rgLKGVBZcsq39eNZMiR+peGs1TCvcqd+9r8bQM=
=k9xy
-----END PGP SIGNATURE-----


A
A
Arun Isaac wrote on 20 Jan 2019 19:41
(name . Efraim Flashner)(address . efraim@flashner.co.il)
cu7bm4bw4qz.fsf@systemreboot.net
I've attached a patch addressing this issue. May I push it?
From 57fa15ef15d1fdb0896ce139e1e02c459b285743 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Sun, 20 Jan 2019 22:18:32 +0530
Subject: [PATCH] import: github: Check if git URIs are GitHub URIs.

This fixes a regression introduced in 9a5091d0c181453d0f31ce97f96a4e577a25e796
whereby packages with git origin URIs not hosted on GitHub would be wrongly
detected as being covered under the github updater.
Reported by Efraim Flashner <efraim@flashner.co.il>.

* guix/import/github.scm (updated-github-url): Check if git URIs are GitHub
URIs.
---
guix/import/github.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/guix/import/github.scm b/guix/import/github.scm
index b287313d98..e17ef0b840 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -98,7 +98,9 @@ false if none is recognized"
(updated-url source-uri))
((source-uri ...)
(find updated-url source-uri))))
- ((eq? fetch-method download:git-fetch)
+ ((and (eq? fetch-method download:git-fetch)
+ (string-prefix? "https://github.com/"
+ (download:git-reference-url source-uri)))
(download:git-reference-url source-uri))
(else #f))))
--
2.19.2
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlxEwPQACgkQLiXui2GA
K7NPkwgAvhst7CrLMkius3OkY5XcZqhPVBr0B07nrtCbDO3+zAHywtWqV3Woy8Ln
J8avuRRBmXpnoiI4pP+t4FN2+2xfqfKnZZwvsSHDw/3AvcTIWXYYEgMygMf/HHUk
jrg9rhJBQn4I2eijSiQpehk3aOkNXDqGk7L0WdwnAnMR844LyIw4iZOWQNsx5dVu
hJNb1WWhHFrIUJEpNTqHknlY2usaW81SOBiLx/sN9D51rhi0vby5Ztl/DGuieFsu
uXrjAam9/Oxl3ojVCY1ieNx2HQDCG1MoGfsuXn7iQ583qH3YkTXpYO6X5YU17uJQ
Px5RCGdPQO+KItbVn93SWlEdY+Ccpg==
=IGMn
-----END PGP SIGNATURE-----

R
R
Ricardo Wurmus wrote on 20 Jan 2019 20:16
Re: bug#34144: guix import github crash
(name . Arun Isaac)(address . arunisaac@systemreboot.net)
87r2d7dtrs.fsf@elephly.net
Hi Arun,

Toggle quote (2 lines)
> I've attached a patch addressing this issue. May I push it?

This looks fine to me. Thanks!

--
Ricardo
A
A
Arun Isaac wrote on 20 Jan 2019 20:51
(name . Ricardo Wurmus)(address . rekado@elephly.net)
cu78szfw1jk.fsf@systemreboot.net
Toggle quote (2 lines)
> This looks fine to me. Thanks!

Pushed, thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlxE0S8ACgkQLiXui2GA
K7MoDAf/cgqQGRokgjEuI5gvUE6Q1wAEEBTIEQCRF1P0IuauAT4jE2UUKmvWKQcv
Yt8AHLGXgleVGzcGKuiI95lE1fsn6dpj0bNB83PjnIjDiXIy7APIHVvyMRdyPjY8
fDxmNFS3k7gLZhwWbULZeldMAsDtfQxq3a0l8iIMiJFrCz6ATcNS5LUXxSe2uXEh
7Si7Mlu6j6VPdehIijSGnEVn64EcPUJPFdXRPM/HBkY1ZaBeWga0EVVdvqKc0V88
QSkM5Fq5xuuF8er/HHpoST3IS1rCBH/BMQIAas1nbYy4Dmow5RX88Bwt/rIKyAKH
IlA7Lqa5m3inDAWwpsrdfsK4RgBwMg==
=iPpr
-----END PGP SIGNATURE-----

Closed
?