February 21, 2019 3:07 AM, "Ricardo Wurmus" <rekado@elephly.net> wrote:
Toggle quote (14 lines)
> Hi,
>
>> Shroud is a password manager written in Guile which uses GnuPG in the
>> backend. This package is an Emacs interface to Shroud using the Buffers
>> User Interface library.
>
> You have previously already submitted a variant of this:
>
> https://issues.guix.info/issue/34364
>
> Please don’t open more tickets for this but instead send updates to the
> same ticket. I’m closing this issue, because what you attached is not a
> git formatted patch.
Thanks for closing the other issue, i was oblivious of debbugs until today.
Toggle quote (18 lines)
>
>> +(define-public nly/emacs-shroud
>
> We don’t use personal prefixes like “nly/” in Guix.
>
>> + (package
>> + (name "emacs-shroud")
>> + (version "ad5de6d")
>
> A version string must be monotonically increasing over time. Commit
> hashes don’t do that, so we use (git-version last-release revision
> commit) instead.
>
> We prefer releases over arbitrary commits. Since you are the developer,
> could you please tell us what the difference is between this version and
> the previous release? Could you make a new release instead?
>
Thanks, got it. Now looks like (git-version "v1" "1" commit)
Toggle quote (12 lines)
>> + (build-system emacs-build-system)
>> + (propagated-inputs
>> + `(("emacs-f" ,emacs-f)
>> + ("emacs-s" ,emacs-s)
>> + ("emacs-bui" ,emacs-bui)
>> + ("shroud" ,shroud)))
>> + (home-page "http://nly.info.tm:9001/emacs/shroud.el")
>> + (synopsis "Shroud (gpg) support for Emacs")
>
> Why “(gpg)”? It’s probably better to say “Shroud password manager
> interface for Emacs”.
New synopsis: Emacs interface for Shroud password manager
Toggle quote (10 lines)
>
>> + (description
>> + "This package provides functions for working with shroud password
>> manager.")
>
> I’d not say “functions”. How about
>
> This package provides an Emacs minor mode for working with the Shroud
> password manager.
This package doesn't include any minor-mode so I assume it would become misleading.
Toggle quote (6 lines)
>
> Could you please send an updated patch?
>
> --
> Ricardo
I hope web mail doesn't html-ize the patch.
This is great, It feels awesome to get in a personal package I've been using for months.
Thanks,
Amar
From 0309576d26ce92ec2324c0505599da95408b1235 Mon Sep 17 00:00:00 2001
* gnu/packages/emacs-xyz.scm (emacs-shroud): New variable.
---
gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
Toggle diff (42 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 54663496fe..d7c1245f43 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15306,3 +15306,35 @@ numbers within that region will be incremented/decremented (unlike in Vim).
It is a fork of https://github.com/cofi/evil-numbers, which is unmaintained.")
(license license:gpl3+))))
+
+(define-public emacs-shroud
+ (let
+ ((commit "dc68f5538692bf07376cd5395b87102025549f32"))
+ (package
+ (name "emacs-shroud")
+ (version
+ (git-version "v1" "1" commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/o-nly/emacs-shroud")
+ (commit commit)))
+ (file-name
+ (git-file-name name version))
+ (sha256
+ (base32
+ "17a3z5p252nbj3y7rwbvx1jk2bizzdcina6vw8blnks4dvv30k87"))))
+ (build-system emacs-build-system)
+ (inputs
+ `(("emacs-f" ,emacs-f)
+ ("emacs-bui" ,emacs-bui)
+ ("shroud" ,shroud)))
+ (home-page "http://git.nly.info.tm:9001/shroud.git")
+ (synopsis "Emacs interface for Shroud password manager")
+ (description
+ "This package provides functions for working with shroud
+password manager using Elisp, a reader for Shroud DB, and an Buffers
+User Interface for using shroud password database.")
+ (license license:gpl3+))))
--
2.21.0
