(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . bug-guix@gnu.org)
On Sun, Apr 14, 2019 at 12:03:05AM -0400, Maxim Cournoyer wrote:
Toggle quote (15 lines)
> From 1f7535fbe28f7ac96e824b792e9f1a140b8c54cd Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Fri, 5 Apr 2019 00:00:08 -0400
> Subject: [PATCH 3/3] build: go-build-system: Ensure uniform unpacking
> directory.
>
> Depending on whether the source is a directory or an archive, we strip the
> source directory or preserve it, respectively. This change makes it so that
> whether the type of the source, it is unpacked at the expected location given
> by the IMPORT-PATH of the Go build system.
>
> * guix/build/go-build-system.scm: Add the (ice-9 ftw) module.
> (unpack): Add inner procedure to maybe strip the top level directory of an
> archive, document it and use it.
This commit (or patch series) broke the build of Syncthing and maybe
others.
It seems like the the new unpacking code is stripping duplicate
directory names?
It fails like this:
------
starting phase `increase-test-timeout'
Backtrace:
6 (primitive-load "/gnu/store/yfvy06fscz726da5wjvh9jxjsah…")
In ice-9/eval.scm:
191:35 5 (_ _)
In srfi/srfi-1.scm:
863:16 4 (every1 #<procedure 870540 at /gnu/store/zmc0hcmdfg5n4…> …)
In /gnu/store/zmc0hcmdfg5n4kl32vcla4cg9c9bspfg-module-import/guix/build/gnu-build-system.scm:
799:28 3 (_ _)
In ice-9/eval.scm:
619:8 2 (_ #(#(#<directory (guile-user) 5ce140>) (#:inputs # …)))
In /gnu/store/zmc0hcmdfg5n4kl32vcla4cg9c9bspfg-module-import/guix/build/utils.scm:
635:19 1 (with-atomic-file-replacement "src/github.com/syncthin…" …)
In unknown file:
0 (mkstemp! "src/github.com/syncthing/syncthing/build.go…" …)
ERROR: In procedure mkstemp!:
In procedure mkstemp!: No such file or directory
------
And indeed, if you keep the failed build directory, you will see that
the path 'src/github.com/syncthing/syncthing' does not exist, even
though this corresponds to the Go import path specified in the package
definition.
Instead it is like src/github.com/syncthing' which is incorrect.
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlzQVfYACgkQJkb6MLrK
fwgSYA//Tygac1w4WpJpQuHUnQAzCGoWN2g5ZR9kz811zK4Qzz48LNPLq1sB0OQ6
oZnEVPY/fPOmLuajlEzkHJ+3kqcivD9ouYdTJZpyuFWuZT4Ze7E/PRfYKj9z6TpC
HVf3Zj59wNzO70SO928/TPjEEWxhUnAOs1kpBX6kUs7OR6akKHBPFKMsS395V4x0
aH9ucxhrSx3lAZPJ19o92Z8OrHHJ9J/QXxlLhjIBUnQq94rn26N0BxGYifHPSY9e
vMiu6SpeT559zKfdC1JXDHq5mUrRP6Nbqt6O4P8Tnxl2kJWAYH8cw6Yg4ahwrQF2
p+ws1KNpqKj5rl3oMrezzmFzpwgl+hsQTUaMtpvhFFOoOc70Dr38m7YTLZAGOWwq
hLxbWBJEfcqo1tmKunS6rbkMIr70g24qrGHs5KNk6PZql2IFTtiNlpSqEarjifQE
VBK29Q5hK/27QtrWQwfD4x4305ZYnujAL0OQusgyTxmEmL22LkQVA7ZDFOsAAvP+
+h4uokWUIArZ62f8HC9Cy1es/juD5im76TswM7bNjehASeSr5zqst0AOta9+REZh
UlkgMpTgTWVDVsJ8kWLsAuqwZ6VW0yBFUtMueUicr5Ly9qPm8UogcdxXHPQ5Njm6
07DIsquiS2NG+tnOtTnB7JFUb4puDw9u+dXUJ2v3keD4BqtinZk=
=b/W/
-----END PGP SIGNATURE-----