[PATCH] gnu: Add emacs-gnugo.

DoneSubmitted by Maxim Cournoyer.
Details
2 participants
  • Ludovic Courtès
  • Maxim Cournoyer
Owner
unassigned
Severity
normal
M
M
Maxim Cournoyer wrote on 20 Jun 2019 02:01
(name . guix-patches)(address . guix-patches@gnu.org)
878stxruoo.fsf@gmail.com
Hello!
This adds emacs-gnugo, an Emacs mode for playing GNU Go!
Enjoy,
Maxim
From ae2036889369572d08126e4c3a058ba758010e74 Mon Sep 17 00:00:00 2001From: Maxim Cournoyer <maxim.cournoyer@gmail.com>Date: Thu, 20 Jun 2019 08:57:41 +0900Subject: [PATCH 1/3] gnu: Add emacs-ascii-art-to-unicode.
* gnu/packages/emacs-xyz.scm (emacs-ascii-art-to-unicode): New variable.--- gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
Toggle diff (34 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scmindex c5fbb06d8a..93d2a1296c 100644--- a/gnu/packages/emacs-xyz.scm+++ b/gnu/packages/emacs-xyz.scm@@ -9286,6 +9286,27 @@ matches\" in the mode line in various search modes. This is an Emacs port of Anzu.zim.") (license license:gpl3+))) +(define-public emacs-ascii-art-to-unicode+ (package+ (name "emacs-ascii-art-to-unicode")+ (version "1.12")+ (source+ (origin+ (method url-fetch)+ (uri (string-append "https://elpa.gnu.org/packages/ascii-art-to-unicode-"+ version ".el"))+ (sha256+ (base32+ "1w9h2lyriafxj71r79774gh822cz8mry3gdfzyj6ym6v9mvqypna"))))+ (build-system emacs-build-system)+ (home-page "https://elpa.gnu.org/packages/ascii-art-to-unicode.html")+ (synopsis "ASCII to Unicode art converter for Emacs")+ (description "This Emacs package provides the commands @command{aa2u} and+@command{aa2u-rectangle}. Both of these commands can be used to convert+simple ASCII art line drawings to Unicode; the former works on the active+region of the buffer, while the latter works on rectangular selections.")+ (license license:gpl3+)))+ (define-public emacs-emmet-mode (package (name "emacs-emmet-mode")-- 2.21.0
From 68ba627b3603f9bca6e99dc1635aa1a4f401eeaf Mon Sep 17 00:00:00 2001From: Maxim Cournoyer <maxim.cournoyer@gmail.com>Date: Thu, 20 Jun 2019 08:57:50 +0900Subject: [PATCH 2/3] gnu: Add emacs-xpm.
* gnu/packages/emacs-xyz.scm (emacs-xpm): New variable.--- gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
Toggle diff (33 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scmindex 93d2a1296c..b39227f5a3 100644--- a/gnu/packages/emacs-xyz.scm+++ b/gnu/packages/emacs-xyz.scm@@ -12386,6 +12386,26 @@ datastructures as needed, both for method parameters and return values, making using XML-RPC methods fairly transparent to the Lisp code.") (license license:gpl3+)))) +(define-public emacs-xpm+ (package+ (name "emacs-xpm")+ (version "1.0.4")+ (source+ (origin+ (method url-fetch)+ (uri (string-append "https://elpa.gnu.org/packages/xpm-"+ version ".tar"))+ (sha256+ (base32+ "075miyashh9cm3b0gk6ngld3rm8bfgnh4qxnhxmmvjgzf6a64grh"))))+ (build-system emacs-build-system)+ (home-page "https://elpa.gnu.org/packages/xpm.html")+ (synopsis "XPM image editing mode for Emacs")+ (description "This Emacs package makes editing XPM images easy (and maybe+fun). Editing is done directly on the (textual) image format, for maximal+cohesion with the Emacs Way.")+ (license license:gpl3+)))+ (define-public emacs-fish-completion (package (name "emacs-fish-completion")-- 2.21.0
From d6ef391bccbeb398836b7dead18c1c284b26dec1 Mon Sep 17 00:00:00 2001From: Maxim Cournoyer <maxim.cournoyer@gmail.com>Date: Thu, 20 Jun 2019 08:58:47 +0900Subject: [PATCH 3/3] gnu: Add emacs-gnugo.
* gnu/packages/games.scm (emacs-gnugo): New variable.--- gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
Toggle diff (68 lines)diff --git a/gnu/packages/games.scm b/gnu/packages/games.scmindex 202221a987..273ef05319 100644--- a/gnu/packages/games.scm+++ b/gnu/packages/games.scm@@ -40,6 +40,7 @@ ;;; Copyright © 2019 Oleg Pykhalov <go.wigust@gmail.com> ;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com> ;;; Copyright © 2019 Julien Lepiller <julien@lepiller.eu>+;;; Copyright © 2019 Maxim Cournoyer <maxim.cournoyer@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;;@@ -86,6 +87,7 @@ #:use-module (gnu packages cyrus-sasl) #:use-module (gnu packages documentation) #:use-module (gnu packages docbook)+ #:use-module (gnu packages emacs-xyz) #:use-module (gnu packages flex) #:use-module (gnu packages fltk) #:use-module (gnu packages fonts)@@ -159,6 +161,7 @@ #:use-module (gnu packages messaging) #:use-module (gnu packages networking) #:use-module (guix build-system glib-or-gtk)+ #:use-module (guix build-system emacs) #:use-module (guix build-system gnu) #:use-module (guix build-system go) #:use-module (guix build-system meson)@@ -2087,6 +2090,37 @@ Protocol).") (home-page "https://www.gnu.org/software/gnugo/") (license license:gpl3+))) +(define-public emacs-gnugo+ (package+ (name "emacs-gnugo")+ (version "3.1.0")+ (source+ (origin+ (method url-fetch)+ (uri (string-append "https://elpa.gnu.org/packages/gnugo-"+ version ".tar"))+ (sha256+ (base32+ "0xpjvs250gg71qwapdsb1hlc61gs0gpkjds01srf784fvyxx2gf1"))))+ (build-system emacs-build-system)+ (arguments+ `(#:phases (modify-phases %standard-phases+ (add-after 'unpack 'configure-default-gnugo-xpms-variable+ (lambda _+ (substitute* "gnugo.el"+ (("defvar gnugo-xpms nil")+ "defvar gnugo-xpms #'gnugo-imgen-create-xpms"))+ #t)))))+ (propagated-inputs+ `(("emacs-ascii-art-to-unicode" ,emacs-ascii-art-to-unicode)+ ("emacs-xpm" ,emacs-xpm)))+ (home-page "https://elpa.gnu.org/packages/gnugo.html")+ (synopsis "Emacs major mode for playing GNU Go")+ (description "This package provides an Emacs based interface for GNU Go.+It has a graphical mode where the board and stones are drawn using XPM images+and supports the use of a mouse.")+ (license license:gpl3+)))+ (define-public extremetuxracer (package (name "extremetuxracer")-- 2.21.0
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAl0KzOcACgkQEmDkZILmNWI4Wg/+K46pZY4ele7VspO0hnY7uNLnZaL8HUy1KduG16MGeIr6KqY+zUgRVS+hXOsqe7PaHTZDagQoykilWP5Gr0c8N+K7lUZKvMsNiUVr+PMfnEqhQg8GKfqspKia/lMslQz67SvxbmfQn67y4jE6tpBCVqXMs7ICW7YFZNwgPdVPO8Q40UKWqsLRYrJ5C8caeRhQxQrkNJyYkUFTguYxHTBrRSlzuX0z9AcWCyLH+PT0+hNtcRKFFI5yrOV6otZkfU2LyR10iOuzdmn21ldCvRjI59sUSnyU3v/q1+rORaCjZNqy9Lw2mW89j21RPJhRZ4fOdo/lctoKRUOwtuqbnx4P+MEB48ZdU+BirX1MCrC+GXiLOv3/qQwoUgSWYOks+3fanYrAbg97OhvPoJ1gMtpjpiuGACCYUlCJ8ZCgYgAts7bbg51MBcBg2XgM3vlh1lB+NlQda3Oz26Mv6rg4N7+ImbE+MPMrkEfuyib0RsdqnfzhN0HuYlvMHj5RxESDD4GlV6JzVcVP833EGBXdMsYACYGBoCjngUxQKQpfYb1DwE0TTgPsw5vshl6r//uFld3neMIwwRFQPXOXTiGWz/N8C537ly6yI482M6BqBTsZ3T+dgYHtNoOKoh9AO8I0+ed5GRTMzon5OhDtRf7wtihUgcaFbAwSm/KKbf4v3oF3WW4==0eKs-----END PGP SIGNATURE-----
L
L
Ludovic Courtès wrote on 24 Jun 2019 23:15
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 36300@debbugs.gnu.org)
878stq3csk.fsf@gnu.org
Hello Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
Toggle quote (2 lines)> This adds emacs-gnugo, an Emacs mode for playing GNU Go!
The patches LGTM! I would perhaps put emacs-gnugo in emacs-xyz.scmrather than games.scm, but I don’t have a strong opinion.
Thanks!
Ludo’.
M
M
Maxim Cournoyer wrote on 26 Jun 2019 06:08
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 36300@debbugs.gnu.org)
8736jxc7jb.fsf@gmail.com
Hello Ludovic!
Ludovic Courtès <ludo@gnu.org> writes:
Toggle quote (10 lines)> Hello Maxim,>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:>>> This adds emacs-gnugo, an Emacs mode for playing GNU Go!>> The patches LGTM! I would perhaps put emacs-gnugo in emacs-xyz.scm> rather than games.scm, but I don’t have a strong opinion.>
Thanks for the review! I've adapted the patch with your proposed changesand pushed to master (commit dc7c489605)
Thank you,
Maxim
M
M
Maxim Cournoyer wrote on 26 Jun 2019 06:09
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 36300-done@debbugs.gnu.org)
871rzhc7iv.fsf@gmail.com
Hello Ludovic!
Ludovic Courtès <ludo@gnu.org> writes:
Toggle quote (10 lines)> Hello Maxim,>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:>>> This adds emacs-gnugo, an Emacs mode for playing GNU Go!>> The patches LGTM! I would perhaps put emacs-gnugo in emacs-xyz.scm> rather than games.scm, but I don’t have a strong opinion.>
Thanks for the review! I've adapted the patch with your proposed changesand pushed to master (commit dc7c489605)
Thank you,
Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 36300@debbugs.gnu.org