[PATCH] gnu: Add beets-bandcamp.

  • Done
  • quality assurance status badge
Details
3 participants
  • Tobias Geerinckx-Rice
  • swedebugia
  • Jakob L. Kreuze
Owner
unassigned
Submitted by
Jakob L. Kreuze
Severity
normal
J
J
Jakob L. Kreuze wrote on 28 Jun 2019 02:41
(address . guix-patches@gnu.org)
877e968rtq.fsf@sdf.lonestar.org
* gnu/packages/music.scm (beets-bandcamp): New variable.
---
gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

Toggle diff (55 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ca9cbd3343..fd8898a706 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -21,6 +21,7 @@
;;; Copyright © 2018 Björn Höfling <bjoern.hoefling@bjoernhoefling.de>
;;; Copyright © 2019 Gabriel Hondet <gabrielhondet@gmail.com>
;;; Copyright © 2019 Timotej Lazar <timotej.lazar@araneo.si>
+;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -129,6 +130,7 @@
#:use-module (gnu packages tcl)
#:use-module (gnu packages texinfo)
#:use-module (gnu packages tex)
+ #:use-module (gnu packages time)
#:use-module (gnu packages tls)
#:use-module (gnu packages version-control)
#:use-module (gnu packages video)
@@ -2816,6 +2818,32 @@ metadata as it goes using the MusicBrainz database. Then it provides a variety
of tools for manipulating and accessing your music.")
(license license:expat)))
+(define-public beets-bandcamp
+ (package
+ (name "beets-bandcamp")
+ (version "0.1.3")
+ (source (origin
+ (method url-fetch)
+ (uri (pypi-uri "beets-bandcamp" version))
+ (sha256
+ (base32
+ "04awg0zdhhg5h510fc1p3qkvr2l1qm6nf85hlr9z8im8a7xlka0i"))))
+ (build-system python-build-system)
+ (arguments '(#:tests? #f)) ; there are no tests
+ (propagated-inputs
+ `(("beets" ,beets)
+ ("python-isodate" ,python-isodate)))
+ (inputs
+ `(("python-six" ,python-six)
+ ("python-requests" ,python-requests)
+ ("python-beautifulsoup4" ,python-beautifulsoup4)))
+ (home-page "https://github.com/unrblt/beets-bandcamp")
+ (synopsis "Bandcamp plugin for beets")
+ (description "Plugin for beets to automatically obtain tag data from
+https://bandcamp.com/. The plugin is also capable of getting lyrics for songs
+and album art using the beets FetchArt plugin.")
+ (license license:gpl2)))
+
(define-public milkytracker
(package
(name "milkytracker")
--
2.22.0
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl0VYiEACgkQ9Qb9Fp2P
2VoSiRAArhVeDZ918eJICJMX7lPRVIRCPQ34MWEKOQjWoblnoavQzeCv9K7EEyG+
TE5yBoIc65+FBzgysTIr6DbAJujLaPOf7TGJY4hhoI5dr3JX3wyU6tWd5qs7jCKe
A3d3qJmHX9aohUti1cs851YeExU/k+cU03rQnaMN56ocCp7mxB+GN1zbi0Xxaugo
wz4BZYs6ihMh0D+yXJ4yD77N01NGUdt+/fd9GqpCmdwLCpczHWvcQ70JTkMlh9ni
WwFTYFVBuAmMpSOj4krtgpLZrG+ZGbql5tM0Nt936T3fXAjG9Txvj9/1n8SFnGhA
LVoEuYwmdZxOn00hBzTWwKanyLrRFYJHtjuGGUt8b5Gx4I4pTr1UIRgOQzfNV4Qw
bhVvW4IXEYx5W/ilBDcR4+894x6938vOtID0uicF27GffRXgiAcYQ82Cdknkl/Zq
Zfi1kcvxQpSRFszAy/acHico8vplUKHowUYva2EjeXuqJHNELjaSmNSw72HRtKGa
hAg16QNoeo3CdiMdJD1IM/aJNP4q3bN366rZ4Dh6qdeVhYSBZYMPn9qIPCURXYSj
hRfX/JIc4IsCpey83EN6uDicahxyU0ocg/nUCUolCp/kujEa6mDzQW/tFbb2P/+N
QQCD1FkbpE1B9AqOWnx/iMBykk7gN297KcySjDB2CqXK5zZQbfI=
=X2tV
-----END PGP SIGNATURE-----

S
S
swedebugia wrote on 28 Jun 2019 07:00
(address . guix-patches@gnu.org)
d8b88317-b346-6b8d-3539-f43d2b9310ab@riseup.net
On 2019-06-28 02:41, Jakob L. Kreuze wrote:
Toggle quote (60 lines)
> * gnu/packages/music.scm (beets-bandcamp): New variable.
> ---
> gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index ca9cbd3343..fd8898a706 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -21,6 +21,7 @@
> ;;; Copyright © 2018 Björn Höfling <bjoern.hoefling@bjoernhoefling.de>
> ;;; Copyright © 2019 Gabriel Hondet <gabrielhondet@gmail.com>
> ;;; Copyright © 2019 Timotej Lazar <timotej.lazar@araneo.si>
> +;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -129,6 +130,7 @@
> #:use-module (gnu packages tcl)
> #:use-module (gnu packages texinfo)
> #:use-module (gnu packages tex)
> + #:use-module (gnu packages time)
> #:use-module (gnu packages tls)
> #:use-module (gnu packages version-control)
> #:use-module (gnu packages video)
> @@ -2816,6 +2818,32 @@ metadata as it goes using the MusicBrainz database. Then it provides a variety
> of tools for manipulating and accessing your music.")
> (license license:expat)))
>
> +(define-public beets-bandcamp
> + (package
> + (name "beets-bandcamp")
> + (version "0.1.3")
> + (source (origin
> + (method url-fetch)
> + (uri (pypi-uri "beets-bandcamp" version))
> + (sha256
> + (base32
> + "04awg0zdhhg5h510fc1p3qkvr2l1qm6nf85hlr9z8im8a7xlka0i"))))
> + (build-system python-build-system)
> + (arguments '(#:tests? #f)) ; there are no tests
> + (propagated-inputs
> + `(("beets" ,beets)
> + ("python-isodate" ,python-isodate)))
> + (inputs
> + `(("python-six" ,python-six)
> + ("python-requests" ,python-requests)
> + ("python-beautifulsoup4" ,python-beautifulsoup4)))
> + (home-page "https://github.com/unrblt/beets-bandcamp")
> + (synopsis "Bandcamp plugin for beets")
> + (description "Plugin for beets to automatically obtain tag data from
> +https://bandcamp.com/. The plugin is also capable of getting lyrics for songs
> +and album art using the beets FetchArt plugin.")
> + (license license:gpl2)))
> +
> (define-public milkytracker
> (package
> (name "milkytracker")
>

LGTM. It is reproducible.

--
Cheers Swedebugia
T
T
Tobias Geerinckx-Rice wrote on 28 Jun 2019 14:25
(address . 36409-done@debbugs.gnu.org)
87zhm1c2xd.fsf@nckx
Jakob,

Pushed with minor cosmetic adjustments as
4ee2cce327ce839f471fb28a095fe7299ed822af.

Jakob L. Kreuze wrote:
Toggle quote (6 lines)
> + (description "Plugin for beets to automatically obtain tag
> data from
> +https://bandcamp.com/. The plugin is also capable of getting
> lyrics for songs
> +and album art using the beets FetchArt plugin.")

Thank you for (presumably) taking the time to write a better
description than upstream's.

I've tweaked it only slightly (mainly starting with a full
sentence & adding @uref for the URL), promise.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXRYHLgAKCRANsP+IT1Vt
eYl3AQDUCSdrYzb7tMfTEY5+Adm4mPxLDudDTAaJU7zL4cs3WAD9FKh9SoKxuuG4
nMKwmPubnL2OsD+56gqSqK1eR2ts3w4=
=DO24
-----END PGP SIGNATURE-----

Closed
J
J
Jakob L. Kreuze wrote on 28 Jun 2019 15:42
Re: bug#36409: [PATCH] gnu: Add beets-bandcamp.
(address . 36409@debbugs.gnu.org)(address . me@tobias.gr)
87ftnthlm8.fsf@sdf.lonestar.org
Hi Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

Toggle quote (3 lines)
> Thank you for (presumably) taking the time to write a better
> description than upstream's.

Yeah, I didn't think upstream's description fit the guidelines in the
manual's "Synopses and Descriptions" section.

Toggle quote (3 lines)
> I've tweaked it only slightly (mainly starting with a full sentence &
> adding @uref for the URL), promise.

Much appreciated, thank you :]

Regards,
Jakob
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl0WGU8ACgkQ9Qb9Fp2P
2VowWxAAiUvIO7UZzJrTqlkOuFa6q6VmU1e9qPmbn3X4BsidjWBKJzbWbThHB9AM
VGg2dGdWoirnaQvh4douEXc0cEwREhGIED0q6/6m7lR4Z41/cyCkNFz1DiHA3dCt
7hZ9zyC8YGpJjs4pQDQS2Spw/UAOq54rMi2jM7z63/XtgTz52K4KP54y8F5p7g9y
+nS0Rx/LsexV1jOGPnJHVpmq4KODnLi3CL5puDFWw8ZDxzYKtAD9hq8leCaR8Pb2
G2cv2ZBGnAjnAkCmeTxdpZGCbQ36TeOg3CLhOwARfCwgJZxCevWNBZVv5Tk/u8PS
zZzHw1210PzA3rG49mZpZ6CPXCOaw9uQ7mkv+IpdV4viX6gxym9uLEDVBayfF72I
pzVJEJslExZUH1+/hdA+ft8KdSRu7vOlwWvOpEbZXvTjj0hy2cAcy7tTVclDlwZw
hrULYO0hAMtbL9gcNO77sExwU5/WL2uv2KKFtlaJFisFzQa/B6U7TX3GKdea6X4f
ebBBxq+w1C1dD9J4DCAqRv0TkZDwTt8SiKq3/OIV4SIgs3pawL8ny3WrnK8Bqrtv
VTzayLNcm3jmoZwJPwTmv8l1PhKPotzhg9CWx066X1h+WI8DL/tAsjEhvvQbqJyc
fLArvTNhBsjYQ/XkKegdZDYCLkco6v1/E71JJLwKtCbXVjGCG2o=
=54mY
-----END PGP SIGNATURE-----

?