[PATCH] gnu: pulseaudio: Add optional X11 inputs.

  • Done
  • quality assurance status badge
Details
2 participants
  • Diego Nicola Barbato
  • Marius Bakke
Owner
unassigned
Submitted by
Diego Nicola Barbato
Severity
normal
D
D
Diego Nicola Barbato wrote on 1 Oct 2019 12:42
(address . guix-patches@gnu.org)
87wodowxvl.fsf@GlaDOS.home
Hello Guix,

Pulseaudio is currently built without the optional X11 modules (e.g
module-x11-bell, which makes it possible to customize the x11-bell
sound). This patch adds those X11 libraries to Pulseaudios's inputs,
which are necessary for the modules to be built.

Regards,

Diego
From 3bcfda0a26a572b6789a469ea6da4d384db4be47 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <dnbarbato@posteo.de>
Date: Tue, 1 Oct 2019 11:31:42 +0200
Subject: [PATCH] gnu: pulseaudio: Add optional X11 inputs.

* gnu/packages/pulseaudio.scm (pulseaudio)[inputs]: Add libxcb, libice, libsm,
and libxtst.
---
gnu/packages/pulseaudio.scm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Toggle diff (27 lines)
diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index fa48d8a7a6..f0f8574078 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -50,7 +50,8 @@
#:use-module (gnu packages python-xyz)
#:use-module (gnu packages python-web)
#:use-module (gnu packages pkg-config)
- #:use-module (gnu packages xiph))
+ #:use-module (gnu packages xiph)
+ #:use-module (gnu packages xorg))
(define-public libsndfile
(package
@@ -187,6 +188,10 @@ rates.")
("libltdl" ,libltdl)
("fftwf" ,fftwf)
("avahi" ,avahi)
+ ("libxcb" ,libxcb) ; For enabling X11.
+ ("libice" ,libice) ; For enabling X11.
+ ("libsm" ,libsm) ; For enabling X11.
+ ("libxtst" ,libxtst) ; For enabling X11.
("eudev" ,eudev))) ;for the detection of hardware audio devices
(native-inputs
`(("check" ,check)
--
2.23.0
M
M
Marius Bakke wrote on 13 Oct 2019 23:09
874l0c2vza.fsf@devup.no
Diego Nicola Barbato <dnbarbato@posteo.de> writes:

Toggle quote (7 lines)
> Hello Guix,
>
> Pulseaudio is currently built without the optional X11 modules (e.g
> module-x11-bell, which makes it possible to customize the x11-bell
> sound). This patch adds those X11 libraries to Pulseaudios's inputs,
> which are necessary for the modules to be built.

This patch increases the size of pulseaudio from 187.2 MiB to 189.4 MiB,
which is OK IMO.

Pushed to 'staging' with a minor cosmetic change in 531b63eba7.

Thank you!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl2jkpkACgkQoqBt8qM6
VPq/qQf8DewFBbRFrcAiGWZsyePeHhVVBqQA1dlfvSTDBWA2DSgrrpaGI+2XxwW3
Y7XA0FYjAQHRI8DX0FftO9E4bTg1XXR5ZXMqYuK3NJeO6KLXq62tXIRIpq6kDYtK
gICe/FWv3/Spo7vR2fyfIuvVL/A2nrFhy0XWKBS305wI5VZPBwOg761GqXbRuUhh
ABwM6ak0YZmF97ZDbgrewef0tt2BMAaOw7pSqMisJMBPl0YlzL2S8qbBsdSMR+uL
MiMK3b8uGvmin552x6tp9lQnyFzR390bFhzR4Xq9bz6J8BkKZsy8AdoeZ1fT6BMO
eeQkT957TGIBWMBTN/meY4w8TGOo5A==
=pZBU
-----END PGP SIGNATURE-----

Closed
?