[PATCH] gnu: Add playerctl.

DoneSubmitted by David Wilson.
Details
2 participants
  • David Wilson
  • Ludovic Courtès
Owner
unassigned
Severity
normal
D
D
David Wilson wrote on 11 Oct 2019 14:52
(address . guix-patches@gnu.org)
5e3cd1fc-bb34-48cc-9f28-24bcec0333c9@www.fastmail.com
Hi all!
This patch adds the 'playerctl' command line utility for controlling media players that support MPRIS. As this is my first attempt at packaging software for Guix, please let me know if anything can be improved. I've run through most of the steps in the packaging checklist of the manual so I feel pretty confident that it's in good shape.
Also, this is my first contribution to a GNU project (!!) so please advise if I need to follow any "new contributor" protocol.
Thanks!
David
L
L
Ludovic Courtès wrote on 13 Oct 2019 23:58
(name . David Wilson)(address . david@daviwil.com)(address . 37701-done@debbugs.gnu.org)
875zks8fz6.fsf@gnu.org
Hi David,
"David Wilson" <david@daviwil.com> skribis:
Toggle quote (4 lines)> This patch adds the 'playerctl' command line utility for controlling media players that support MPRIS. As this is my first attempt at packaging software for Guix, please let me know if anything can be improved. I've run through most of the steps in the packaging checklist of the manual so I feel pretty confident that it's in good shape.>> Also, this is my first contribution to a GNU project (!!) so please advise if I need to follow any "new contributor" protocol.
Looks like you followed the protocol perfectly well! :-)
Toggle quote (7 lines)> From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001> From: David Wilson <david@daviwil.com>> Date: Thu, 10 Oct 2019 22:06:43 -0700> Subject: [PATCH] gnu: Add playerctl.>> * gnu/packages/music.scm (playerctl): New variable.
Applied with the minor changes below: the ‘file-name’ issue was reportedby ‘guix lint’, and the license is LGPLv3-or-later because source fileheaders carry the “or any later version” wording.
Thank you!
Ludo’.
Toggle diff (27 lines)diff --git a/gnu/packages/music.scm b/gnu/packages/music.scmindex dcda71a43d..a051caca2b 100644--- a/gnu/packages/music.scm+++ b/gnu/packages/music.scm@@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version))))+ (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz"))))@@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config)))- (synopsis "Controls MPRIS-supporting media player applications")+ (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl@@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl")- (license license:lgpl3)))+ (license license:lgpl3+)))
Closed
D
D
David Wilson wrote on 14 Oct 2019 00:11
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 37701-done@debbugs.gnu.org)
146CCE75D21B3446.d994f6e3-509c-4a25-8cab-f9a20bc806d6@mail.outlook.com
Thanks so much Ludo! I wasn't sure about whether the license included future versions, will keep an eye on the file headers in the future. David



On Sun, Oct 13, 2019 at 2:59 PM -0700, "Ludovic Courtès" <ludo@gnu.org> wrote:









Hi David,
"David Wilson" skribis:
Toggle quote (4 lines)> This patch adds the 'playerctl' command line utility for controlling media players that support MPRIS. As this is my first attempt at packaging software for Guix, please let me know if anything can be improved. I've run through most of the steps in the packaging checklist of the manual so I feel pretty confident that it's in good shape.>> Also, this is my first contribution to a GNU project (!!) so please advise if I need to follow any "new contributor" protocol.
Looks like you followed the protocol perfectly well! :-)
Toggle quote (7 lines)> From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001> From: David Wilson > Date: Thu, 10 Oct 2019 22:06:43 -0700> Subject: [PATCH] gnu: Add playerctl.>> * gnu/packages/music.scm (playerctl): New variable.
Applied with the minor changes below: the ‘file-name’ issue was reportedby ‘guix lint’, and the license is LGPLv3-or-later because source fileheaders carry the “or any later version” wording.
Thank you!
Ludo’.
Attachment: file
Toggle diff (27 lines)diff --git a/gnu/packages/music.scm b/gnu/packages/music.scmindex dcda71a43d..a051caca2b 100644--- a/gnu/packages/music.scm+++ b/gnu/packages/music.scm@@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version))))+ (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz"))))@@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config)))- (synopsis "Controls MPRIS-supporting media player applications")+ (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl@@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl")- (license license:lgpl3)))+ (license license:lgpl3+)))
Toggle diff (27 lines)diff --git a/gnu/packages/music.scm b/gnu/packages/music.scmindex dcda71a43d..a051caca2b 100644--- a/gnu/packages/music.scm+++ b/gnu/packages/music.scm@@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version))))+ (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz"))))@@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config)))- (synopsis "Controls MPRIS-supporting media player applications")+ (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl@@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl")- (license license:lgpl3)))+ (license license:lgpl3+)))
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 37701@debbugs.gnu.org