[PATCH] gnu: guix-data-service: Enable build time tests.

DoneSubmitted by Christopher Baines.
Details
2 participants
  • Ludovic Courtès
  • Christopher Baines
Owner
unassigned
Severity
normal
C
C
Christopher Baines wrote on 21 Oct 2019 19:42
(address . guix-patches@gnu.org)
20191021174223.28196-1-mail@cbaines.net
Previously the tests were not run, as PostgreSQL wasn't running at buildtime. Now there's a new target, check-with-tmp-database that uses ephemeralpgto run the tests without relying on an externally managed PostgreSQL service.
* gnu/packages/web.scm (guix-data-service)[arguments]: Remove #:tests? #f, andset #:test-target to "check-with-tmp-database".[native-inputs]: Add ephemeralpg.--- gnu/packages/web.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Toggle diff (28 lines)diff --git a/gnu/packages/web.scm b/gnu/packages/web.scmindex 5487eb2e71..a91059f73d 100644--- a/gnu/packages/web.scm+++ b/gnu/packages/web.scm@@ -4044,11 +4044,11 @@ CDF, Atom 0.3, and Atom 1.0 feeds.") "0awfvps7k9bpg3gpgc93y401g7pjabx7mr9960vigad8vddhixqi")))) (build-system gnu-build-system) (arguments- '(#:tests? #f ; TODO Tests require PostgreSQL- #:modules ((guix build utils)+ '(#:modules ((guix build utils) (guix build gnu-build-system) (ice-9 rdelim) (ice-9 popen))+ #:test-target "check-with-tmp-database" #:phases (modify-phases %standard-phases (add-after 'set-paths 'set-GUIX_ENVIRONMENT@@ -4106,6 +4106,7 @@ CDF, Atom 0.3, and Atom 1.0 feeds.") `(("guile" ,guile-2.2) ("autoconf" ,autoconf) ("automake" ,automake)+ ("ephemeralpg" ,ephemeralpg) ("emacs-with-modules" ,(directory-union "emacs-union" (list emacs-no-x-- 2.23.0
L
L
Ludovic Courtès wrote on 22 Oct 2019 18:17
(name . Christopher Baines)(address . mail@cbaines.net)(address . 37855@debbugs.gnu.org)
87zhhsycua.fsf@gnu.org
Hi,
Christopher Baines <mail@cbaines.net> skribis:
Toggle quote (8 lines)> Previously the tests were not run, as PostgreSQL wasn't running at build> time. Now there's a new target, check-with-tmp-database that uses ephemeralpg> to run the tests without relying on an externally managed PostgreSQL service.>> * gnu/packages/web.scm (guix-data-service)[arguments]: Remove #:tests? #f, and> set #:test-target to "check-with-tmp-database".> [native-inputs]: Add ephemeralpg.
Nice, LGTM!
I wonder: can’t you just have “make check” do this, or do you want tohave “make check” talk to a real database instead?
(For the Guix test suite, ‘test-env’ spawns a daemon with a temporarystore for test purposes; I wonder if the situation is comparable here.)
Thanks,Ludo’.
C
C
Christopher Baines wrote on 23 Oct 2019 00:08
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 37855-done@debbugs.gnu.org)
874l00qvpr.fsf@cbaines.net
Ludovic Courtès <ludo@gnu.org> writes:
Toggle quote (14 lines)> Hi,>> Christopher Baines <mail@cbaines.net> skribis:>>> Previously the tests were not run, as PostgreSQL wasn't running at build>> time. Now there's a new target, check-with-tmp-database that uses ephemeralpg>> to run the tests without relying on an externally managed PostgreSQL service.>>>> * gnu/packages/web.scm (guix-data-service)[arguments]: Remove #:tests? #f, and>> set #:test-target to "check-with-tmp-database".>> [native-inputs]: Add ephemeralpg.>> Nice, LGTM!
Great, I've pushed this now as 353f5f7aa7ea575f9f04d3a0b277bbb8012b942d.
Toggle quote (3 lines)> I wonder: can’t you just have “make check” do this, or do you want to> have “make check” talk to a real database instead?
It's mostly a new target as I already had "make check" just run thetests, but yeah, it might be more useful for "make check" to setup anempty database, then run the tests. I'm not quite sure yet.
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl2vffBfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNFODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE9Xfs4w//RfJPmZncbmcSqct9h1uLUzeQ0u/0ciewYU23DPslnxQo0a9XOZ2jO7i9toqZPoPsMSMvZXyhljg4lawyp0yav9VdN7JTrbrVPFCqaJvTJFHfqVuHQfhjtmzqltyvpPPS56zB/NLbfP4acPCRX6iLUEogZoc/N27IPOll9TDfoJh6Y14MVBgTG001YUJUHE4c6/E75nKwJyDby3vhQef0o+X1JiJZOD1UJXGVl23U5ZGkb3GZJml4RvdUj8eZ0iADfwzaxZfEAmMTA6hWHDaGD2ZfCmyNRkWWvenrJpXSN6BTbMswxxa6DSX4d/CwMBTNtyC7PqVO3s4mkGB4nBY1P1Vi34hn2ubcft2nXze5rxrJOgfejGznreCD//Az6KwaSA64FoCdPjFZycxo5fAVpo+k9U5x6CHDtNWpSBKPh07OLvuHkhGbZSOMIJSf9rsJEChgdGV9YgLPvwukgS2FY325hjJ4vjrpuXbqHU6JuS0XHv3zUEpbdhL9RtBHZy47pmbACLethVm1GgPDVX82BVMRT6+9lpCd1zSQpBBkBdzGL16WDc5KWISIuuaoyFlqiliZV5ohxawp+hWBs1BDMDrSroyCkdl17D0cFfVZdN25HxHO+WMmt55PB+XAw/iB7LBNbHGF1ihs+jeQIPKoZRAFXGGNC5koY9HxjNQH7tY==ecW1-----END PGP SIGNATURE-----
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 37855@debbugs.gnu.org