[PATCH] adding copyq 3.9.3 to xdisorg.scm

  • Done
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Thierry
Owner
unassigned
Submitted by
Thierry
Severity
normal
T
T
Thierry wrote on 25 Dec 2019 22:07
(address . guix-patches@gnu.org)
3ba0f830-f7d1-3301-a1a6-99a045735dd0@moncourriel.eu

From 3e5fb3f5fc852b0f512b6771c6950f4947f66dd7 Mon Sep 17 00:00:00 2001
From: Grillon <thierry@moncourriel.eu>
Date: Wed, 25 Dec 2019 21:22:42 +0100
Subject: [PATCH] gnu: copyq(clipboard manager): added v3.9.3

* gnu/packages/xdisorg.scm (copyq): added from 3.9.3
---
gnu/packages/xdisorg.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

Toggle diff (49 lines)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index b1759eabb2..9ee713de2f 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -85,6 +85,7 @@
#:use-module (gnu packages guile)
#:use-module (gnu packages xml)
#:use-module (gnu packages gtk)
+ #:use-module (gnu packages qt)
#:use-module (gnu packages xorg)
#:use-module (gnu packages fontutils)
#:use-module (gnu packages bison)
@@ -229,6 +230,34 @@ with X11 or Wayland, or in a text terminal with ncurses.")
(license (list license:gpl3+ ; client program[s] and other sources
license:lgpl3+)))) ; library and bindings
+(define-public copyq
+(package
+ (name "copyq")
+ (version "3.9.3")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/hluk/CopyQ/archive/v" version
+ ".tar.gz"))
+ (sha256
+ (base32
+ "154yccvlyhr6dml29cvkaqi8277vshmpydvy6ar125qm74q2rib5"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")
+ #:tests? #f))
+ (inputs `(("qtbase" ,qtbase)
+ ("qtx11extras" ,qtx11extras)
+ ("qtsvg" ,qtsvg)
+ ("qtscript" ,qtscript)))
+ (synopsis "Good qt clipboard manager")
+ (description "CopyQ is clipboard manager –
+ a desktop application which stores content of the system clipboard
+ whenever it changes and allows to search the history
+ and copy it back to the system clipboard
+ or paste it directly to other applications.")
+ (home-page "https://hluk.github.io/CopyQ/")
+ (license license:gpl3+)))
+
(define-public xclip
(package
(name "xclip")
--
2.24.1
E
E
Efraim Flashner wrote on 26 Dec 2019 07:56
(name . Thierry)(address . thierry@moncourriel.eu)(address . 38744@debbugs.gnu.org)
20191226065654.GI23018@E5400
Thank you for your patch! A couple of comments inline.

On Wed, Dec 25, 2019 at 10:07:24PM +0100, Thierry wrote:
Toggle quote (37 lines)
>

> From 3e5fb3f5fc852b0f512b6771c6950f4947f66dd7 Mon Sep 17 00:00:00 2001
> From: Grillon <thierry@moncourriel.eu>
> Date: Wed, 25 Dec 2019 21:22:42 +0100
> Subject: [PATCH] gnu: copyq(clipboard manager): added v3.9.3
>
> * gnu/packages/xdisorg.scm (copyq): added from 3.9.3
> ---
> gnu/packages/xdisorg.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> index b1759eabb2..9ee713de2f 100644
> --- a/gnu/packages/xdisorg.scm
> +++ b/gnu/packages/xdisorg.scm
> @@ -85,6 +85,7 @@
> #:use-module (gnu packages guile)
> #:use-module (gnu packages xml)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages qt)
> #:use-module (gnu packages xorg)
> #:use-module (gnu packages fontutils)
> #:use-module (gnu packages bison)
> @@ -229,6 +230,34 @@ with X11 or Wayland, or in a text terminal with ncurses.")
> (license (list license:gpl3+ ; client program[s] and other sources
> license:lgpl3+)))) ; library and bindings
>
> +(define-public copyq
> +(package
> + (name "copyq")
> + (version "3.9.3")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/hluk/CopyQ/archive/v" version
> + ".tar.gz"))

tarballs from github with the '/archive/' string are autogenerated and
can be regenerated in the future, leading to a hash mismatch. I checked
the release page and it looks like our best option is to use the .zip
file. (This also means you'll need to add unzip to native-inputs)

Toggle quote (8 lines)
> + (sha256
> + (base32
> + "154yccvlyhr6dml29cvkaqi8277vshmpydvy6ar125qm74q2rib5"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")
> + #:tests? #f))

Are there no tests or can the test suite not be run? Please leave a note :)

Toggle quote (6 lines)
> + (inputs `(("qtbase" ,qtbase)
> + ("qtx11extras" ,qtx11extras)
> + ("qtsvg" ,qtsvg)
> + ("qtscript" ,qtscript)))
> + (synopsis "Good qt clipboard manager")

Go ahead and change this to something else. Checking the repo I'd go
with "Clipboard manager with advanced features".

Toggle quote (6 lines)
> + (description "CopyQ is clipboard manager –
> + a desktop application which stores content of the system clipboard
> + whenever it changes and allows to search the history
> + and copy it back to the system clipboard
> + or paste it directly to other applications.")

Unfortunately the description reads to me like bad poetry :p I copied
some text from the repo and re-wrapped it below:

(description "CopyQ is clipboard manager with editing and scripting
features. CopyQ monitors system clipboard and saves its content in customized
tabs. Saved clipboard can be later copied and pasted directly into any
application.)

Toggle quote (11 lines)
> + (license license:gpl3+)))
> +
> (define-public xclip
> (package
> (name "xclip")
> --
> 2.24.1
>


--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4EWbMACgkQQarn3Mo9
g1EjqQ//dBwxcN4+cMDLxQace0VQmLTaYX1McxnhpcjKDsC9p4WAK8CBtclaBKS3
zaj6DEAxYvlBpDkL4ROzK2I9ivVgl0dXZcnHRPNk4PxD4h3nRz9WGd+8yPJ0Bo3Q
j++H7VLiEEfgnT6pBnPTQomzfqlGtc79by8cMpek/hVbJV+zdbk3vbUWXSWrmrfy
mvAPjsHTGpf1FmcTFQRp10770SdpqiDVOGfc+oNp6sL7b6eAZ2+NKiPqnoUd/gse
hNPoKfxRQMuFVpROHzEtHBJWdoBMmTKNy+B3+38She0zuxiFfbkq9GCGZ0Ta96OA
gwFrfOtzY+M9vp0Q+RhPpcGZxpQ3yjJUA43jHl0NLOVs8s84p7FAPXkjNLwdRGdd
Vm2+8vWPoAYgoESVqgO3EcQ7r2hP1qI4x15IkDQb2MiFan3ea7IaprGdGOyHTMAE
zF/PRXSQpFrFHamFkEvxWJCSDOc9XD66jBGO2XmMjwiti86lk8hBFAEUrMBifBlL
MUpNrxyRUFjYUnuw0bOqKf1vWfU2IFmfpi5D5OzpNWfvuLxWCLm7K7CjxP5gU91m
HAbaTDuVPWhuQKnXg4L7cBFOHkfPmIqaHkEBM671MUipGl1ubs10bzPTiwO9aJDx
zGQAXuBtjvRyVDq8jNoZxEDM+jIV1idzHBa4KkNdccbCQOQ3nNs=
=wUQf
-----END PGP SIGNATURE-----


E
E
Efraim Flashner wrote on 28 Dec 2019 21:31
(address . 38744-done@debbugs.gnu.org)
20191228203153.GW23018@E5400
Patch pushed with discussed changes.


--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4Hu7kACgkQQarn3Mo9
g1FeqBAAuHTjij8jjtRvJCGix2EOEAPPdJg4ickOi/f4e5moVo1HDMJlgU4DZfvr
m0AgBgq1loNievt/DVyII+t9YF2gDEZ901i1TB8xME4HDhhTnx4Rg2FxZAvzv6Ba
AcA3AZdoxqEppy1fHEVzcm1hDapAV8GU2ZP1bONUUBX+Rvgp7Gj4QSJ4DWZ1kQP5
RgNmjWVJMOuf3MsqOJwsZ+S/CwRaYHA0je/NEuKVuT0K38b2oNV6NeJzyUaW801m
9x5AAJ8zMVYT7J+51+Co92QjeiqvaCIOnHuKzbT4e+QqKqvq5LBAlHDorLq3GGDK
QcNwdvUfvf6oQ4BW1ZHOcqQVW/IwR2pNmpVtpXu6n1vqNAEzz8tuDMg/mjCOQsyh
1F3Tn6bODLBZZ5BuMsnPQEzZdJprsXJ8HC55i9D1d3ZFmhyEB3ZxiBwURtaZCR3s
KdVfrDDiz/0w2YcGjP+XIMtDW6ITMdQzNmLd5z+t7Q17Iu6K9IewRUkeaplkAHjL
UMVOH6u2AybDjgyt+UOqU9vzpbmClqNFf5l8D3p7Sq6Bsbjj5x6By1j+t/rWHZqV
PuoA86sg+PZigD43ACq+UL3aq5WkXKYNjpgI0E+/aDpkCvJVi3IYedorASF57SlE
O1Rrt6zRQigma33ufNxl9uiLcWbgXJM2aH0eaE8ikkPQ7jqHh9w=
=PDZ0
-----END PGP SIGNATURE-----


Closed
?