John Soo <jsoo1@asu.edu> writes:
Toggle quote (6 lines)
> Hi Guix,>> I realized my last patch was based on previous work.>> I cherry-picked this one onto master.
Hi John,
Thanks for the patch. I've now pushed this as1d5c93d9f8a13588695490db6516b40f54e91fa2.
I made a few changes, I move the package up from the bottom of thefile. I'd always recommend not adding new packages at the bottom of themodule files, as if everyone does this, it becomes harder to applypatches because there are more conflicts. In this case, I think thispatch ended up conflicting with your addition of emacs-haskell-snippets,also to the bottom of the emacs-xyz.scm file.
I also tweaked emacs-evil to be a propagated input, just because thatlooked to be what the existing emacs-evil-... packages do, and I tweakedthe description to start with "This package lets you " so it reads as acomplete sentance.
Thanks again,
Chris