gnu: Update libxfce4ui to 4.15.2.

  • Done
  • quality assurance status badge
Details
3 participants
  • Danny Milosavljevic
  • Tobias Geerinckx-Rice
  • Naga Malleswari
Owner
unassigned
Submitted by
Naga Malleswari
Severity
normal
N
N
Naga Malleswari wrote on 7 Apr 2020 14:55
b3aac476-62de-b714-76fd-7268d6d98ac8@riseup.net
Submission of patch for updating description for libxfce4ui

--
Regards
NagaMalli
From 95e1a33913a13e49fe64a54222bf950dea8c54f3 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Tue, 7 Apr 2020 18:22:41 +0530
Subject: [PATCH] gnu: Update libxfce4ui to 4.15.2.

* gnu/packages/xfce.scm (libxfce4ui): Update to 4.15.2.
---
gnu/packages/xfce.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0628b03207..d0f7da61b3 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -166,7 +166,7 @@ storage system.")
(define-public libxfce4ui
(package
(name "libxfce4ui")
- (version "4.14.1")
+ (version "4.15.2")
(source (origin
(method url-fetch)
(uri (string-append "https://archive.xfce.org/src/xfce/"
@@ -174,7 +174,7 @@ storage system.")
name "-" version ".tar.bz2"))
(sha256
(base32
- "1npjhznmnckhnylsv3l7p1zvhckhmp9d7vifs8w12kdfmrg0fjf4"))))
+ "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))
(build-system gnu-build-system)
(arguments
`(#:configure-flags
--
2.25.1
N
N
Naga Malleswari wrote on 7 Apr 2020 15:40
Re: bug#40485: Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)
aa0f4995-3613-4115-07dc-3eac1a99214b@riseup.net
Hi Danny


 (inputs `(("libsm" ,libsm)
              ("libice" ,libice)
              ;; FIXME: required by libxfce4ui-1.pc, so should be
propagated,
              ;; but will lead to a conflict with gtk+.
              ("gtk+-2" ,gtk+-2)

I understand that xfce4-embed-plugin failed after libxfce4ui is updated
because of the conflict with the inputs. What is suggested to do.  

On 07/04/20 6:26 pm, GNU bug Tracking System wrote:
Toggle quote (17 lines)
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
> guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 40485@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
--
Regards
NagaMalli
D
D
Danny Milosavljevic wrote on 7 Apr 2020 15:57
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200407155647.76622614@scratchpost.org
Build via

./pre-inst-env guix build -K libxfce4ui

Check /tmp/guix-build-xfce4-embed-plugin-1.6.0.drv-*/*/config.log for libxfce4ui
and see what the surrounding lines say.

If that doesn't help,

./pre-inst-env guix environment --pure libxfce4ui

then

pkg-config --cflags --libs libxfce4ui-1
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6MhtoACgkQ5xo1VCww
uqV1+wf/ds+ACXgSBN9GBey4cjwmK9xoC4OG3ooXfJGpbiTubYZSd7EarkYOGTPb
ZubwCLQASSL97aZfbn8vXrPIZbdZQUeRIdYPDyDEG+HdhRotCQNXn/KWbp8Er5cz
qItFVep1EBThMB5NB8znqdjGSp1boyRN4XHt94Myu0IasVViUp6vSLG8YQcbHlvh
BJDOoiAB8oFiGfgxgNxa72VPZPPBrQT5BSEHNgopFbX+KskKhluyJ9l/2bNVp/aY
Q8hRL9PymDBe9xXQYawZpCAX5+3nbp480yLYUA5ni680RQZKrEJo+wnJNJH9yeY8
swu5aZBI+q9KL7bj6xWkcwDwSQ4EqA==
=zAM4
-----END PGP SIGNATURE-----


D
D
Danny Milosavljevic wrote on 7 Apr 2020 16:01
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200407160101.0cc1d475@scratchpost.org
I meant:

Build via

./pre-inst-env guix build -K xfce4-embed-plugin

Check /tmp/guix-build-xfce4-embed-plugin-1.6.0.drv-*/*/config.log for libxfce4ui
and see what the surrounding lines say.

If that doesn't help,

./pre-inst-env guix environment --pure xfce4-embed-plugin

then

pkg-config --cflags --libs libxfce4ui-1
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6Mh50ACgkQ5xo1VCww
uqUPLgf/fEy1/6tS9ieAqmfDnNK2DTRCnGBa2Ag7X1/F6UHq3dGUF5e+8mQn39Yv
W9bFjT+zt1K8jR49Gt8cHRcy8mEgL9IdnFDLJK/aWPmYyIcQtz4iAfMYP38/TYzx
XFILi1rlFN+8KPt1IIwRvwEeqBSR4YLOvzRoJmCYdvieolbmhUomxNDJtZOTrQMV
KePQho8YgVKWUQtoGxjA081BUjUxXoD9DqwW1pkMsEXqEeEeQ6GLAq0b2CqI6yKq
fzm+povd7nvI6BhyvhiTFgW2Yby1Akk9eK7rrIOmZej8FlnEmPxpTve4OXutb+yD
xOWktgRFcg+vjQ0VMekMxTAA6vmcgA==
=I0d5
-----END PGP SIGNATURE-----


D
D
Danny Milosavljevic wrote on 7 Apr 2020 16:07
Re: [bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200407160744.15d74364@scratchpost.org
Then check the directories $PKG_CONFIG_PATH for libxfce4ui* .

In this case there's a libxfce4ui-2, which means they have changed the API
version because there was an incompatible change (previously it was
libxfce4ui-1).

So update xfce4-embed-plugin as well and hope they have adapted to the API
change (if not, we'll just get an error message again).

This will probably happen for quite a few packages, so it's gonna take some
work.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6MiTAACgkQ5xo1VCww
uqV+4Af9HIIs9ZvicxwsB60JN3LESYXJpMZBhsBqqrsgTjmRVW/3FaYacQrgKKaS
E5FEPtphEbj1t7q8bIyFN5b87nwIieC13ThJi9ryWyqeZuIuIOL0jsAbvGv41CXi
bDqaSltRNcX3lAb8J5z3opxtdKVvEhv+yICS8lvIxzEAVY5F90Fmp29aDIf6FXPq
k1IP5D4ewbUnEXtKW0K9IdC8DizEWOvFDBIreYQwDK7InPCaqpQNI9QhIZRtSzJw
rQuNmCl6LqybPc08KdPGb25jU7jwaI1VlQg01OF2+ZTvQ8k3pWKOcDeR54zVXbZB
h+kq5Kj/3aR+c13PpMpWqOx9PNbLZg==
=WIsj
-----END PGP SIGNATURE-----


N
N
Naga Malleswari wrote on 7 Apr 2020 16:17
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 40485@debbugs.gnu.org)
8d29d7f0-c494-4843-a6df-ac1704e24fdc@riseup.net
I thought of the same but

xfce4-embed-plugin version is latest in guix. (1.6.0)


I got this error:

*** The required package libxfce4ui-1 was not found on your system.
*** Please install libxfce4ui-1 (atleast version 4.8.0) or adjust
*** the PKG_CONFIG_PATH environment variable if you

On 07/04/20 7:37 pm, Danny Milosavljevic wrote:
Toggle quote (12 lines)
> Then check the directories $PKG_CONFIG_PATH for libxfce4ui* .
>
> In this case there's a libxfce4ui-2, which means they have changed the API
> version because there was an incompatible change (previously it was
> libxfce4ui-1).
>
> So update xfce4-embed-plugin as well and hope they have adapted to the API
> change (if not, we'll just get an error message again).
>
> This will probably happen for quite a few packages, so it's gonna take some
> work.

--
Regards
NagaMalli
D
D
Danny Milosavljevic wrote on 7 Apr 2020 16:23
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200407162336.5377640b@scratchpost.org

Their latest release was in 2015, so I don't think they adapted to the new libxfce4ui.

That's too bad.

There are multiple possible ways to proceed:

(1) Delete xfce4-embed-plugin, if possible (if nobody is using it and if it has
security problems anyway etc), or
(2) Keep both packages of libxfce4ui. Use the old package for
xfce4-embed-plugin and the new package for the other dependents.

Please make sure to use ./pre-inst-env guix lint xfce4-embed-plugin libxfce4ui
(with the old unchanged version) to find out whether there are known security
problems with it.

If not, I'd prefer (2).
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6MjOgACgkQ5xo1VCww
uqXFBwf+KXsBD+u41ABduvmj7kelZJA5OlcVYi20MnP56qlc5KrHB2N7I82w83Og
FvyYxze8sgu9YRGSLuXtPogMPKkOWSTbug2lzzybKm/YicPkB+BEmauGjSqTjb9A
1l/d4L5oZLUCfHMDWjSBZ/hu2pGS6Adlm3zXo7ld+bVPMZ2zOM8hzkaSamD0M1SB
Ge/Y82QTR8O6zkd9H6X+anikW/q12DqE9B0L3Kq07v9WrVozoJhsET7MrIMGD7uO
0S/5TX6QVZCjc0Ic22dAdinaD4NS/CAx86sopTN7JEiwyu1M1wOWmftVGdMaoJf6
91R9hv+dgtLcxN6g7cG32BKJjQrcBg==
=iEL6
-----END PGP SIGNATURE-----


N
N
Naga Malleswari wrote on 7 Apr 2020 21:17
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 40485@debbugs.gnu.org)
9c68509b-c720-429f-aa10-a8289ed43a64@riseup.net
Hi

On 07/04/20 7:53 pm, Danny Milosavljevic wrote:
Toggle quote (4 lines)
> (2) Keep both packages of libxfce4ui. Use the old package for
> xfce4-embed-plugin and the new package for the other dependents.


(define-public libxfce4ui/latest
� (package
��� (inherit libxfce4ui)
��� (version "4.15.2")
��� (source (origin
������������� (method url-fetch)
������������� (uri (string-append "https://archive.xfce.org/src/xfce/"
��������������������������������� name "/" (version-major+minor version) "/"
��������������������������������� name "-" version ".tar.bz2"))
������������� (sha256
�������������� (base32
��������������� "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))


I Added this and tried. always its showing 4.15.2 not found. Unable to
trace the error.

Toggle quote (2 lines)
> If not, I'd prefer (2).

--
Regards
NagaMalli
D
D
Danny Milosavljevic wrote on 7 Apr 2020 21:24
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200407212455.024ff290@scratchpost.org
Hi Naga,

On Wed, 8 Apr 2020 00:47:16 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

Toggle quote (22 lines)
> On 07/04/20 7:53 pm, Danny Milosavljevic wrote:
> > (2) Keep both packages of libxfce4ui. Use the old package for
> > xfce4-embed-plugin and the new package for the other dependents.
>
>
> (define-public libxfce4ui/latest
>   (package
>     (inherit libxfce4ui)
>     (version "4.15.2")
>     (source (origin
>               (method url-fetch)
>               (uri (string-append "https://archive.xfce.org/src/xfce/"
>                                   name "/" (version-major+minor version) "/"
>                                   name "-" version ".tar.bz2"))
>               (sha256
>                (base32
>                 "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
>
>
> I Added this and tried. always its showing 4.15.2 not found. Unable to
> trace the error.

That approach is good is principle.

But I'd do it the other way around--otherwise you have to update all libxfce4ui
references in all the other packages (which presumably can use the newer
version just fine).

So better rename the old libxfce4ui variable to libxfce4ui-1 and then
update the reference in xfce4-embed-plugin to use libxfce4ui-1, and
then introduce a new libxfce4ui variable with a similar body as your
libxfce4ui/latest had.

That means that everyone still referring to the libxfce4ui variable will get
the new version automatically.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6M04cACgkQ5xo1VCww
uqUAvwf/RSzvznMIB8UeiuYnVOSMRzXz8SilN1jeT5i/+6uWQ5vIKjXN9ArcHDoC
jKN/fIj9HEQbVIBmKOxBSWoo90W8EwDL2qZquw9FUZwrMHpsLRxGlf8/S2dM3gjq
XY9kRagRh5Gw+2sKy0P6OEK9D2ZkRC5M4ZzgUK4ib4Z1HD159iG3LCIht9NY2kTF
+CCHFIzdjtOUgqaW6mEou7RR43bVYm6nIahNN5qA4Ch/7fJOCLVE3DzUbI1BXJCi
SBRy/fuWgU4jtVMsyAAtPHyygkhg0hZ0RWfqM++Z2eiy13AxUNlnZciO83vDZJez
Tt9Pj/s7Eq0Y234tkz7ENCOdfisr9Q==
=VNYM
-----END PGP SIGNATURE-----


D
D
Danny Milosavljevic wrote on 7 Apr 2020 21:48
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200407214803.1766ef7f@scratchpost.org
Hi Naga,

On Wed, 8 Apr 2020 00:47:16 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

Toggle quote (1 lines)
> (define-public libxfce4ui/latest
[...]
Toggle quote (4 lines)
>
> I Added this and tried. always its showing 4.15.2 not found. Unable to
> trace the error.

When processing which package?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6M2PMACgkQ5xo1VCww
uqUU+Af/e6uniky1Ei9vmCX8xAs+JbZQM4jR61PLx2k/C7nLyFHxAIQZOZ2NSUvP
9UUzXEM3fqeFmjWaUQhDZDEZRPR+yn6ZuUK+XaiZbgmt7rnG3zQBlK4HqyaWNBDX
yM6MjSSlPcwNpfHOO7R0Te9z7N9FTBx2wbNPR7OQSon/tiGlSEBAQz/hguc35iZp
Pirdj74Y0i+B+K81xCmQY1Y8SfqYmanTzD2Znn6gL60TBnXdLYhJCHSQcJ/gLCPD
UYl1TDJv2vXFDYsLTDLgbikA2COQD9cjMGuyYCE08YyxbB+gOsIbrxiQKpRvpKpH
LlXOfX8pUKuLOD8DuEWPw+HE+T43qw==
=gOSS
-----END PGP SIGNATURE-----


N
N
Naga Malleswari wrote on 8 Apr 2020 21:43
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 40485@debbugs.gnu.org)
25e2a647-635c-f8f6-a962-8701fd69e3ce@riseup.net
I am getting weird outputs.

I tried building two versions of help2man/latest and libuv/latest which
were build the same way and they worked perfectly fine.


I tried these



CASE1:

./pre-inst-env guix build libxfce4ui is building 4.14.1

./pre-inst-env guix build libxfce4ui-1 error: libxfce4ui-1: unknown package

./pre-inst-env guix build libxfce4ui@4.15.2 error: libxfce4ui-4.15.2: unknown package


CasE 2:
./pre-inst-env guix build libxfce4ui is building 4.14.1

./pre-inst-env guix build libxfce4ui@4.15.2 resulted error: libxfce4ui-4.15.2: unknown package


Am i missing something here........... orocess which worked fine for
help2man and libuv is not working for this.



On 08/04/20 1:18 am, Danny Milosavljevic wrote:
Toggle quote (11 lines)
> Hi Naga,
>
> On Wed, 8 Apr 2020 00:47:16 +0530
> Naga Malleswari <nagamalli@riseup.net> wrote:
>
>> (define-public libxfce4ui/latest
> [...]
>> I Added this and tried. always its showing 4.15.2 not found. Unable to
>> trace the error.
> When processing which package?

THis one

./pre-inst-env guix build xfce4ui

--
Regards
NagaMalli
D
D
Danny Milosavljevic wrote on 9 Apr 2020 00:19
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200409001936.16098b47@scratchpost.org
Hi Naga,

On Thu, 9 Apr 2020 01:13:34 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

Toggle quote (2 lines)
Please, for archival purposes, post source code in the mailing list. Pastebin
content will eventually vanish--and we do want to have some kind of public
record.

I'm gonna paste it here:

CASE 1:

(define-public libxfce4ui-1
(package
(name "libxfce4ui")
(version "4.14.1")

(define-public libxfce4ui/latest
(package
(inherit libxfce4ui-1)
(version "4.15.2")

CASE 2:
(define-public libxfce4ui
(package
(name "libxfce4ui")
(version "4.14.1")


(define-public libxfce4ui/latest
(package
(inherit libxfce4ui)
(version "4.15.2")
(source (origin
(method url-fetch)
name "/" (version-major+minor version) "/"
name "-" version ".tar.bz2"))
(sha256
(base32
"0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))

Toggle quote (4 lines)
> CASE1:
>
> ./pre-inst-env guix build libxfce4ui is building 4.14.1

I would have expected 4.15.2--are you sure that you overwrote the field SOURCE ?

Toggle quote (2 lines)
> ./pre-inst-env guix build libxfce4ui-1 error: libxfce4ui-1: unknown package

"libxfce4ui-1" is not a package's name but a variable's name. That won't work[1].

Toggle quote (2 lines)
> ./pre-inst-env guix build libxfce4ui@4.15.2 error: libxfce4ui-4.15.2: unknown package

Why is there a dash in the error message?

Should work just fine with "@".

Toggle quote (3 lines)
> CasE 2:
> ./pre-inst-env guix build libxfce4ui is building 4.14.1

Should build 4.15.2.

Toggle quote (2 lines)
> ./pre-inst-env guix build libxfce4ui@4.15.2 resulted error: libxfce4ui-4.15.2: unknown package

Again the dash? Why?

it works for me:

Toggle diff (113 lines)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0628b03207..ee2bba5ca1 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -163,7 +163,9 @@ Xfce Desktop Environment.")
storage system.")
(license lgpl2.0+)))
-(define-public libxfce4ui
+;; case 1
+
+(define-public libxfce4ui-1
(package
(name "libxfce4ui")
(version "4.14.1")
@@ -201,6 +203,20 @@ storage system.")
to share commonly used Xfce widgets among the Xfce applications.")
(license lgpl2.0+)))
+(define-public libxfce4ui
+ (package
+ (inherit libxfce4ui-1)
+ (name "libxfce4ui") ; not necessary but I like it for no reason
+ (version "4.15.2")
+ (source (origin ; necessary block!!
+ (method url-fetch)
+ (uri (string-append "https://archive.xfce.org/src/xfce/"
+ name "/" (version-major+minor version) "/"
+ name "-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
+
(define-public exo
(package
(name "exo")

$ ./pre-inst-env guix build libxfce4ui@4.14.1
/gnu/store/fk1ziblzyslg9z7gpm9j410jfgwbilsr-libxfce4ui-4.14.1

$ ./pre-inst-env guix build libxfce4ui@4.15.2
/gnu/store/cy5wyx1zrq9ahp6zl0wjpv0nd0a6hpkb-libxfce4ui-4.15.2

The argument to "guix build" is always[1] the field called NAME (and optionally
also the field called VERSION, after an "@" separator) of the package record.
The variable's name (define-public xxx) doesn't matter at this point[1].

Because the sha256 sum would have to change (among other things), make sure to
specify the field SOURCE also in the other package--otherwise you'll get the
old source.

Another reason to specify SOURCE in the other package follows:

Guile, the programming language used for Guix packages, usually uses
lexical scope.
Even the facility we built in order to make records (like <PACKAGE>) also uses
lexical scope.

That means a reference will bind to the identifier that is closest in the source
code (before it). Once the identifier is bound, that's it--it's not going to
change binding ever again.

That means if you do this (silly example to prove a point--but you can actually
run that for real!):

(define-public a
(package
(name "a")
(version name)
;; Please ignore the following line for understanding for now.
(source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))

(define-public b
(package
(inherit a)
(name "b")))

(write (package-name b))
(newline)
(write (package-version b))
(newline)

package "b" would have: (name "b") but (version "a").
Version is "a". That's not a typo.

However, with

(define-public a
(package
(name "a")
(version name) ; here, NAME is a reference, which will be bound to the NAME one line above
;; Please ignore the following line for understanding for now.
(source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))

(define-public b
(package
(inherit a)
(name "b")
(version name)))

(write (package-name b))
(newline)
(write (package-version b))
(newline)

package "b" would have: (name "b") and (version "b").

Similarly for all other references, most notably the references to NAME and VERSION that
usually occur in a SOURCE field.

[1] Except for "guix build -e ..." (don't use it).
Usually, user-facing tools only care about the contents of the <PACKAGE> record.
Guile variables are invisible to the end user of the "guix" tool.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6OTfgACgkQ5xo1VCww
uqUG7Af5AeJYJ98F3ZY3z208gfbdxw4FVrGyLZGEMYRR6Q0wBHzLTi1thjmfuQ4x
jcwrc8v11SQ0GDqVFm+wOe5cjsdLaBXoPwUgzavv2ycmde5xbSFNgWTsnu3zTr25
msyttpXnKRFZAiynqkd39/Pp7WdGG3O5TOi//qG+93voCnDtNAGME6k/t2gcRR4x
Z/GbPpjgfMMBpkhBltMvjTSJ6m9+i7pFMWTqMvzTE4sz28pjQlro+79ZkHioT+kc
mVRAdFNk1e2VKRCAzqMtn356RX8wT4VwXZO7DnX5mo+5fq2A3CBVPJJ/FR3V6DZa
qYkoOf/FMjH7jxqvu/sbTJuY27xLzg==
=yAoQ
-----END PGP SIGNATURE-----


D
D
Danny Milosavljevic wrote on 9 Apr 2020 00:31
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200409003113.4a0a1d25@scratchpost.org
Correction:

That means a reference will bind to the value of the variable with that name
that is closest in the source code (before it).

Once the reference is bound, that's it--it's not going to change binding ever
again.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6OULEACgkQ5xo1VCww
uqXblQf9G2m3FEUuLHKYebLbALFzzy3KL8GmgAunw6MdY1BbvrlV79bskW/MAY/W
5FoZUD+jV93WH+vIIohkLlGwbGWN/dW/92sfp5vBdhKMejcZVlxNhGycVUTMUSgE
2QNDDa14jDQjSuJS6JWUkZb19Sr23I8AwWgi8Q39pieLSMgXbEibZT5pn05weeWe
iQNZqs0Fw1mizbpDJi2/5jFAyPw9uGBtpAtH9/Ln6yyOeY6Ypl4ZGJun1hH7fFsA
HqycMjJJ+bs70d5PuhJa3HEVbwf/JL4z+vMnBS9ChmQVB0yvKFgfHKzRjL0+ABIo
jKoTrq7FqNU8GggZrwigEONi7Ps77Q==
=gE0S
-----END PGP SIGNATURE-----


D
D
Danny Milosavljevic wrote on 9 Apr 2020 00:44
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200409004315.20914ebd@scratchpost.org
Or maybe a simpler, but less applicable, example:

(let ((x 2))
(let ((y x))
(let ((x 3))
y)))

=> 2

NOT 3.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6OU7cACgkQ5xo1VCww
uqXYnAf8DOO0yoLVXAd/PJYVhvy8VsClroZrI60CDx7W3ThxAwfDy00ZgdOF4umX
lspPpPuyloio6WtUG/N0m3XourK9XG5OitHfWAogBRmMvLL0Sxq7T6Hagip62SQb
Pg/gVVvAPfeRDq2rHwowqraaf2jZeU7H4Ca2nD2GUyg10oW3bJa2u4dGFdH/12vl
sSl4gLCIeDI6fHiU6NYK8Akvs2yyAw5Rb7aRLsAe373xV6+oO572n7BsHivREis3
85+zevuA9PfEd9SUPTwaORRIQA3Zwu77idXfvdVsOWzdEI1dqHAfYtj0fLoHcrrz
87mCEKLuLhsJ5qxj5x+HrLrKLad2OA==
=Edki
-----END PGP SIGNATURE-----


N
N
Naga Malleswari wrote on 9 Apr 2020 22:42
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 40485@debbugs.gnu.org)
39267250-afcc-1e79-db07-cd47756d0967@riseup.net
Hi

Finally It worked......Submitting the patch for review.

Now xfce4-embed-plugin is building fine after i modified the input to
old version of libxfce4ui.

I referred the older commit message from help2man from the log. I am
still not sure about it.

Its the same code i have sent you. I used the origin block. And (name��
x) was the only difference.

On 09/04/20 3:49 am, Danny Milosavljevic wrote:
Toggle quote (4 lines)
> + (inherit libxfce4ui-1)
> + (name "libxfce4ui") ; not necessary but I like it for no reason
> + (version "4.15.2")
> + (source (origin ; necessary block!!
I used the same. I added name block. It worked !!!
Toggle quote (6 lines)
> $ ./pre-inst-env guix build libxfce4ui@4.14.1
> /gnu/store/fk1ziblzyslg9z7gpm9j410jfgwbilsr-libxfce4ui-4.14.1
>
> $ ./pre-inst-env guix build libxfce4ui@4.15.2
> /gnu/store/cy5wyx1zrq9ahp6zl0wjpv0nd0a6hpkb-libxfce4ui-4.15.2

It worked the same.

1) If name block is removed in latest.�� Its building the older version.
Why??

2)� /latest is also removed from variable. Would i make a difference?


Toggle quote (3 lines)
> ewline)
> (write (package-version b))
> (newline)
Thanks for such a long explanation. It took a bit of time for me.
Toggle quote (4 lines)
> package "b" would have: (name "b") and (version "b").
>
> Guile variables are invisible to the end user of the "guix" tool.

--
Regards
NagaMalli
From ce3d3d40a09631de05fd45eaec964d5473a4ca73 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Fri, 10 Apr 2020 01:59:43 +0530
Subject: [PATCH] gnu: libxfce4ui: Add 4.15.2.

* gnu/packages/xfce.scm (libxfce4ui): New variable.
---
gnu/packages/xfce.scm | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)

Toggle diff (45 lines)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 0628b03207..9556d5aa39 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -163,7 +163,7 @@ Xfce Desktop Environment.")
storage system.")
(license lgpl2.0+)))
-(define-public libxfce4ui
+(define-public libxfce4ui-1
(package
(name "libxfce4ui")
(version "4.14.1")
@@ -201,6 +201,20 @@ storage system.")
to share commonly used Xfce widgets among the Xfce applications.")
(license lgpl2.0+)))
+(define-public libxfce4ui
+ (package
+ (inherit libxfce4ui-1)
+ (name "libxfce4ui")
+ (version "4.15.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://archive.xfce.org/src/xfce/"
+ name "/" (version-major+minor version) "/"
+ name "-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
+
(define-public exo
(package
(name "exo")
@@ -1449,7 +1463,7 @@ performance (bytes transferred per second).")
`(("intltool" ,intltool)
("pkg-config" ,pkg-config)))
(inputs
- `(("libxfce4ui" ,libxfce4ui)
+ `(("libxfce4ui" ,libxfce4ui-1)
("xfce4-panel" ,xfce4-panel)
("gtk+-2" ,gtk+-2)))
(home-page
--
2.25.1
D
D
Danny Milosavljevic wrote on 10 Apr 2020 00:11
(address . 40485@debbugs.gnu.org)
20200410001157.45e1a2e7@scratchpost.org
Hi,

On Fri, 10 Apr 2020 02:12:42 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

Toggle quote (11 lines)
>On 09/04/20 3:49 am, Danny Milosavljevic wrote:
>> + (inherit libxfce4ui-1)
>> + (name "libxfce4ui") ; not necessary but I like it for no reason
>> + (version "4.15.2")
>> + (source (origin ; necessary block!!

>I used the same. I added name block. It worked !!!

>1) If name block is removed in the latest [libxfce4ui package], it's building the
>older version. Why??

If I remove (name "libxfce4ui") from the latest libxfce4ui package, and then
invoke

make -j5 SUBDIRS=

then I get an error

error: name: unbound variable.

from the compilation of gnu/packages/xfce.scm.
So that's why the latest libxfce4ui package would never be loaded into guix
(it's broken) and instead the other one would be used.

I'm not sure why that is the case. It's certainly different to most other
programming languages. @Ludo?

@Ludo: Reduced test case:

,use (guix packages)
(define-public a
(package
(name "a")
(version name)
(source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))

(define-public b
(package
(inherit a)
(version name))) ; error message here

Error message:

;;; <stdin>:9:4: warning: possibly unbound variable `name'
<unnamed port>:9:4: In procedure module-lookup: Unbound variable: name

What's happening here? I would have expected NAME to be available from the
descendant record and accessing the ancestor record... is it not available
on purpose?

Toggle quote (2 lines)
>2)  /latest is also removed from variable. Would it make a difference?

No. It's just part of a variable's name (the slash has no special meaning
either).
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6Pna0ACgkQ5xo1VCww
uqVHtgf9F4GM+fFtspRTRhjCuk88Js0WSUdYD39qwRDAZU24Rx5xNCzoP6FJc6ba
QCZRn8rQyYPCM8vdMCt7rvaC98L/RVS+GZbldhz9HzXc94ptYP6vm+oTpmLrSl8p
E8q3FcmN1yXohyzb0SlG2me4iS4QvF2hA5PpLuRtMXNBZbVdsTJ6kzdg3Qwrj/bY
4MthYt0Je1U3HAJ6gnFBqV4uN85yG6No2QBa7/xzZgS53dcKBE91CMPkhT5LHhVE
qrbdrDxZknMCYekTlGFesd5MwsjNFFNrYuICfoNJ5jwQ1YwsLxDhIyM4KHyGtYFu
cSntmdrDkObJ8daQr3RNo44+2JeVSg==
=Ml2v
-----END PGP SIGNATURE-----


N
N
Naga Malleswari wrote on 12 Apr 2020 23:09
(address . 40485@debbugs.gnu.org)
83cde561-7ed4-8d04-51ca-19a824fb3e8a@riseup.net
Hi Danny

Is there a suggestion how to work on this.


Meanwhile i submitted another patch, please review



On 10/04/20 3:41 am, Danny Milosavljevic wrote:
Toggle quote (56 lines)
> Hi,
>
> On Fri, 10 Apr 2020 02:12:42 +0530
> Naga Malleswari <nagamalli@riseup.net> wrote:
>
>> On 09/04/20 3:49 am, Danny Milosavljevic wrote:
>>> + (inherit libxfce4ui-1)
>>> + (name "libxfce4ui") ; not necessary but I like it for no reason
>>> + (version "4.15.2")
>>> + (source (origin ; necessary block!!
>> I used the same. I added name block. It worked !!!
>> 1) If name block is removed in the latest [libxfce4ui package], it's building the
>> older version. Why??
> If I remove (name "libxfce4ui") from the latest libxfce4ui package, and then
> invoke
>
> make -j5 SUBDIRS=
>
> then I get an error
>
> error: name: unbound variable.
>
> from the compilation of gnu/packages/xfce.scm.
> So that's why the latest libxfce4ui package would never be loaded into guix
> (it's broken) and instead the other one would be used.
>
> I'm not sure why that is the case. It's certainly different to most other
> programming languages. @Ludo?
>
> @Ludo: Reduced test case:
>
> ,use (guix packages)
> (define-public a
> (package
> (name "a")
> (version name)
> (source #f) (build-system #f) (synopsis #f) (description #f) (license #f) (home-page #f)))
>
> (define-public b
> (package
> (inherit a)
> (version name))) ; error message here
>
> Error message:
>
> ;;; <stdin>:9:4: warning: possibly unbound variable `name'
> <unnamed port>:9:4: In procedure module-lookup: Unbound variable: name
>
> What's happening here? I would have expected NAME to be available from the
> descendant record and accessing the ancestor record... is it not available
> on purpose?
>
>> 2)� /latest is also removed from variable. Would it make a difference?
> No. It's just part of a variable's name (the slash has no special meaning
> either).

--
Regards
NagaMalli
D
D
Danny Milosavljevic wrote on 13 Apr 2020 21:27
(name . Naga Malleswari)(address . nagamalli@riseup.net)(address . 40485@debbugs.gnu.org)
20200413212704.4cafb1f5@scratchpost.org
Hi Naga,

when trying to build the dependents, I get a build failure in
xfce4-equake-plugin.

Please fix xfce4-equake-plugin to also use libxfce4ui-1.
Same for xfce4-kbdleds-plugin.
Same for xfce4-mailwatch-plugin.

Otherwise OK.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6UvRUACgkQ5xo1VCww
uqVziAf+Ke8aM3uoxAatxyV+kyqW2lb/aM1TZlxC7HLghH8AEgCkTRNlwAF143lM
pjcEb8mvAoGqc1VpDu6gYI2yHWPU6EyVGG1z2QBxfQ+vgMbb/SocTJy2OmHKT+YP
slKukPoDJMK9tYOxbDcUqMHteFyZRPxhIA3g0OzyftU0BH03pDxRZa3YFvAXznnJ
1dGr4Ege5cqLGbnP7PFGR3xKDemZ81jnlXPdPfsGy8ud7jRwM3J12c7moRComG+f
D7uVwFR8KiOdLR9kuZuHZmFRZzfP0TqGyjGManZre+Xtzlyk/7FAytfroCWazrDb
xHf2KDYABjgLnfPex9nkZ8SS8sAu9g==
=5uZc
-----END PGP SIGNATURE-----


N
N
Naga Malleswari wrote on 14 Apr 2020 17:43
[PATCH v3] : [bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 40485@debbugs.gnu.org)
f81b3d55-daec-1211-3ff2-d134adad4a68@riseup.net
Hi


Submitting v3 of patch

On 14/04/20 12:57 am, Danny Milosavljevic wrote:
Toggle quote (4 lines)
> Hi Naga,
>
> when trying to build the dependents, I get a build failure in
> xfce4-equake-plugin.
My mistake i checked only embed plugin and formatted the patch.
Toggle quote (4 lines)
>
> Please fix xfce4-equake-plugin to also use libxfce4ui-1.
> Same for xfce4-kbdleds-plugin.
> Same for xfce4-mailwatch-plugin.
Yes i build without modifications and after modifying each to validate
and i made necessary changes.
Toggle quote (3 lines)
>
> Otherwise OK.

--
Regards
NagaMalli
From c16724c279309fd6fa58a927bd59862386f8a432 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Tue, 14 Apr 2020 21:10:07 +0530
Subject: [PATCH] gnu: libxfce4ui: Add 4.15.2.

* gnu/packages/xfce.scm (libxfce4ui): New variable.
---
gnu/packages/xfce.scm | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)

Toggle diff (72 lines)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index b231761d43..f99aedcb88 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -163,7 +163,7 @@ Xfce Desktop Environment.")
storage system.")
(license lgpl2.0+)))
-(define-public libxfce4ui
+(define-public libxfce4ui-1
(package
(name "libxfce4ui")
(version "4.14.1")
@@ -201,6 +201,20 @@ storage system.")
to share commonly used Xfce widgets among the Xfce applications.")
(license lgpl2.0+)))
+(define-public libxfce4ui
+ (package
+ (inherit libxfce4ui-1)
+ (name "libxfce4ui")
+ (version "4.15.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://archive.xfce.org/src/xfce/"
+ name "/" (version-major+minor version) "/"
+ name "-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "0069da27chxrgylbzcm9vhzpfnvkii2n2dz8g6jlwfcr82arkayb"))))))
+
(define-public exo
(package
(name "exo")
@@ -1313,7 +1327,7 @@ watch your every step.")
("pkg-config" ,pkg-config)))
(inputs
`(("gtk+-2" ,gtk+-2)
- ("libxfce4ui" ,libxfce4ui)
+ ("libxfce4ui" ,libxfce4ui-1)
("xfce4-panel" ,xfce4-panel)))
(home-page
"https://goodies.xfce.org/projects/panel-plugins/xfce4-equake-plugin")
@@ -1450,7 +1464,7 @@ performance (bytes transferred per second).")
`(("intltool" ,intltool)
("pkg-config" ,pkg-config)))
(inputs
- `(("libxfce4ui" ,libxfce4ui)
+ `(("libxfce4ui" ,libxfce4ui-1)
("xfce4-panel" ,xfce4-panel)
("gtk+-2" ,gtk+-2)))
(home-page
@@ -1547,7 +1561,7 @@ button and a personalized tooltip.")
("pkg-config" ,pkg-config)))
(inputs
`(("gtk+-2" ,gtk+-2)
- ("libxfce4ui" ,libxfce4ui)
+ ("libxfce4ui" ,libxfce4ui-1)
("xfce4-panel" ,xfce4-panel)))
(home-page
"https://goodies.xfce.org/projects/panel-plugins/xfce4-kbdleds-plugin")
@@ -1575,7 +1589,7 @@ Caps, Scroll and Num Lock in Xfce panel.")
("pkg-config" ,pkg-config)))
(inputs
`(("gtk+-2" ,gtk+-2)
- ("libxfce4ui" ,libxfce4ui)
+ ("libxfce4ui" ,libxfce4ui-1)
("exo" ,exo)
("xfce4-panel" ,xfce4-panel)))
(home-page
--
2.25.1
T
T
Tobias Geerinckx-Rice wrote on 14 Apr 2020 19:07
Re: [bug#40485] Acknowledgement (gnu: Update libxfce4ui to 4.15.2.)
87d08am1wq.fsf@nckx
Naga, Danny,

What's the reason for adding an unstable version? We don't
usually do that in Guix.

Is this required for some other package?

Sorry for not bringing this up sooner; I'm still slogging through
the backlog in a most random way.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6V7dUACgkQ2Imw8BjF
STxg2BAAmbE8z13L51pbUAq4HUIOuWr+7w6f643DoaMwV2U5SRkzkux741kbVRBg
H4KvNh655Ho0VQLkdT+qFWqCp9pxoU/NpJJE0jvPZMH+TDFWnzC1QWMtkMJgVTco
D188ILYs4ipoHY6WGJqSHXV0Vg1FdGMxbXqsPVBUSfcPyNLTXPrsajVBsHzbwQrb
ev0DDPU9YBT069cg6gTGPLZ3o3hrTmEo/l28HfwvkjARit9tw9S792N5GEafEgtt
R6bxQZuRIgb3OZOthm3WkXV5oBRswhpJgoy/lx8gqVewdyGH835BVPjuOUQFjMs2
SgmQZbSdxsMnMda+KlvbiaLc3NDcEeV0yQZpMPfyWB0+niM1s8XxVHRmyYerIITU
/q1mywH+8DT5paJzBqtQww2Itqeoq9036JYal4MoE+LWbhWsdweDADFGRieIuTO4
LrTBKbSalzQSKAa1CNIc7QNrvTXzKZ6VDhl62gxXafh3O7kY09ZN4HOOusvwy01F
ly58y+D0gsypQMiv52Js8lPxxuu2j8udiV59MOHnmfB15c2HWIZPhajqwlMHeUqy
RSvCIQE1w+BFY7rCyHYLFvlE0uU/aEpyOTlg4As5SdyBHa60sfSo1ylsj79QHRgs
R4w8VcpkN0vJ7Msx8iTy7z2w7KcvervFfw0K+6vpO8bhlQ6qK1s=
=ilGc
-----END PGP SIGNATURE-----

D
D
Danny Milosavljevic wrote on 19 Apr 2020 17:59
(address . 40485-close@debbugs.gnu.org)
20200419175928.36b0c28a@scratchpost.org
Hi T G-R,
Hi Naga,

whoops, I've forgotten that that would be an unstable version.

Thanks for telling us.

Let's not merge this update then.

I've already merged the update of libxfce4util to 4.15.0--should we revert that?

Naga, please if possible let's only add stable releases to Guix.
If they are experimental, let's not add them to Guix if it can be helped.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6cdWAACgkQ5xo1VCww
uqVoyAf/Sx+vdQ9LQRXrNswwxVF9S/W8wVEHYOGf7kWituBVeuKN+H/sCCVnZzVY
N15BkCAlUhgg8P3mpGI3DW/8Slv6XPUF6Vx5YDFKHuJGZ6IWs/YaeD+dUfzXf3of
JVfHT/kJ3dreYIxYwrLe4wKvSUnbR6UrGJgwelLQk0v5rECnSiguwRQd33J7Ad1T
ZS8mQ5hKdZEExsQs3Ltp/hvJZd9a3LAiQNj58asZ6SL+YuFK8DuNT36mc1yzd3rL
ObsVo3RG4iqcFsq1Xp0gqW6khuOss6X3AsHMi46s6fykwtc6dqg1GXymVJCIjZtu
Zf+yZKseeJjl+fUi7tkpH8y9qIdW6Q==
=rVd1
-----END PGP SIGNATURE-----


?