[PATCH 0/2] gnu: radio: Simplify instalation instructions

DoneSubmitted by Brice Waegeneire.
Details
2 participants
  • Brice Waegeneire
  • Guillaume Le Vaillant
Owner
unassigned
Severity
normal
B
B
Brice Waegeneire wrote on 13 May 10:50 +0200
(address . guix-patches@gnu.org)
20200513085050.3665-1-brice@waegenei.re
Brice Waegeneire (2): gnu: rtl-sdr: Simplify installation instructions. gnu: hackrf: Simplify installation instructions.
gnu/packages/radio.scm | 31 ++++++------------------------- 1 file changed, 6 insertions(+), 25 deletions(-)
-- 2.26.2
B
B
Brice Waegeneire wrote on 13 May 11:00 +0200
[PATCH 1/2] gnu: rtl-sdr: Simplify installation instructions.
(address . guix-patches@gnu.org)
20200513090054.8313-1-brice@waegenei.re
* gnu/packages/radio.scm (rtl-sdr)[description]: Replace'modify-services' snippet with 'udev-rules-service'.--- gnu/packages/radio.scm | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)
Toggle diff (26 lines)diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scmindex 41105fb8c5..1e50be1bcc 100644--- a/gnu/packages/radio.scm+++ b/gnu/packages/radio.scm@@ -152,17 +152,8 @@ system configuration: (kernel-arguments '(\"modprobe.blacklist=dvb_usb_rtl28xxu\")) @end lisp -To install the rtl-sdr udev rules, you must add this package in the-configuration of the udev system service. E.g.:--@lisp-(services- (modify-services %desktop-services- (udev-service-type config =>- (udev-configuration (inherit config)- (rules (cons rtl-sdr- (udev-configuration-rules config)))))))-@end lisp")+To install the rtl-sdr udev rules, you must extend 'udev-service-type' with+this package. E.g.: @code{(udev-rules-service 'rtl-sdr rtl-sdr)}") (license license:gpl2+))) (define-public chirp-- 2.26.2
B
B
Brice Waegeneire wrote on 13 May 11:00 +0200
[PATCH 2/2] gnu: hackrf: Simplify installation instructions.
(address . guix-patches@gnu.org)
20200513090054.8313-2-brice@waegenei.re
* gnu/packages/radio.scm (hackrf)[description]: Replace'modify-services' snippet with 'udev-rules-service'.--- gnu/packages/radio.scm | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-)
Toggle diff (31 lines)diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scmindex 1e50be1bcc..6a919548f0 100644--- a/gnu/packages/radio.scm+++ b/gnu/packages/radio.scm@@ -741,20 +741,10 @@ for correctness.") (synopsis "User-space library and utilities for HackRF SDR") (description "Command line utilities and a C library for controlling the HackRF-Software Defined Radio (SDR) over USB. Installing this package installs-the userspace hackrf utilities and C library. To install the hackrf-udev rules, you must add this package as a system service via-modify-services. E.g.:--@lisp-(services- (modify-services- %desktop-services- (udev-service-type config =>- (udev-configuration (inherit config)- (rules (cons hackrf- (udev-configuration-rules config)))))))-@end lisp")+Software Defined Radio (SDR) over USB. Installing this package installs the+userspace hackrf utilities and C library. To install the hackrf udev rules,+you must extend 'udev-service-type' with this package. E.g.:+@code{(udev-rules-service 'hackrf hackrf #:groups '(\"dialout\"))}.") (license license:gpl2)))) (define-public hamlib-- 2.26.2
G
G
Guillaume Le Vaillant wrote on 14 May 11:02 +0200
Re: [bug#41228] [PATCH 0/2] gnu: radio: Simplify instalation instructions
(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 41228@debbugs.gnu.org)
87tv0ihosz.fsf@yamatai
Brice Waegeneire <brice@waegenei.re> skribis:
Toggle quote (7 lines)> Brice Waegeneire (2):> gnu: rtl-sdr: Simplify installation instructions.> gnu: hackrf: Simplify installation instructions.>> gnu/packages/radio.scm | 31 ++++++-------------------------> 1 file changed, 6 insertions(+), 25 deletions(-)
It looks good to me.
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQQkUwKxurH4Z/3KlryPP4Yfgut6mgUCXr0JLAAKCRCPP4Yfgut6mtoaAQCdFtbNYMo4/gNLJyFiPvaeihLJuE43iFIxNIIeRbSrywEAj10uvAY6if9UFhz10r9dk6s5e+QNd7NiED5qc+kVPQQ==Ttj3-----END PGP SIGNATURE-----
B
B
Brice Waegeneire wrote on 14 May 15:56 +0200
(name . Guillaume Le Vaillant)(address . glv@posteo.net)(address . 41228-done@debbugs.gnu.org)
5bc8141f31c9dcd9022a18fa64d22e30@waegenei.re
On 2020-05-14 09:02, Guillaume Le Vaillant wrote:
Toggle quote (11 lines)> Brice Waegeneire <brice@waegenei.re> skribis:> >> Brice Waegeneire (2):>> gnu: rtl-sdr: Simplify installation instructions.>> gnu: hackrf: Simplify installation instructions.>> >> gnu/packages/radio.scm | 31 ++++++------------------------->> 1 file changed, 6 insertions(+), 25 deletions(-)> > It looks good to me.
Thanks for the review Guillaume.
Pushed as 32290b2c35 and aee7d000f8.
Closed
?