[PATCH] gnu: boost: Add which to native-inputs.

DoneSubmitted by Vincent Legoll.
Details
2 participants
  • Tobias Geerinckx-Rice
  • Vincent Legoll
Owner
unassigned
Severity
normal
V
V
Vincent Legoll wrote on 14 May 12:13 +0200
(address . guix-patches@gnu.org)(name . Vincent Legoll)(address . vincent.legoll@gmail.com)
20200514101353.27963-1-vincent.legoll@gmail.com
To fix:./bootstrap.sh: line 28: which: command not found
* gnu/packages/boost.scm (boost)[native-inputs]: Add which.--- gnu/packages/boost.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Toggle diff (24 lines)diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scmindex 2f2ca289ab..f6f442c5bf 100644--- a/gnu/packages/boost.scm+++ b/gnu/packages/boost.scm@@ -38,6 +38,7 @@ #:use-module (guix build-system gnu) #:use-module (guix build-system trivial) #:use-module (gnu packages)+ #:use-module (gnu packages base) #:use-module (gnu packages compression) #:use-module (gnu packages icu4c) #:use-module (gnu packages perl)@@ -82,7 +83,8 @@ ,@(if (%current-target-system) '() `(("python" ,python-wrapper)))- ("tcsh" ,tcsh)))+ ("tcsh" ,tcsh)+ ("which" ,which))) (arguments `(#:imported-modules ((guix build python-build-system) ,@%gnu-build-system-modules)-- 2.26.2
T
T
Tobias Geerinckx-Rice wrote on 14 May 13:23 +0200
(name . Vincent Legoll)(address . vincent.legoll@gmail.com)(address . 41254@debbugs.gnu.org)
87blmqep4r.fsf@nckx
Vincent,
Thanks for the patch!
Vincent Legoll 写道:
Toggle quote (3 lines)> To fix:> ./bootstrap.sh: line 28: which: command not found
I'm not convinced that increasing the number of inputs to silence (harmless) warnings in the build logs is a way to go.
Is there another reason to add ‘which’? The resulting boost appears identical to one built without it.
Kind regards,
T G-R
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXr0qRQAKCRANsP+IT1VteZFuAP9d1L4yX2DT1Tnk2c8GRmZMTgWDsqTLthZVk9LVvgvW5QD/azcmTnQPbIwh9pAW/0u6SuGjPbDRBjDc6gC0xbZDKQ4==qpq7-----END PGP SIGNATURE-----
V
V
Vincent Legoll wrote on 14 May 13:37 +0200
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 41254@debbugs.gnu.org)
a5710ceb-9a0b-572d-9902-5be013692ab2@gmail.com
On 14/05/2020 13:23, Tobias Geerinckx-Rice wrote:
Toggle quote (3 lines)> I'm not convinced that increasing the number of inputs to silence > (harmless) warnings in the build logs is a way to go.
It did not look harmless to me...
> The resulting boost appears identical to one built without it.
...but it looks like I'm wrong.
Toggle quote (2 lines)> Is there another reason to add ‘which’?
Nope, feel free to close the issue
-- Vincent Legoll
T
T
Tobias Geerinckx-Rice wrote on 14 May 14:13 +0200
(name . Vincent Legoll)(address . vincent.legoll@gmail.com)(address . 41254-done@debbugs.gnu.org)
87tv0id8a3.fsf@nckx
Vincent Legoll 写道:
Toggle quote (7 lines)> On 14/05/2020 13:23, Tobias Geerinckx-Rice wrote:>> I'm not convinced that increasing the number of inputs to >> silence>> (harmless) warnings in the build logs is a way to go.>> It did not look harmless to me...
I understand. It's actually quite common (as these things go) but tends to go unnoticed exactly because it's harmless. Once you notice it you see it everywhere.
Toggle quote (2 lines)> Nope, feel free to close the issue
Done!
Kind regards,
T G-R
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXr011AAKCRANsP+IT1VteUZVAQCk55RXoG6BCKHtz9cpdUgQ6MtgbK82coaVV88HiLKxDgD/YlHf3KWyAYpPPgz1ZhpcJlphVeGjUcac9KC+8SWHnwI==J0xy-----END PGP SIGNATURE-----
Closed
?