Hi Marcin,
Marcin Karpezo <sirmacik@wioo.waw.pl> writes:
Toggle quote (2 lines)
> * gnu/packages/backup.scm (dump): New variable.
Thanks! Can't believe we've gone without this for so long.
[...]
Toggle quote (10 lines)
> +(define-public dump> + (package> + (name "dump")> + (version "0.4b46")> + (source> + (origin> + (method url-fetch)> + (uri (string-append "https://downloads.sourceforge.net/project/" name "/"> + name "/" version "/" name "-" version ".tar.gz"))
Please use "mirror://sourceforge" here.
Toggle quote (17 lines)
> + (sha256> + (base32> + "15rg5y15ak0ppqlhcih78layvg7cwp6hc16p3c58xs8svlkxjqc0"))))> + (build-system gnu-build-system)> + (arguments> + `(#:configure-flags> + `("--sysconfdir=/etc"> + "--disable-readline"> + "--disable-rmt")))> + (native-inputs> + `(("pkg-config" ,pkg-config)> + ("autoconf" ,autoconf)> + ("zlib" ,zlib)> + ("util-linux" ,util-linux "lib")> + ("e2fsprogs" ,e2fsprogs)> + ("automake" ,automake)))
I ran 'guix size dump' and noticed that the package keeps references toutil-linux, zlib and e2fsprogs. Probably they should be "inputs"instead. Can you confirm and send an updated patch?
Otherwise looks great, thanks!