lm-sensors: pwmconfig is broken

  • Done
  • quality assurance status badge
Details
2 participants
  • Nicolò Balzarotti
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Nicolò Balzarotti
Severity
normal
N
N
Nicolò Balzarotti wrote on 17 May 2020 14:46
(address . guix-patches@gnu.org)
87a726hgpq.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me
Hello guix!

The current version of lm-sensors adjust grep path in the pwmconfig
script, replacing grep->/gnu/store/.../grep. However, the script is
using egrep, leading to the non-existant e/gnu/store/.../grep path.
The attached patch fixes is actually replacing egrep->/gnu/store/../egrep

Thanks!
From 1a0395630547868385312198659d5fda39845cbe Mon Sep 17 00:00:00 2001
From: nixo <nicolo@nixo.xyz>
Date: Sun, 17 May 2020 14:39:17 +0200
Subject: [PATCH] gnu: lm-sensors: Use correct egrep path.

---
gnu/packages/linux.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 290090456f..6dd4fdf747 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3541,9 +3541,9 @@ country-specific regulations for the wireless spectrum.")
(("cat ")
(string-append (assoc-ref inputs "coreutils")
"/bin/cat "))
- (("grep ")
+ (("egrep ")
(string-append (assoc-ref inputs "grep")
- "/bin/grep "))
+ "/bin/egrep "))
(("sed -e")
(string-append (assoc-ref inputs "sed")
"/bin/sed -e"))
--
2.26.2
T
T
Tobias Geerinckx-Rice wrote on 17 May 2020 17:12
(name . Nicolò Balzarotti)(address . anothersms@gmail.com)(address . 41358-done@debbugs.gnu.org)
877dxavbnc.fsf@nckx
Nicolò,

Nicolò Balzarotti ???
Toggle quote (9 lines)
> The current version of lm-sensors adjust grep path in the
> pwmconfig
> script, replacing grep->/gnu/store/.../grep. However, the
> script is
> using egrep, leading to the non-existant e/gnu/store/.../grep
> path.
> The attached patch fixes is actually replacing
> egrep->/gnu/store/../egrep

Thanks!

As it was, this change would in turn break fancontrol which does
use plain ‘grep’:

INTERVAL=$(grep -E '^INTERVAL=.*$' $1 | …

I've modified it to match either and pushed as
074cd595bbcd343f86aad09794d8781846ff1927.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXsFURwAKCRANsP+IT1Vt
edNmAQCmZ9hpjWtN2amQ+6UDS9Ay+yaB4baqcq6qi3bZR0hSXwEAsC9DZHziNZl9
PLjB471FXo7nWDMbiYr0DxvCN35xvwE=
=jBvZ
-----END PGP SIGNATURE-----

Closed
N
N
Nicolò Balzarotti wrote on 17 May 2020 17:19
Re: bug#41358: lm-sensors: pwmconfig is broken
(address . 41358-done@debbugs.gnu.org)
87sgfywpv3.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me
Hi Tobias!

Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
writes:

Toggle quote (19 lines)
> Nicolò,
>
> Nicolò Balzarotti ???
>> The current version of lm-sensors adjust grep path in the
>> pwmconfig
>> script, replacing grep->/gnu/store/.../grep. However, the
>> script is
>> using egrep, leading to the non-existant e/gnu/store/.../grep
>> path.
>> The attached patch fixes is actually replacing
>> egrep->/gnu/store/../egrep
>
> Thanks!
>
> As it was, this change would in turn break fancontrol which does
> use plain ‘grep’:
>
> INTERVAL=$(grep -E '^INTERVAL=.*$' $1 | …
>
Sorry for missing that

Toggle quote (3 lines)
> I've modified it to match either and pushed as
> 074cd595bbcd343f86aad09794d8781846ff1927.
>
Thanks!
Nicolò

Toggle quote (3 lines)
> Kind regards,
>
> T G-R
?