Hello,
Vinicius Monego <monego@posteo.net> writes:
Toggle quote (5 lines)
> ---> gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++> 1 file changed, 32 insertions(+)>
Thank you! Could you use "git format-patch" and provide a commit messagein line with what we usually do for new packages? You may want to checkthe commits in the repository to get an idea.
Toggle quote (6 lines)
> +(define-public glabels> + (package> + (name "glabels")> + (version "3.4.1")> + (source (origin
Nitpick: Could you move "(origin" on the next line?
Toggle quote (5 lines)
> + (method url-fetch)> + (uri (string-append "mirror://gnome/sources/" name "/"> + (version-major+minor version) "/"> + name "-" version ".tar.xz"))
Could you replace "name" with "glabels"? We do not hard-code namesanymore in package definitions.
Toggle quote (4 lines)
> + (sha256> + (base32> + "0f2rki8i27pkd9r0gz03cdl1g4vnmvp0j49nhxqn275vi8lmgr0q"))))
Nitpick: Could you put the string on the same line as `base32'?
Toggle quote (8 lines)
> + (build-system glib-or-gtk-build-system)> + (native-inputs> + `(("pkg-config" ,pkg-config)> + ("glib:bin" ,glib "bin")> + ("gettext" ,gettext-minimal)> + ("intltool" ,intltool)> + ("itstool" ,itstool)))
Could you re-order alphabetically the native inputs?
Toggle quote (6 lines)
> + (inputs> + `(("gtk+" ,gtk+)> + ("librsvg" ,librsvg)> + ("libxml2" ,libxml2)))> + (home-page "http://glabels.org/")
The home-page should be using https
Toggle quote (2 lines)
> + (synopsis "Program for creating labels and business cards.")
Synopsis shouldn't end with a full stop. You may want to lint yourpackage definition with "guix lint".
Toggle quote (6 lines)
> + (description> + "gLabels is a program for creating labels and business cards. It is> +designed to work with various laser/ink-jet peel-off label and business> +card sheets that you’ll find at most office supply stores.")> + (license license:gpl3+)))
Could you send an updated patch?
Regards,
-- Nicolas Goaziou