[PATCH] gnu: Add hashcash.

Jakub Kądziołka wrote on 1 Jun 2020 02:40

Recipients:(address . guix-patches@gnu.org)

Message-ID:20200601004015.21684-1-kuba@kadziolka.net

* gnu/packages/networking.scm (hashcash): New variable.---
Is the license field here alright? Here's what the LICENSE file has tosay:

Toggle quote (22 lines)> This software can be distributed and used under any of the following> licenses:> > 	CPL> 	public domain> 	BSD (3 clause -- no advertising clause)> 	LGPL (2.1)> 	GPL (2)> > in rough order of author preference.> > The CPL is probably unique to this package, and is described here:> http://www.cypherspace.org/CPL/; if you can't be bothered to figure it> out feel free to use one of the other licenses.  Earlier versions> where distributed just under CPL.  CPL allows you to re-license under> a license of your choice, I just include other specific licenses to> save people having to read, understand and feel confident in the> validity of the CPL.> > NOTE: on systems without a POSIX getopt this package will be linked> with the included getopt.c which is distributed under GPL 2.

gnu/packages/networking.scm | 46 +++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+)

Toggle diff (64 lines)diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scmindex fd29370841..169aa4ed8e 100644--- a/gnu/packages/networking.scm+++ b/gnu/packages/networking.scm@@ -38,6 +38,7 @@ ;;; Copyright © 2019 Diego N. Barbato <dnbarbato@posteo.de> ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re>+;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net> ;;; ;;; This file is part of GNU Guix. ;;;@@ -3189,3 +3190,48 @@ CDP.  The goal of LLDP is to provide an inter-vendor compatible mechanism to deliver Link-Layer notifications to adjacent network devices.  @code{lldpd} is an implementation of LLDP.  It also supports some proprietary protocols.")     (license license:isc)))++(define-public hashcash+  (package+    (name "hashcash")+    (version "1.22")+    (source+     (origin+       (method url-fetch)+       (uri (string-append "http://www.hashcash.org/source/hashcash-"+                           version ".tgz"))+       (sha256+        (base32+         "15kqaimwb2y8wvzpn73021bvay9mz1gqqfc40gk4hj6f84nz34h1"))))+    (build-system gnu-build-system)+    (arguments+     `(#:make-flags '("CC=gcc")+       #:phases+       (modify-phases %standard-phases+         (delete 'configure)+         ;; No tests available.+         (delete 'check)+         (replace 'install+           (lambda* (#:key outputs #:allow-other-keys)+             (let* ((outdir (assoc-ref outputs "out"))+                    (bindir (string-append outdir "/bin"))+                    (mandir (string-append outdir "/share/man/man1"))+                    (docdir (string-append outdir "/share/doc/hashcash-" ,version)))+               ;; make install assumes /usr and doesn't provide a way to override it+               (install-file "hashcash" bindir)+               (install-file "hashcash.1" mandir)+               (install-file "README" docdir)+               (install-file "LICENSE" docdir)+               (install-file "CHANGELOG" docdir)+               #t))))))+    (home-page "https://www.hashcash.org/")+    (synopsis "Denial-of-service countermeasure")+    (description "Hashcash is a proof-of-work algorithm, which has been used+as a denial-of-service countermeasure technique in a number of systems.++A hashcash stamp constitutes a proof-of-work which takes a parametrizable+amount of work to compute for the sender.  The recipient can verify received+hashcash stamps efficiently.++This package contains a command-line tool for computing and verifying hashcash+stamps.")+    (license license:public-domain)))-- 2.26.2

Mathieu Othacehe wrote on 2 Jun 2020 14:12

Recipients:(name . Jakub Kądziołka)(address . kuba@kadziolka.net)(address . 41637@debbugs.gnu.org)

Message-ID:87o8q1wtt6.fsf@gnu.org

Hello Jakub,

Toggle quote (2 lines)

> + `(#:make-flags '("CC=gcc")

It would be better to use "cc-for-target" here. You can check ifcross-compilation works by running something like:

Toggle snippet (3 lines)

guix build --target=aarch64-linux-gnu hashcash

Thanks,
Mathieu

Jakub Kądziołka wrote on 2 Jun 2020 15:25

Recipients:(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 41637@debbugs.gnu.org)

Message-ID:20200602132555.pkqo4cubxwfnbjbk@gravity

On Tue, Jun 02, 2020 at 02:12:05PM +0200, Mathieu Othacehe wrote:

Toggle quote (12 lines)> > Hello Jakub,> > > +     `(#:make-flags '("CC=gcc")> > It would be better to use "cc-for-target" here. You can check if> cross-compilation works by running something like:> > --8<---------------cut here---------------start------------->8---> guix build --target=aarch64-linux-gnu hashcash> --8<---------------cut here---------------end--------------->8---

Thanks! I had no idea this affects cross-compilation... I have changedthat line to be
`(#:make-flags (list (string-append "CC=" ,(cc-for-target)))
instead. Does the rest of the patch look alright?
Regards,Jakub Kądziołka

Mathieu Othacehe wrote on 3 Jun 2020 08:55

Recipients:(name . Jakub Kądziołka)(address . kuba@kadziolka.net)(address . 41637@debbugs.gnu.org)

Message-ID:87blm07i50.fsf@gnu.org

Hey Jakub,
Thanks for fixing the cross-compilation, a full review this time :)

Toggle quote (11 lines)> +             (let* ((outdir (assoc-ref outputs "out"))> +                    (bindir (string-append outdir "/bin"))> +                    (mandir (string-append outdir "/share/man/man1"))> +                    (docdir (string-append outdir "/share/doc/hashcash-" ,version)))> +               ;; make install assumes /usr and doesn't provide a way to override it> +               (install-file "hashcash" bindir)> +               (install-file "hashcash.1" mandir)> +               (install-file "README" docdir)> +               (install-file "LICENSE" docdir)> +               (install-file "CHANGELOG" docdir)

I think you can set the variables INSTALL_PATH, MAN_INSTALL_PATH andDOC_INSTALL_PATH instead.

Toggle quote (6 lines)

> + #t))))))> + (home-page "https://www.hashcash.org/")> + (synopsis "Denial-of-service countermeasure")> + (description "Hashcash is a proof-of-work algorithm, which has been used> +as a denial-of-service countermeasure technique in a number of systems.

You can remove "in a number of systems".

Toggle quote (8 lines)

> +A hashcash stamp constitutes a proof-of-work which takes a parametrizable> +amount of work to compute for the sender. The recipient can verify received> +hashcash stamps efficiently.> +> +This package contains a command-line tool for computing and verifying hashcash> +stamps.")> + (license license:public-domain)))

I'm also concerned by this line in the Makefile:

Toggle snippet (4 lines)

# request static link of -lcrypto onlyLIBCRYPTO=/usr/lib/libcrypto.a

We should maybe add "openssl" to the inputs and fix this variable(that's what Nix does).
Thanks,
Mathieu

Jakub Kądziołka wrote on 3 Jun 2020 14:18

Recipients:(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 41637@debbugs.gnu.org)

Message-ID:20200603121806.hynak7rp3o5jnhsy@gravity

On Wed, Jun 03, 2020 at 08:55:39AM +0200, Mathieu Othacehe wrote:

Toggle quote (19 lines)> > Hey Jakub,> > Thanks for fixing the cross-compilation, a full review this time :)> > > +             (let* ((outdir (assoc-ref outputs "out"))> > +                    (bindir (string-append outdir "/bin"))> > +                    (mandir (string-append outdir "/share/man/man1"))> > +                    (docdir (string-append outdir "/share/doc/hashcash-" ,version)))> > +               ;; make install assumes /usr and doesn't provide a way to override it> > +               (install-file "hashcash" bindir)> > +               (install-file "hashcash.1" mandir)> > +               (install-file "README" docdir)> > +               (install-file "LICENSE" docdir)> > +               (install-file "CHANGELOG" docdir)> > I think you can set the variables INSTALL_PATH, MAN_INSTALL_PATH and> DOC_INSTALL_PATH instead.

Unfortunately, the variables are defined with `=` instead of `?=`, sothe Makefile always overwrites them. We would also want to skipinstalling the `sha1' tool like Debian does, since `sha1sum' is alreadya thing.

Toggle quote (26 lines)> > +               #t))))))> > +    (home-page "https://www.hashcash.org/")> > +    (synopsis "Denial-of-service countermeasure")> > +    (description "Hashcash is a proof-of-work algorithm, which has been used> > +as a denial-of-service countermeasure technique in a number of systems.> > You can remove "in a number of systems".> > > +A hashcash stamp constitutes a proof-of-work which takes a parametrizable> > +amount of work to compute for the sender.  The recipient can verify received> > +hashcash stamps efficiently.> > +> > +This package contains a command-line tool for computing and verifying hashcash> > +stamps.")> > +    (license license:public-domain)))> > I'm also concerned by this line in the Makefile:> > --8<---------------cut here---------------start------------->8---> # request static link of -lcrypto only> LIBCRYPTO=/usr/lib/libcrypto.a> --8<---------------cut here---------------end--------------->8---> > We should maybe add "openssl" to the inputs and fix this variable> (that's what Nix does).

From what I've read, openssl is not used by default, but only when atarget like `gnu-openssl' is used. I'll make a build with openssl andbenchmark which is faster...
Regards,Jakub Kądziołka

Mathieu Othacehe wrote on 3 Jun 2020 14:30

Recipients:(name . Jakub Kądziołka)(address . kuba@kadziolka.net)(address . 41637@debbugs.gnu.org)

Message-ID:87zh9k5o21.fsf@gnu.org

Toggle quote (8 lines)

>> I think you can set the variables INSTALL_PATH, MAN_INSTALL_PATH and>> DOC_INSTALL_PATH instead.>> Unfortunately, the variables are defined with `=` instead of `?=`, so> the Makefile always overwrites them. We would also want to skip> installing the `sha1' tool like Debian does, since `sha1sum' is already> a thing.

Not if they are passed on the command line, see:https://www.gnu.org/software/make/manual/html_node/Overriding.html
Mathieu

Jakub Kądziołka wrote on 6 Jun 2020 16:39

Recipients:(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 41637@debbugs.gnu.org)

Message-ID:20200606143928.humyr6gzzwcb4ool@gravity

On Wed, Jun 03, 2020 at 08:55:39AM +0200, Mathieu Othacehe wrote:

Toggle quote (27 lines)> > Hey Jakub,> > Thanks for fixing the cross-compilation, a full review this time :)> > > +             (let* ((outdir (assoc-ref outputs "out"))> > +                    (bindir (string-append outdir "/bin"))> > +                    (mandir (string-append outdir "/share/man/man1"))> > +                    (docdir (string-append outdir "/share/doc/hashcash-" ,version)))> > +               ;; make install assumes /usr and doesn't provide a way to override it> > +               (install-file "hashcash" bindir)> > +               (install-file "hashcash.1" mandir)> > +               (install-file "README" docdir)> > +               (install-file "LICENSE" docdir)> > +               (install-file "CHANGELOG" docdir)> > I think you can set the variables INSTALL_PATH, MAN_INSTALL_PATH and> DOC_INSTALL_PATH instead.> > > +               #t))))))> > +    (home-page "https://www.hashcash.org/")> > +    (synopsis "Denial-of-service countermeasure")> > +    (description "Hashcash is a proof-of-work algorithm, which has been used> > +as a denial-of-service countermeasure technique in a number of systems.> > You can remove "in a number of systems".

Note that systems means things like e-mail or bitcoin, rather than Guixor Debian.

Toggle quote (18 lines)> > +A hashcash stamp constitutes a proof-of-work which takes a parametrizable> > +amount of work to compute for the sender.  The recipient can verify received> > +hashcash stamps efficiently.> > +> > +This package contains a command-line tool for computing and verifying hashcash> > +stamps.")> > +    (license license:public-domain)))> > I'm also concerned by this line in the Makefile:> > --8<---------------cut here---------------start------------->8---> # request static link of -lcrypto only> LIBCRYPTO=/usr/lib/libcrypto.a> --8<---------------cut here---------------end--------------->8---> > We should maybe add "openssl" to the inputs and fix this variable> (that's what Nix does).

Firstly, the benchmarking code seems to be broken in Hashcash 1.22.Downgrading to 1.21 and running hashcash -sv, I found that OpenSSLis slower than another minting backend, and is not used by default.I believe it would be better to not include OpenSSL in the package.That's what Debian does, anyway.
I therefore propose only the following changes:

Toggle diff (16 lines)diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scmindex b38e75eb7f..ecd72eee26 100644--- a/gnu/packages/networking.scm+++ b/gnu/packages/networking.scm@@ -3217,7 +3217,7 @@ an implementation of LLDP.  It also supports some proprietary protocols.")                     (bindir (string-append outdir "/bin"))                     (mandir (string-append outdir "/share/man/man1"))                     (docdir (string-append outdir "/share/doc/hashcash-" ,version)))-               ;; make install assumes /usr and doesn't provide a way to override it+               ;; Install manually, as we don't need the `sha1' binary                (install-file "hashcash" bindir)                (install-file "hashcash.1" mandir)                (install-file "README" docdir)
Regards,Jakub Kądziołka

From de679e91b17b3a04a5f07446d0b121ed8f5890ed Mon Sep 17 00:00:00 2001
* gnu/packages/networking.scm (hashcash): New variable.--- gnu/packages/networking.scm | 47 +++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)

Toggle diff (64 lines)diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scmindex fd29370841..d7de5b1956 100644--- a/gnu/packages/networking.scm+++ b/gnu/packages/networking.scm@@ -38,6 +38,7 @@ ;;; Copyright © 2019 Diego N. Barbato <dnbarbato@posteo.de> ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re>+;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net> ;;; ;;; This file is part of GNU Guix. ;;;@@ -3189,3 +3190,49 @@ CDP.  The goal of LLDP is to provide an inter-vendor compatible mechanism to deliver Link-Layer notifications to adjacent network devices.  @code{lldpd} is an implementation of LLDP.  It also supports some proprietary protocols.")     (license license:isc)))++(define-public hashcash+  (package+    (name "hashcash")+    (version "1.22")+    (source+     (origin+       (method url-fetch)+       (uri (string-append "http://www.hashcash.org/source/hashcash-"+                           version ".tgz"))+       (sha256+        (base32+         "15kqaimwb2y8wvzpn73021bvay9mz1gqqfc40gk4hj6f84nz34h1"))))+    (build-system gnu-build-system)+    (arguments+     `(#:make-flags (list (string-append "CC=" ,(cc-for-target)))+       #:phases+       (modify-phases %standard-phases+         (delete 'configure)+         ;; No tests available.+         (delete 'check)+         (replace 'install+           (lambda* (#:key outputs #:allow-other-keys)+             (let* ((outdir (assoc-ref outputs "out"))+                    (bindir (string-append outdir "/bin"))+                    (mandir (string-append outdir "/share/man/man1"))+                    (docdir (string-append outdir "/share/doc/hashcash-" ,version)))+               ;; Install manually, as we don't need the `sha1' binary+               (install-file "hashcash" bindir)+               (install-file "hashcash.1" mandir)+               (install-file "README" docdir)+               (install-file "LICENSE" docdir)+               (install-file "CHANGELOG" docdir)+               #t))))))+    (home-page "https://www.hashcash.org/")+    (synopsis "Denial-of-service countermeasure")+    (description "Hashcash is a proof-of-work algorithm, which has been used+as a denial-of-service countermeasure technique in a number of systems.++A hashcash stamp constitutes a proof-of-work which takes a parametrizable+amount of work to compute for the sender.  The recipient can verify received+hashcash stamps efficiently.++This package contains a command-line tool for computing and verifying hashcash+stamps.")+    (license license:public-domain)))-- 2.26.2

Jakub Kądziołka wrote on 20 Jun 2020 23:29

Done: [PATCH] gnu: Add hashcash.

Recipients:(address . 41637-done@debbugs.gnu.org)

Message-ID:20200620212901.pjakg7cggxoevq3h@gravity

Pushed to master as commit ef6d3b643689953b71fe103e8c6f520b54996f11, closing.

Closed

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date