Hello,
Fredrik Salomonsson <plattfot@gmail.com> writes:
Toggle quote (2 lines)
> * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable
Thank you. Some comments follow.
Nitpick: you need full stops at the end of each sentence in the commitmessage.
Toggle quote (4 lines)
> + (sha256> + (base32> + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
Nitpick: could you move the hash on the same line as `base32'?
Toggle quote (4 lines)
> + (build-system emacs-build-system)> + (home-page> + "https://github.com/jimhourihan/glsl-mode")
Nitpick: could you move the URL on the same line as `home-page'?
Toggle quote (3 lines)
> + (synopsis> + "Major mode for Open GLSL shader files")
Nitpick: … guess what… ;)
Toggle quote (4 lines)
> + (description> + "Major mode for editing OpenGLSL grammar files, usually files ending with> +`.vert', `.frag', `.glsl', `.geom'.
This should be a complete sentence, e.g.,
The library provides a major mode…
Note that Texinfo syntax for file extensions is @file, so the rest ofthe sentence ought to be:
files ending with @file{.vert}, @file{.frag}…
Toggle quote (2 lines)
> Is is based on c-mode plus some
Typo and nitpick: "It is based on C mode"
Could you send an updated patch?
Regards,
-- Nicolas Goaziou