[PATCH] gnu: Add emacs-eglot-jl.

  • Done
  • quality assurance status badge
Details
2 participants
  • Cayetano Santos
  • Nicolas Goaziou
Owner
unassigned
Submitted by
Cayetano Santos
Severity
normal
C
C
Cayetano Santos wrote on 27 Mar 14:58 +0100
(address . guix-patches@gnu.org)(name . Cayetano Santos)(address . csantosb@inventati.org)
ecc51538ce9f5ff8c339cd75870737cf75cf4b96.1711547888.git.csantosb@inventati.org
* gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

Toggle diff (42 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d4819c62ce..f2af107671 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12313,6 +12313,33 @@ (define-public emacs-eglot-tempel
library with Eglot instead of Yasnippet.")
(license license:gpl3+))))
+(define-public emacs-eglot-jl
+ (package
+ (name "emacs-eglot-jl")
+ (version "2.3.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/non-Jedi/eglot-jl.git")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
+ (build-system emacs-build-system)
+ (propagated-inputs (list emacs-eglot))
+ (arguments
+ '(#:include '("^[^/]+.el$"
+ "^[^/]+.jl$"
+ "^[^/]+.toml$")))
+ (home-page "https://github.com/non-Jedi/eglot-jl")
+ (synopsis "Julia support for eglot")
+ (description
+ "This package adds support for @code{emacs-eglot} to the Julia language.")
+ (license:cc-by2.0)))
+
(define-public emacs-consult-xdg-recent-files
(let ((commit "593023ffb99a368152ebd4e739488fa560bdfdea")
(revision "0"))

base-commit: 656baadf83f2812c0ff79f4f2f0b5f1e927ed8a5
--
2.41.0
N
N
Nicolas Goaziou wrote on 27 Mar 16:59 +0100
(name . Cayetano Santos via Guix-patches via)(address . guix-patches@gnu.org)
87h6gris3c.fsf@nicolasgoaziou.fr
Hello,

Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (2 lines)
> * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Thanks.

Toggle quote (11 lines)
> +(define-public emacs-eglot-jl
> + (package
> + (name "emacs-eglot-jl")
> + (version "2.3.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/non-Jedi/eglot-jl.git")

Nitpick: I think ".git" suffixes are usually removed.

Toggle quote (12 lines)
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
> + (build-system emacs-build-system)
> + (propagated-inputs (list emacs-eglot))
> + (arguments
> + '(#:include '("^[^/]+.el$"
> + "^[^/]+.jl$"
> + "^[^/]+.toml$")))

This is a bit verbose, and ignores %default-include variable. I suggest
(using G-expressions just because we can)

(arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include)))

Toggle quote (3 lines)
> + (synopsis "Julia support for eglot")

Nitpick: Julia support for Eglot

Toggle quote (3 lines)
> + (description
> + "This package adds support for @code{emacs-eglot} to the Julia language.")

Nitpick: ... support for Eglot to the Julia language.

Toggle quote (2 lines)
> + (license:cc-by2.0)))

I think there is a typo here. You mean

(license license:cc-by2.0)

However, it seems to licensed under CC0 terms.

Could you send an updated patch?

Regards,
--
Nicolas Goaziou
C
C
Cayetano Santos wrote on 28 Mar 09:55 +0100
[PATCH v1] gnu: Add emacs-eglot-jl.
(address . 70029@debbugs.gnu.org)(name . Cayetano Santos)(address . csantosb@inventati.org)
dc3d8cd6c98ea209d5bb87bb1abd1425bc208da1.1711616138.git.csantosb@inventati.org
* gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Signed-off-by: Cayetano Santos <csantosb@inventati.org>
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

Toggle diff (39 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d4819c62ce..683ea08ed4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12313,6 +12313,30 @@ (define-public emacs-eglot-tempel
library with Eglot instead of Yasnippet.")
(license license:gpl3+))))
+(define-public emacs-eglot-jl
+ (package
+ (name "emacs-eglot-jl")
+ (version "2.3.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/non-Jedi/eglot-jl")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
+ (build-system emacs-build-system)
+ (propagated-inputs (list emacs-eglot))
+ (arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include)))
+ (home-page "https://github.com/non-Jedi/eglot-jl")
+ (synopsis "Julia support for Eglot")
+ (description
+ "This package adds support for Eglot to the Julia language.")
+ (license license:cc0)))
+
(define-public emacs-consult-xdg-recent-files
(let ((commit "593023ffb99a368152ebd4e739488fa560bdfdea")
(revision "0"))

base-commit: 656baadf83f2812c0ff79f4f2f0b5f1e927ed8a5
--
2.41.0
N
N
Nicolas Goaziou wrote on 29 Mar 13:29 +0100
(name . Cayeptano Santos via Guix-patches via)(address . guix-patches@gnu.org)
8734s943x7.fsf@nicolasgoaziou.fr
Hello,

Toggle quote (2 lines)
> * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Applied. Thanks!

Toggle quote (2 lines)
> Signed-off-by: Cayetano Santos <csantosb@inventati.org>

Note: Signing off is for the committer, not for the provider of the
patch, if they differ.

Regards,

--
Nicolas Goaziou
?