From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 23 12:32:40 2018 Received: (at 33848) by debbugs.gnu.org; 23 Dec 2018 17:32:40 +0000 Received: from localhost ([127.0.0.1]:33981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb7cF-0006VM-MU for submit@debbugs.gnu.org; Sun, 23 Dec 2018 12:32:40 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:52410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb7cE-0006VE-44 for 33848@debbugs.gnu.org; Sun, 23 Dec 2018 12:32:38 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7CD6312BB; Sun, 23 Dec 2018 18:32:37 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qtk9Zqe9FfNj; Sun, 23 Dec 2018 18:32:36 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6997F1282; Sun, 23 Dec 2018 18:32:36 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mark H Weaver Subject: Re: bug#33848: Store references in SBCL-compiled code are "invisible" References: <87r2e8jpfx.fsf@gnu.org> <877eg0i43j.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 =?utf-8?Q?Niv=C3=B4se?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 23 Dec 2018 18:32:35 +0100 In-Reply-To: <877eg0i43j.fsf@netris.org> (Mark H. Weaver's message of "Sun, 23 Dec 2018 11:45:25 -0500") Message-ID: <87d0psi1xo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 33848 Cc: Pierre Neidhardt , 33848@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Mark, Mark H Weaver skribis: > Ludovic Court=C3=A8s writes: [...] >> Apparently this string literal is stored as UTF-32 (UCS-4) or similar, >> which prevents the reference scanner and the grafting code from finding >> it, and problems ensue. :-) > > IMO, we should consider modifying Guix to search for store references > encoded in UTF-32 and/or UTF-16. I wouldn't be surprised if some other > programs use those encodings. I'd be willing to work on it. I don=E2=80=99t think we=E2=80=99ve encountered the problem before. This w= ould require fixing both the scanner and the grafting code (though eventually that might be a single code base when the Scheme-implemented daemon is merged) in non-trivial ways. One issue is that users of an old daemon would get a different behavior than users of a new daemon. It would be the first time we introduce such a significant change in the daemon since Guix was started. For now I lean towards looking for a way to address the issue specifically for SBCL. I=E2=80=99d be tempted to generalize if and only if= we find other occurrences of the problem that would make the benefits outweigh the development and maintenance costs. WDYT? I remember discussing in the past some sort of =E2=80=9Cpluggable=E2=80=9D = reference scanning mechanism that could also work for compressed archives, etc. That also looks like the right thing, but it has a development and maintenance cost that=E2=80=99s pretty high whereas we might be able to add= ress the same problems in much simpler ways. Thanks, Ludo=E2=80=99.