From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 08:17:24 2019 Received: (at 36244-done) by debbugs.gnu.org; 20 Jun 2019 12:17:24 +0000 Received: from localhost ([127.0.0.1]:48003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdw0K-0005rE-Ay for submit@debbugs.gnu.org; Thu, 20 Jun 2019 08:17:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdw0H-0005qk-H7 for 36244-done@debbugs.gnu.org; Thu, 20 Jun 2019 08:17:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hdw0B-0008H0-50; Thu, 20 Jun 2019 08:17:16 -0400 Received: from vpn-0-27.aquilenet.fr ([2a0c:e300:4:27::]:45924 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hdvio-00013d-R9; Thu, 20 Jun 2019 07:59:22 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Robert Vollmert Subject: Re: [bug#36244] [PATCH] guix: canonical-newline-port: Fix handling of carriage return at buffer end. References: <20190616141829.28689-1-rob@vllmrt.net> Date: Thu, 20 Jun 2019 13:59:13 +0200 In-Reply-To: <20190616141829.28689-1-rob@vllmrt.net> (Robert Vollmert's message of "Sun, 16 Jun 2019 16:18:29 +0200") Message-ID: <87sgs4jwmm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36244-done Cc: 36244-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Robert, Robert Vollmert skribis: > Prior to this change the added test fails for me locally at byte > 1024. It might depend on some default buffer sizes. > > Fixes https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35863 > > * tests/utils.scm ("canonical-newline-port-1024"): Add test. > * guix/utils.scm (canonical-newline-port): Correct comments on CR/LF. > Remove CR even when they're at the end of the buffer. Good catch. I tweaked the commit log and applied it. Thanks, Ludo=E2=80=99.