From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 18:52:22 2019 Received: (at 36641) by debbugs.gnu.org; 13 Jul 2019 22:52:22 +0000 Received: from localhost ([127.0.0.1]:43564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmQsP-00011E-MB for submit@debbugs.gnu.org; Sat, 13 Jul 2019 18:52:21 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmQsM-00010z-Ki for 36641@debbugs.gnu.org; Sat, 13 Jul 2019 18:52:19 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 764C120F20; Sat, 13 Jul 2019 18:52:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 13 Jul 2019 18:52:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=rC+6mnJuHpf5EuJ4lmMV98nNbD kLG858+FJU4qq6E+0=; b=C8GiF2dIHDoe5u1U3HK280XxPgRYVWvkIzuKdCxbAl egLVFWMA2cUDHOOCDaeDJMHH8ib7QjgwmLUhZP3wHSqfl9hm2xOHGrcI7q9Q1tsm Ot51OX8H6RvTqgbQIwG1qeYDubnmnKgjz6322BohzxSrNfhB4nh62r4RoxO3gHpM Lt0qvV7OpoEMoY9bFY30YAlPvLK6V8Peti8V8zCHdH4TprK51ZJMSvZSFwamtg9c 8yzZZL0LQlKhJ95h4u48LHny9F4KOIyQobcVtioSPo7VbemylbhI4RUxoTOEH7je rZahyCI3bmqT7IxgJcfLyW2HgoF4rTw2gUy/e4/NeCDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rC+6mn JuHpf5EuJ4lmMV98nNbDkLG858+FJU4qq6E+0=; b=wtfPthQ2vuHF9LyOWOJM7o sq9yJdhiH7xqZOgFe3EqLYE67ePf767i0Puj4ys9zGrjP2wJExFaMKJnnEzFd7N7 rbS1sbToz7wrlba6xAdiK6GVtXa7q3HCiRRBQPjK3qkMVPL/XwwV0742PJyPuChx pCT9pZBnaFmECquTWlCWYgGWzki0OMX18jJlSgfHS+65XyjNjFju9uvfHUFO7Ek/ M37MyRV4gE8twco4d586QIXIN5blk+Mwd3DmrhxIfDR4uWODaGaM4eayiz5rupIT img/AthUqD83e/0tCyGcHHk86OOz+jcTPdcLEwGQoFIe+3+KVNjaZvktWQXNHUtQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrheegucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesghdtreertdertd enucfhrhhomhepofgrrhhiuhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghi lhdrtghomheqnecukfhppeeivddrudeirddvvdeirddugedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmnecuvehluhhsthgvrhfu ihiivgeptd X-ME-Proxy: Received: from localhost (140.226.16.62.customer.cdi.no [62.16.226.140]) by mail.messagingengine.com (Postfix) with ESMTPA id B67638005C; Sat, 13 Jul 2019 18:52:12 -0400 (EDT) From: Marius Bakke To: Christopher Baines , 36641@debbugs.gnu.org Subject: Re: [bug#36641] [PATCH] gnu: python-gst: Fix build failure. In-Reply-To: <20190713220059.7336-1-mail@cbaines.net> References: <20190713220059.7336-1-mail@cbaines.net> User-Agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.2 (x86_64-pc-linux-gnu) Date: Sun, 14 Jul 2019 00:52:11 +0200 Message-ID: <87muhhlf8k.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 36641 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Christopher Baines writes: > Building python-gst fails with: > > Unbound variable: python-version > > Therefore, add python-build-system to #:modules so that it's imported, and > give it a prefix to avoid clashing with the gnu-build-system. > > Also, simplify the code by using the site-packages function from the > python-build-system module. > > * gnu/packages/gstreamer.scm (python-gst)[arguments]: Rework to fix build > failure. > --- > gnu/packages/gstreamer.scm | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm > index b0f0b032b3..efb9a6f796 100644 > --- a/gnu/packages/gstreamer.scm > +++ b/gnu/packages/gstreamer.scm > @@ -431,17 +431,14 @@ compression formats through the use of the libav library.") > "0f1d9rvy2qxlymmfzyknnfr5rz1vx69jv17gp7wnamc5s6p7mp2m")))) > (build-system gnu-build-system) > (arguments > - ;; XXX: Factorize python-sitedir with python-build-system. > - `(#:imported-modules (,@%gnu-build-system-modules > + `(#:modules ((guix build gnu-build-system) > + ((guix build python-build-system) #:prefix python:)) > + #:imported-modules (,@%gnu-build-system-modules > (guix build python-build-system)) > #:configure-flags > - (let* ((python (assoc-ref %build-inputs "python")) > - (python-version (python-version python)) > - (python-sitedir (string-append > - "lib/python" python-version "/site-packages"))) > - (list (string-append > - "--with-pygi-overrides-dir=" %output "/" python-sitedir > - "/gi/overrides"))))) > + (list (string-append > + "--with-pygi-overrides-dir=" %output "/" Nitpicking, but since we're refactoring, could you also change %output to the less magical (assoc-ref %outputs "out")? > + (python:site-packages %build-inputs %outputs) "/gi/overrides")))) Neat! LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl0qYJsACgkQoqBt8qM6 VPrqQwf/Z64VaysnLZ67cVwId0q0q5OrBC/K+7HUvo+RRiJ8+qIbsk02hm/7WAQP M3/7Qz8A2IhFeAPtJr5IVzk5QuE9aAXvwyvT9x4u7Su4tYUJQpQYtjFnNinFMqag zIXL4PtXkvkVwrPsnGVNWWFwti+b8x3xXRITFP8CeSDbgoZDfLpigxffP2ukxO/R kHLxyJNSfgvVBUcCZN6XmRrQxfIguSK58wBki6spMmGbZsu9IB+P3VsuPs7d7HeG hJ0IWtsDUqNwjkNq98BWoxqpP+rIPdlyZhovDYcueIzouAo10yHipPqymQdCtEss Z7vp8AMCkVOd5r8bkSPMq6FLLCcMYA== =izMN -----END PGP SIGNATURE----- --=-=-=--