From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 17 09:35:24 2019 Received: (at 36658) by debbugs.gnu.org; 17 Jul 2019 13:35:24 +0000 Received: from localhost ([127.0.0.1]:51713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnk5c-0005SA-Hb for submit@debbugs.gnu.org; Wed, 17 Jul 2019 09:35:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnk5a-0005Ry-Nl for 36658@debbugs.gnu.org; Wed, 17 Jul 2019 09:35:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hnk5U-000654-PR; Wed, 17 Jul 2019 09:35:16 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33066 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hnk5U-00049u-BG; Wed, 17 Jul 2019 09:35:16 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Giacomo Leidi Subject: Re: [bug#36658] [PATCH] gnu: Add emacs-zerodark-theme. References: <20190715092818.2490-1-goodoldpaul@autistici.org> Date: Wed, 17 Jul 2019 15:35:14 +0200 In-Reply-To: <20190715092818.2490-1-goodoldpaul@autistici.org> (Giacomo Leidi's message of "Mon, 15 Jul 2019 11:28:18 +0200") Message-ID: <87blxsbx7x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 36658 Cc: 36658@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Giacomo Leidi skribis: > * gnu/packages/emacs-xyz.scm (emacs-zerodark-theme): New variable. Thanks for this patch! Below are a couple of suggestions. > +(define-public emacs-zerodark-theme > + (package > + (name "emacs-zerodark-theme") ^ The indentation is off here (you can do M-q to fix it if you use paredit). > + (version "20190528.923") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://melpa.org/packages/zerodark-theme-" > + version > + ".el")) This URL is unstable: the file will be modified in place regularly. Consequently, could you instead use the upstream Git repository URL along with the =E2=80=98git-fetch=E2=80=99 method? > + (synopsis > + "A dark, medium contrast theme for Emacs") ^ Please remove =E2=80=9CA=E2=80=9D, as suggested by =E2=80=98guix lint=E2=80= =99. > + (description > + "A dark theme inspired from One Dark and Niflheim. Please write a full sentence (info "(guix) Synopses and Descriptions"). > +An optional mode-line format can be enabled with 'zerodark-setup-modelin= e-format'.") ^ Please use @code as suggested by =E2=80=98guix lint=E2=80=99. Could you send an updated patch? Thanks! Ludo=E2=80=99.