From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 28 12:33:41 2019 Received: (at 37138) by debbugs.gnu.org; 28 Aug 2019 16:33:41 +0000 Received: from localhost ([127.0.0.1]:51158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i30t8-0001Ib-RE for submit@debbugs.gnu.org; Wed, 28 Aug 2019 12:33:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i30t6-0001IJ-HN for 37138@debbugs.gnu.org; Wed, 28 Aug 2019 12:33:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i30t1-0004z0-Ck; Wed, 28 Aug 2019 12:33:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47676 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i30t0-0003nU-S8; Wed, 28 Aug 2019 12:33:31 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Steve Sprang Subject: Re: [bug#37138] [PATCH] gnu: Add speedcrunch. References: Date: Wed, 28 Aug 2019 18:33:29 +0200 In-Reply-To: (Steve Sprang's message of "Wed, 21 Aug 2019 17:25:41 -0700") Message-ID: <87a7btgsh2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37138 Cc: 37138@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Steve, Steve Sprang skribis: > From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001 > From: Steve Sprang > Date: Wed, 21 Aug 2019 17:17:02 -0700 > Subject: [PATCH] gnu: Add speedcrunch. > > * gnu/packages/maths.scm (speedcrunch): New variable. Nice. A couple of comments: > + (source (origin > + (method url-fetch) > + (uri (string-append "https://bitbucket.org/heldercorreia/" > + "speedcrunch/get/release-" version > + ".tar.gz")) I suspect this /get URL returns a generated tarball, whose exact content might change over time. If that is the case, could you instead use =E2=80=98git-fetch=E2=80=99 (or =E2=80=98hg-fetch=E2=80=99)? > + (inputs `(("qt" ,qt))) Please use =E2=80=98qtbase=E2=80=99 & co., aka. the =E2=80=9Cmodular Qt pac= kages=E2=80=9D. The =E2=80=98qt=E2=80=99 package is the old monolithic package and is actually deprecated. Could you send an updated patch? Thanks! Ludo=E2=80=99.