From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 28 12:39:01 2019 Received: (at 37169) by debbugs.gnu.org; 28 Aug 2019 16:39:01 +0000 Received: from localhost ([127.0.0.1]:51168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i30yK-0001S3-Tu for submit@debbugs.gnu.org; Wed, 28 Aug 2019 12:39:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i30yJ-0001Ro-Dm for 37169@debbugs.gnu.org; Wed, 28 Aug 2019 12:38:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i30yE-0007zT-8w; Wed, 28 Aug 2019 12:38:54 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47714 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i30yC-0006d6-FK; Wed, 28 Aug 2019 12:38:53 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Steve Sprang Subject: Re: [bug#37169] [PATCH] gnu: Add lib3mf. References: Date: Wed, 28 Aug 2019 18:38:51 +0200 In-Reply-To: (Steve Sprang's message of "Fri, 23 Aug 2019 17:12:32 -0700") Message-ID: <87y2zdfdno.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 37169 Cc: 37169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Steve Sprang skribis: > From 09b40a31d69ca6f6894d9ed33ef519efc64b220b Mon Sep 17 00:00:00 2001 > From: Steve Sprang > Date: Fri, 23 Aug 2019 15:23:00 -0700 > Subject: [PATCH] gnu: Add lib3mf. > > * gnu/packages/engineering.scm (lib3mf): New variable. Could you address the =E2=80=98guix lint=E2=80=99 warnings? In particular,= you=E2=80=99ll have to use =E2=80=98git-fetch=E2=80=99 to get the source. > + (add-after 'unpack 'unpack-googletest > + (lambda* (#:key inputs #:allow-other-keys) > + (copy-recursively (assoc-ref inputs "googletest-source") > + "UnitTests/googletest") Would it work to simply pass =E2=80=98googletest=E2=80=99 as an input? If not, this approach is fine IMO. > + "Lib3MF is a C++ implementation of the 3D Manufacturing Format (3MF= ) file > +standard. It offers a way to integrate 3MF reading and writing capabili= ties, as > +well as conversion and validation tools for input and output data. The > +specification can be downloaded at http://3mf.io/specification/.") ^ You can write: @url{http://=E2=80=A6}. Thanks, Ludo=E2=80=99.