From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 05:02:29 2019 Received: (at submit) by debbugs.gnu.org; 28 Sep 2019 09:02:29 +0000 Received: from localhost ([127.0.0.1]:48995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iE8cX-0006gN-F0 for submit@debbugs.gnu.org; Sat, 28 Sep 2019 05:02:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:44311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iE8cT-0006g6-9p for submit@debbugs.gnu.org; Sat, 28 Sep 2019 05:02:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41056) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iE8cR-0001h1-Ql for guix-patches@gnu.org; Sat, 28 Sep 2019 05:02:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iE8cN-0003I4-Si for guix-patches@gnu.org; Sat, 28 Sep 2019 05:02:23 -0400 Received: from sonic307-53.consmr.mail.ir2.yahoo.com ([87.248.110.30]:37755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iE8cN-0003HV-Jy for guix-patches@gnu.org; Sat, 28 Sep 2019 05:02:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1569661337; bh=jQ8Y6roxwdlB2X5vA+ApIn0Y/W045di4l2e6chlXcB4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=r2BivesXy6E/x88gwtngvzSjIo/gyKa0VLTH79EtWjWV2xs8M4gN1Tyq9xXq9XsFqTtemMQjRP9pW/BZqGfd1QEFqZD6w/Z4EsXkSl9byZZFxRPouEVgDCrhMkNFGMRcGMcss5h5ci5+K3GkMAQHl9BVE0l5GIXLKOOSmiF6dL4qoyNLXqeczQ0Z3qSsHhse83YvYp7cagziU8zmKHkIRW/KIXBc68dEUxgZX97S2QBfL690ifyKx46xBMLEa0VYrmzo+GsHYozmPW3P8eM74QPWE4CvtYI8OPGCv2HpmEKn5VegXzJxw4C7AyYHrBMq0UboV4oHsbcmEMbPO47wvQ== X-YMail-OSG: l2T2EjIVM1nLYe4TKlvxpNqF2ob.FFCy3Sm0ZALMq2v0XH7oV4kv4Qy3TmjZvZY r6BQWAg2mZfW3azASQn2O8kO0RPECyGfZ403HcsFYGxNITWKf2KQ9r4fuk.aV8wY9EUhre2ZKzSC 9Kjni_kqPf78oS7RUqIe2cMWASIvkub4oRPGi455Vq9AUXTAFI0uy2s8kdJR7nZDSaweLz2EXm1v SVkWChkjfnKh22OXTHScAPha0lxXz7RGsM6AHyZUkxZp.x8XiWYA5PH8OKdqJAYd9biYTHdSM9cd YRTyVVyrzBrfYXRn0cYYheTX0nBAGZbmRbPOv6zlbFKDW527GEv4XQBS0a_q1KMeVJoIYGzmPZX5 14jogG8ySAqeeCdW1xlx3Nzro.C_zp_iHy.lO0WpyF9HjozEb9A.vkGQRDCmzeLOw81hDTIgMdXh FZ_xCNwUWjV70ySN7CYIC7zsNZPRlKDoIHCtHWDeI_3V8E.EnTr4AJTXbcWR3EcdjaVXsLhhZ92A 8TsjEW1.LiztWd_KQPHN_tPp35KhBr5L1D7e.ogU9gDJLWa8uDTBtikvuRBzlKMz4HoHawoR0Dc8 2Ep3qxr2w54JvNsaXTjsnzk.vdPIx2t27QweaPuUNqcG4zV0snF4liBBm3nuCm7CBBVACj.GrQcM WhkG95aWdx49xt3tlpbl1JF2h4X9CNmy3Osqp.JHarClj71xftOEKx0UzwXc9pCrwK4Ej8dMyc3f uSPfdnGXcsmPe0tYR6iigwnzi34BJBbTHlVztPAMmqsxLpJ0uZPgJFieGq7_9zFaYsv4_X0Pkr4i zydot7Qo8xK1MAbEdHluyt1rYDUdhpLMsM0UfgZJrtpjxQat60JuRcejOdc4OtiT62X8i7Rom9RX s42Z4vz7IkXm4gt_W6I.PV9Rcs5tPZpWZ7vfoErxB0wd2DdRQGz2h9ZY1bgsizP5G0twev3TjAkt F50HMjGUlCm6CJUGxcuwWuUwTnLS7mLGCjfZJaxbO5NaggoSkDYWF_UId9nYBpsDSvcQMoNpbwMQ GT01U4a.y6P1Wnl4jDYbzkuO7Ghj9q_QI5PX.fN5yNszDE8Yh5XjVVzTtMZvdII2ZP2IRKJDoxj8 yRqhvofqqCSic9NV4dQuA2UfBdsuH6rBQu_uZLXraEV2JQAka8HS1gsTgdpvOxn5GdpEdzpUqJDz L8F0ENj8kZMKMK4glwuMbXAfkh9iad0aITw4igXHZ2udqpjA3mVQ5kaUVwe86UI4Yk67m.hCnDa. QwYAVupmjiLxDC.RsmWsbM6idQH7T4Rsdosnez6dB Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Sat, 28 Sep 2019 09:02:17 +0000 Date: Sat, 28 Sep 2019 09:02:12 +0000 (UTC) From: Dumitrascu Vasile To: Vasile Dumitrascu via Guix-patches , Tobias Geerinckx-Rice Message-ID: <1727802752.681659.1569661332406@mail.yahoo.com> In-Reply-To: <875zlde4m5.fsf@nckx> References: <20190927203251.30974-1-va511e@yahoo.com> <875zlde4m5.fsf@nckx> Subject: Re: [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support. MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_681658_1275654177.1569661332405" X-Mailer: WebService/1.1.14448 YMailNorrin Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 Content-Length: 7894 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 87.248.110.30 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit Cc: 37534@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Dumitrascu Vasile Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) ------=_Part_681658_1275654177.1569661332405 Content-Type: multipart/alternative; boundary="----=_Part_681657_1582018685.1569661332330" ------=_Part_681657_1582018685.1569661332330 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =C2=A0 Hi Tobias Thank you for the review and sorry to have missed the sorting. I have re-attached the original patch as a file to this email, as I guess t= he encoding issues were caused by git send-mail. =C2=A0 Thank you again,=C2=A0=C2=A0=C2=A0 Vasile On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tobias Geerinckx-Ri= ce wrote: =20 =20 Vasile, Vasile Dumitrascu via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > --- a/gnu/packages/conky.scm > +++ b/gnu/packages/conky.scm > @@ -2,6 +2,7 @@ >=C2=A0 ;;; Copyright ?? 2015 Sini??a Bi??in >=C2=A0 ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice=20 >=C2=A0 >=C2=A0 ;;; Copyright ?? 2019 Pierre Neidhardt > +;;; Copyright ?? 2019 Vasile Dumitrascu Does this show up as corrupted in your mailbox as well?=C2=A0 (=E2=80=98??= =E2=80=99=20 instead of =E2=80=98=C2=A9=E2=80=99.) > @@ -76,6 +79,7 @@ >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("libxext" ,libxext) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("libxft" ,libxft) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("libxinerama" ,libxinerama) > +=C2=A0 =C2=A0 =C2=A0 ("pulseaudio", pulseaudio) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("lua" ,lua) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("ncurses" ,ncurses) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("curl" ,curl))) I guess any hope of alphabetical ordering was lost long ago. The change looks fine to me, but could you try fixing the text=20 encoding? Thanks! T G-R =20 ------=_Part_681657_1582018685.1569661332330 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
  Hi Tobias

Thank you for the review and sorry to have missed the sorting.
I have re-attached the original patch as a file to this email, as = I guess the encoding issues were caused by git send-mail.

  Thank you again,
    Vasile

=20
=20
On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tob= ias Geerinckx-Rice <me@tobias.gr> wrote:


Vasile,

Vasile Dumitrascu via Guix-patches via =E5=86=99=E9=81=93=EF=BC= =9A
> --- a/gnu/packages/conky.scm
&= gt; +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa@bidin.eu>
>  ;;; Copyright ?? 201= 8, 2019 Tobias Geerinckx-Rice
>  <me@t= obias.gr>
>  ;;; Copyright ?? 2019 Pierre = Neidhardt <mail@ambrevar.xyz>
> = +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e@yahoo.com>

Does this show up as corrupted i= n your mailbox as well?  (=E2=80=98??=E2=80=99
inst= ead of =E2=80=98=C2=A9=E2=80=99.)


> @@ -7= 6,6 +79,7 @@
>        ("libxext" = ,libxext)
>        ("libxft" ,lib= xft)
>        ("libxinerama" ,lib= xinerama)
> +      ("pulseaudio", puls= eaudio)
>        ("lua" ,lua)
>        ("ncurses" ,ncurses)
>        ("curl" ,curl)))


I guess any hope of alphabetical ordering was= lost long ago.

The change looks fine = to me, but could you try fixing the text
encoding?

Thanks!

T G-R
------=_Part_681657_1582018685.1569661332330-- ------=_Part_681658_1275654177.1569661332405 Content-Type: text/x-patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-gnu-conky-Activate-Pulseaudio-support.patch" Content-ID: <30338319-d9ee-e63d-c775-9bc0f8e7521d@yahoo.com> RnJvbSBkZGQxNGY5MmZhYTYyOThmOTNkZWQxMWZmMWY5NmIzNGY4NDdhNTQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWYXNpbGUgRHVtaXRyYXNjdSA8dmE1MTFlQHlhaG9vLmNvbT4K RGF0ZTogRnJpLCAyNyBTZXAgMjAxOSAyMjozMjowNSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogY29ua3k6IEFjdGl2YXRlIFB1bHNlYXVkaW8gc3VwcG9ydC4KCiogZ251L3BhY2thZ2VzL2Nv bmt5LnNjbSAoY29ua3kpOgogIFtpbnB1dHNdIEFkZCBwdWxzZWF1ZGlvLgotLS0KIGdudS9wYWNr YWdlcy9jb25reS5zY20gfCA2ICsrKysrLQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9jb25reS5zY20gYi9n bnUvcGFja2FnZXMvY29ua3kuc2NtCmluZGV4IDY4MWZlYjZlNDMuLjA0NmQxMzJhOWIgMTAwNjQ0 Ci0tLSBhL2dudS9wYWNrYWdlcy9jb25reS5zY20KKysrIGIvZ251L3BhY2thZ2VzL2Nvbmt5LnNj bQpAQCAtMiw2ICsyLDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNSBTaW5pxaFhIEJpxJFpbiA8 c2luaXNhQGJpZGluLmV1PgogOzs7IENvcHlyaWdodCDCqSAyMDE4LCAyMDE5IFRvYmlhcyBHZWVy aW5ja3gtUmljZSA8bWVAdG9iaWFzLmdyPgogOzs7IENvcHlyaWdodCDCqSAyMDE5IFBpZXJyZSBO ZWlkaGFyZHQgPG1haWxAYW1icmV2YXIueHl6PgorOzs7IENvcHlyaWdodCDCqSAyMDE5IFZhc2ls ZSBEdW1pdHJhc2N1IDx2YTUxMWVAeWFob28uY29tPgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBh cnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTMxLDYgKzMyLDcgQEAKICAgIzp1c2UtbW9kdWxlIChn bnUgcGFja2FnZXMgbHVhKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBuY3Vyc2VzKQog ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwa2ctY29uZmlnKQorICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyBwdWxzZWF1ZGlvKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB4 b3JnKSkKIAogKGRlZmluZS1wdWJsaWMgY29ua3kKQEAgLTUxLDcgKzUzLDggQEAKICAgICAoYXJn dW1lbnRzCiAgICAgIGAoIzp0ZXN0cz8gI2YgICAgICAgICAgICAgICAgICAgICAgOyB0aGVyZSBh cmUgbm8gdGVzdHMKICAgICAgICAjOmNvbmZpZ3VyZS1mbGFncwotICAgICAgIChsaXN0ICItRFJF TEVBU0U9dHJ1ZSIpCisgICAgICAgKGxpc3QgIi1EUkVMRUFTRT10cnVlIgorICAgICAgICAgICAg ICItREJVSUxEX1BVTFNFQVVESU89T04iKQogICAgICAgICM6cGhhc2VzCiAgICAgICAgKG1vZGlm eS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwogICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICdh ZGQtZnJlZXR5cGUtdG8tc2VhcmNoLXBhdGgKQEAgLTc2LDYgKzc5LDcgQEAKICAgICAgICAoImxp YnhleHQiICxsaWJ4ZXh0KQogICAgICAgICgibGlieGZ0IiAsbGlieGZ0KQogICAgICAgICgibGli eGluZXJhbWEiICxsaWJ4aW5lcmFtYSkKKyAgICAgICAoInB1bHNlYXVkaW8iLCBwdWxzZWF1ZGlv KQogICAgICAgICgibHVhIiAsbHVhKQogICAgICAgICgibmN1cnNlcyIgLG5jdXJzZXMpCiAgICAg ICAgKCJjdXJsIiAsY3VybCkpKQotLSAKMi4yMy4wCgo= ------=_Part_681658_1275654177.1569661332405--