From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 01:37:32 2019 Received: (at 37701-done) by debbugs.gnu.org; 14 Oct 2019 05:37:32 +0000 Received: from localhost ([127.0.0.1]:37538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJt2x-0001wU-B1 for submit@debbugs.gnu.org; Mon, 14 Oct 2019 01:37:32 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJm6N-0008F2-IJ for 37701-done@debbugs.gnu.org; Sun, 13 Oct 2019 18:12:37 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7743021B2F; Sun, 13 Oct 2019 18:12:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 13 Oct 2019 18:12:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daviwil.com; h= date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; s=fm3; bh=yoV808lCZLzLnl/XcyLdseOEyI C1Z6uokquICcY9l5Q=; b=Q8USXftg6p6/dUh5U1LHjSBTm1BzTzEPP3O5x37GLh EM5pfwfegIJgJbmY9eXqB3qt7/eIGCtE2rMY0IUW1fb3mRE8Keo6KkaWjBrRgqLh BW+iUETPX07t7WeOSug4g4w1+4t1UjaXYgJZ6hS6sCMMOQ1LUe0F2ESXYc/frxuP hlRm64pVo1VlvFqid9mpnLWCRnNwT9L3aB6owmpzLAHY7Y/Zkq+cef023M017nwa yhv47u/wNWYaV5r/dEkOhHwXjOLFJony0BXiMT0ZOiDEWzenAfpFm+R41uhrj3gb qWsmU7mzet+YKmV1nJ0wdbY/bWVyarmuaQxiwDFueNzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yoV808 lCZLzLnl/XcyLdseOEyIC1Z6uokquICcY9l5Q=; b=aU1nfltrc3QC0trmt/Jp2W OeCTqTGxtEwAOAIN4N1VbeVDaRqwzzYhLQlkPnaWp6PQHGDriypqXUO9gYG0/3cc K2GN6aym7anfKjtXDQi08h2X+Z5hx4AxX9936oHWCPPadr+LTcf3S632/enJWC6X fG6ezXBW/qEnDzLN81V+YdMPYRvYmpdkrM8p5unSUQm+3OQJtJVxNXz+onXKTDMb GliMR6GUKWbS48421kJhM5FHdLGcTZq6Djw6eVX6uO0hLD7dPwxls2C0KtvnNHzm R0Ad6x1Oyjum3c3sNFPCerEChY2Lq3H18WtvQdiXV17aTJP1e8UJQyFMbhvLXhGQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrjedtgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvkfgjfhfugggtofesmhdtregsredtjeenucfhrhhomhepffgrvhhiugcu hghilhhsohhnuceouggrvhhiugesuggrvhhifihilhdrtghomheqnecukfhppeehvddrud dvhedruddvkedrfeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurghvihgusegurghv ihifihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from mail.outlook.com (unknown [52.125.128.34]) by mail.messagingengine.com (Postfix) with ESMTPA id E4C0ED60057; Sun, 13 Oct 2019 18:12:29 -0400 (EDT) Date: Sun, 13 Oct 2019 22:11:59 +0000 (UTC) From: David Wilson To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Message-ID: <146CCE75D21B3446.d994f6e3-509c-4a25-8cab-f9a20bc806d6@mail.outlook.com> In-Reply-To: <875zks8fz6.fsf@gnu.org> References: <5e3cd1fc-bb34-48cc-9f28-24bcec0333c9@www.fastmail.com> <875zks8fz6.fsf@gnu.org> Subject: Re: [bug#37701] [PATCH] gnu: Add playerctl. MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_9193_1434239559.1571004719323" X-Mailer: Outlook for iOS and Android X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37701-done X-Mailman-Approved-At: Mon, 14 Oct 2019 01:37:30 -0400 Cc: 37701-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ------=_Part_9193_1434239559.1571004719323 Content-Type: multipart/related; boundary="----=_Part_9191_825516628.1571004719322" ------=_Part_9191_825516628.1571004719322 Content-Type: multipart/alternative; boundary="----=_Part_9192_2089077627.1571004719322" ------=_Part_9192_2089077627.1571004719322 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks so much Ludo! I wasn't sure about whether the license included futur= e versions, will keep an eye on the file headers in the future.=C2=A0 David On Sun, Oct 13, 2019 at 2:59 PM -0700, "Ludovic Court=C3=A8s" wrote: Hi David, "David Wilson" skribis: > This patch adds the 'playerctl' command line utility for controlling medi= a players that support MPRIS. As this is my first attempt at packaging sof= tware for Guix, please let me know if anything can be improved. I've run t= hrough most of the steps in the packaging checklist of the manual so I feel= pretty confident that it's in good shape. > > Also, this is my first contribution to a GNU project (!!) so please advis= e if I need to follow any "new contributor" protocol. Looks like you followed the protocol perfectly well! :-) > From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001 > From: David Wilson=20 > Date: Thu, 10 Oct 2019 22:06:43 -0700 > Subject: [PATCH] gnu: Add playerctl. > > * gnu/packages/music.scm (playerctl): New variable. Applied with the minor changes below: the =E2=80=98file-name=E2=80=99 issue= was reported by =E2=80=98guix lint=E2=80=99, and the license is LGPLv3-or-later because = source file headers carry the =E2=80=9Cor any later version=E2=80=9D wording. Thank you! Ludo=E2=80=99. ------=_Part_9192_2089077627.1571004719322 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks so much Ludo! I wasn't sure about whether the lic= ense included future versions, will keep an eye on the file headers in the = future. 

David




On Sun, Oct 13, 2019 at 2:59 PM -0700, "Ludovic = Court=C3=A8s" <ludo@gnu.org> wrote:

Hi David,

"David Wilson"  skribis:

> This patch adds the 'playerctl' command line utility for controlling m=
edia players that support MPRIS.  As this is my first attempt at packaging =
software for Guix, please let me know if anything can be improved.  I've ru=
n through most of the steps in the packaging checklist of the manual so I f=
eel pretty confident that it's in good shape.
>
> Also, this is my first contribution to a GNU project (!!) so please ad=
vise if I need to follow any "new contributor" protocol.

Looks like you followed the protocol perfectly well!  :-)

> From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001
> From: David Wilson 
> Date: Thu, 10 Oct 2019 22:06:43 -0700
> Subject: [PATCH] gnu: Add playerctl.
>
> * gnu/packages/music.scm (playerctl): New variable.

Applied with the minor changes below: the =E2=80=98file-name=E2=80=99 issue=
 was reported
by =E2=80=98guix lint=E2=80=99, and the license is LGPLv3-or-later because =
source file
headers carry the =E2=80=9Cor any later version=E2=80=9D wording.

Thank you!

Ludo=E2=80=99.

------=_Part_9192_2089077627.1571004719322-- ------=_Part_9191_825516628.1571004719322 Content-Type: TEXT/X-PATCH; charset=us-ascii; name=2_TEXT_X-PATCH Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename=2_TEXT_X-PATCH diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index dcda71a43d..a051caca2b 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) @@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config))) - (synopsis "Controls MPRIS-supporting media player applications") + (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl @@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") - (license license:lgpl3))) + (license license:lgpl3+))) ------=_Part_9191_825516628.1571004719322-- ------=_Part_9193_1434239559.1571004719323 Content-Type: TEXT/X-PATCH; charset=us-ascii; name=2_TEXT_X-PATCH Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=2_TEXT_X-PATCH diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index dcda71a43d..a051caca2b 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) @@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config))) - (synopsis "Controls MPRIS-supporting media player applications") + (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl @@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") - (license license:lgpl3))) + (license license:lgpl3+))) ------=_Part_9193_1434239559.1571004719323--