From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 11:33:06 2019 Received: (at submit) by debbugs.gnu.org; 17 Oct 2019 15:33:06 +0000 Received: from localhost ([127.0.0.1]:48732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL7lx-00088f-Uu for submit@debbugs.gnu.org; Thu, 17 Oct 2019 11:33:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:42923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL7lw-00088Y-HG for submit@debbugs.gnu.org; Thu, 17 Oct 2019 11:33:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58334) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL7lv-0007d8-4f for guix-patches@gnu.org; Thu, 17 Oct 2019 11:33:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL7lu-0003nF-8B for guix-patches@gnu.org; Thu, 17 Oct 2019 11:33:03 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:37270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iL7lu-0003mp-2O for guix-patches@gnu.org; Thu, 17 Oct 2019 11:33:02 -0400 Received: by mail-wr1-x443.google.com with SMTP id p14so2882318wro.4 for ; Thu, 17 Oct 2019 08:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=XgAiVt2IrrB3+mtzlP0q0uCRJjwkBhPjIEgq9kon8Hw=; b=eHmRABiobjcu0amX1hGP9rkCeCyWtXc7UX9CTamXHooCCMgeXCXbnKkLc8dW+tQnnz 23yulJFMSZBvQCNebwa74+Y5wWvQgzI6C3WCb9awMW62EJBrtNNcTdLUs5vP2t1iuU9q eiaPx1jDayw4C57/RQ1EA4byUlqkuEzULDtgl5Gqk9uqR1q6zh3dfZthB9bRKZvxtGis stcSFjiIkmbf45XSw/wblt7Rrio7HVLRO+bRop53TPaQAOPbSznQxR7uWkqjjaX+m2ex ePBwFbMI3455B2PYbyW5bIWmMWP/MBJkOP4hf4i5+KX82z/qUAUwajVr4642p36tXADT izSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=XgAiVt2IrrB3+mtzlP0q0uCRJjwkBhPjIEgq9kon8Hw=; b=W9TV6+1CVbq3scnmbQGVPeIlrQ1FPkRyACmK+JKEX2tek9m3kxvNQQiRyzz8UmMOCU XJKiEnKntevhrA5w/4MW3y/7DzJ3afohWBFdctbZ31gtme56o1gpQHWV9y/WR0XKN8uh sl9bgMHPmd9C0nwR9UeNBdgD2aEuTjpa5H0vBpSCePqp7NQqC0E5aQHA4hANEWsyTlKm MlgQoIEBb749qeULc93tQ6z+Z7a4l05NGdiCghLidM7AptvtqVGrNX6pnvj1fyZnX/aG zfeGcCwT7HTSrauuHBqJ6xOFWHifYZoehZCU8JFBwpyvHVj1ZoeYrYTUrNwDwW+KXhNi YUZw== X-Gm-Message-State: APjAAAUUUXuzs0SZ7hXmHZnTAFKKFI69OGn3lbqCLC6gVHNlqHQEUDU4 iubSeJvOKowVx80k2jKSF6F3ZoZV X-Google-Smtp-Source: APXvYqw9oMkFKLsYmL5SaYJmcMwBoXaV1daCk+gQjTy5JYQjAU6X8Fk2P0cc4l6WONalRz9b0GKG1w== X-Received: by 2002:adf:f685:: with SMTP id v5mr669933wrp.246.1571326380577; Thu, 17 Oct 2019 08:33:00 -0700 (PDT) Received: from PF1S5GG2 (lfbn-ann-1-367-71.w86-200.abo.wanadoo.fr. [86.200.83.71]) by smtp.gmail.com with ESMTPSA id e17sm2564168wma.15.2019.10.17.08.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 08:32:59 -0700 (PDT) References: <20191017080233.dcsjsyh5ui6x67kj@rafflesia> <20191017080954.rxj4m7dmelakx7zv@rafflesia> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: guix-patches@gnu.org Subject: Re: [bug#37788] [PATCH] gnu: Add minisign. In-reply-to: <20191017080954.rxj4m7dmelakx7zv@rafflesia> Date: Thu, 17 Oct 2019 17:32:58 +0200 Message-ID: <874l07gzf9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 37788@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello Tanguy, > Remove new blank line at EOF. Please pass --subject-prefix="PATCH v2" to git format-patch so that it is easier to identify patch revisions. > + ; No test suite You can put it on the same line as the one below. > + `(#:tests? #f)) You also did forget to add the Copyright on top. Otherwise seems fine :). I fixed the points above and pushed it. Mathieu