From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 03 12:12:00 2019 Received: (at 37825) by debbugs.gnu.org; 3 Nov 2019 17:12:00 +0000 Received: from localhost ([127.0.0.1]:35039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRJPz-0004dD-Ti for submit@debbugs.gnu.org; Sun, 03 Nov 2019 12:12:00 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRJPy-0004cz-IY for 37825@debbugs.gnu.org; Sun, 03 Nov 2019 12:11:59 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7B183202F2; Sun, 3 Nov 2019 12:11:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 03 Nov 2019 12:11:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=G8H9DW8jdjJz8lFf4UX2fS6FRT OUVEK6OGG6dRMw2xM=; b=oQJDLTc6Cn6y3P5IcvGsQ4nYQjZFqFBv9oOMFFp8m1 e1fpUPKXWIwfvpFNAVe54tAH2Z1Uvip/dkvZSWl//Pm7BOvgTr8KgyOWsbGIs8Tq HqV27aAjOlBo2uYQUbCWm7Q55jxkrfYe68IM5umu7u8JBKtjr/Tw5ZA5WoytK/8q CaOMtwTygO+p/Z4QtSu7k/+j7Jgt8d4hPoE2biC/8gjb3G4trB0kLDPBqzPgPLZ9 TWjtslK0WjI5cKqETAASTc7HPBvEAJLTKyWuUVSPk7gYXcTdpmetTQGAOHuhzX0c cSZrYnHJDvQOZ/g9pjDNZ3uUBHr30hi+vdGKvS8lXL7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=G8H9DW 8jdjJz8lFf4UX2fS6FRTOUVEK6OGG6dRMw2xM=; b=IGN831JusqxeGcprO4KP5v 1STaSrI+vRWUnph7NKMSdj55hrF2eN1TIoP+jkZeDLvZynyRDM9yUlRXr1ij6nq/ TabZN2sz9wWpPXvg122WSRl4V5Mb5tY26zuxpotanog2znjH1XfsClBF993uITao 5kw5l00wMoIfYUEwKJogPc9V0g9low3bs759P4htm9goblt/WMUyWoVMOPg8ZwUH JfgtngIeESiqE0LCIKvheclR3Xy67oZINtWQ3cjK4M4xjdtEHnFr/s28qQCBQ/Ua NH2trfw2CGH0sY5ERRtfocP0A3whStVDui6DL9Ehu/yVWScvao/qUwDPjUAOqdkA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudduuddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtd erredtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgr shhtmhgrihhlrdgtohhmqeenucfkphepiedvrdduiedrudelvddrudehtdenucfrrghrrg hmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomhenucevlhhu shhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (ti0006q161-0149.bb.online.no [62.16.192.150]) by mail.messagingengine.com (Postfix) with ESMTPA id 6FDDC80060; Sun, 3 Nov 2019 12:11:52 -0500 (EST) From: Marius Bakke To: Guillaume Le Vaillant Subject: Re: [bug#37825] [PATCH] gnu: bitcoin-abc: Update to 0.20.4. In-Reply-To: <87tv7nlx1q.fsf@yamatai> References: <20191019184837.21457-1-glv@posteo.net> <87tv7oo5xa.fsf@devup.no> <87tv7nlx1q.fsf@yamatai> User-Agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sun, 03 Nov 2019 18:11:50 +0100 Message-ID: <87r22oopex.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 37825 Cc: 37825@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Guillaume Le Vaillant writes: > Marius Bakke skribis: > >> Guillaume Le Vaillant writes: >> >>> * gnu/packages/finance.scm (bitcoin-abc): Update to 0.20.4. >>> [source]: Fix uri. >>> [inputs]: Use bdb-5.3 (bdb-4.8 is not supported). >>> [arguments]: Add 'fix-tests' phase. >> >> [...] >> >>> + (arguments >>> + (substitute-keyword-arguments (package-arguments bitcoin-core) >>> + ((#:phases phases) >>> + `(modify-phases ,phases >>> + (add-after 'unpack 'fix-tests >>> + ;; Disable 'check-devtools' test which tries to run a >>> + ;; python script that doesn't exist. >>> + (lambda _ >>> + (substitute* "Makefile.in" >>> + (("^check-local: check-devtools") >>> + "check-local:")) >>> + #t)))))) >> >> Do you know why this script is not distributed? Should we provide it, >> or was it a packaging mistake upstream? >> >> In any case I pushed this patch in >> 28d46d9d4317180b348ad5baeddad8ef25ed430a. Thank you! > > I'm not sure if it's a packaging mistake or a makefile mistake (if these > tests are not supposed to be run on a release version). They are tests > to check that some development tools work correctly (e.g. tools to > generate a header file which is included in the release tarball, to > update the copyright years in the headers, etc). I see, thanks for the explanation. Perhaps we are simply using the wrong Makefile target? By default gnu-build-system runs 'make check' in the 'check' phase: some packages use 'make test' or 'make ci' instead. Something to look out for in the next version. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl2/ClcACgkQoqBt8qM6 VPqtgwf+O/bNWF7RWcvTbZWX7XBbC9njVW+JcMv5fcqkoLD4GwTSSIdgvmCBYdQr tYUTz3EY2W4C0EjosTD79kUe0Wn+13sXvLzYfttbIimOlNxRwROYUbBpKQlHwh7O dOBI1F5YB9TjeFZmLsrtRCGXKX81bYMrjqTBtlq9q0oV3+cObTpN4lNUb0b6YSLZ yaSNVuJUd9nYTPyPAGy09GlYryivvdyPEC6IZt76M6H4mylS03ZPj9pXCtZI3cvZ IDwNDhHDuJqnjztnQG796yQDaMei0D1s4s2u0lVThJrx5yAkZP5FORX40M5h5mgn 8HtU6rKzNfK3c9o83V5bQUCZ+882gA== =oihI -----END PGP SIGNATURE----- --=-=-=--