From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 17:46:05 2019 Received: (at 38115) by debbugs.gnu.org; 10 Nov 2019 22:46:05 +0000 Received: from localhost ([127.0.0.1]:52839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTvy8-0008BE-Pb for submit@debbugs.gnu.org; Sun, 10 Nov 2019 17:46:05 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:36055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTvy6-0008AZ-BC for 38115@debbugs.gnu.org; Sun, 10 Nov 2019 17:46:03 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 80118429; Sun, 10 Nov 2019 17:45:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 10 Nov 2019 17:45:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=mdj/kV858fxRepMwj4jGaAH0pu YPRajZAry9byB9R24=; b=V9ncLTh4wX9raYzLcdZFMei7cdtdDEwuxTRxP/1b9+ jW874TTnGAnWe/dDudzGYYz8Q4bE8RgLM+TXeHJ3ecNrJLw4+nbQGoqUIIpYrn9A aKLYR97LnHLBNZrFKPXhs6Ue8DDy1wbMmMFHwohhmsphv4vwQL2hGJWF01Tzuieo rCHkZXtCdVJYLTlgygMkH5GyMvyrH5pGFXfpanxmEwxrqXcqktzQKVDtNJsfiT7I vPJRUeZnYGlH4d+so4/1ZmTqyEHiwY5MLMSWGQ/ewhZdz4YZuuaZ0qU+0LKXAUzT MScsiNH1xnN6f1YWiAo3+bRjN27ethoiIlRaL9sdvrUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=mdj/kV 858fxRepMwj4jGaAH0puYPRajZAry9byB9R24=; b=pjoODDGQEmtdt7c+eyhfhe CFlxn6IjsY37ss+T4Aoe1uA4pthpXrw/ZRJfkZIVn/bOyAOCoUiRu7pFqDpMXot3 X6gbzPqN9xwgYaTjpkRTYmEWVS2XSdJWIqkRQ4BFQLXsg2V1F4PrzAm1iwAP7Zjq UscOpG83yWUpH9mXjiVMgp5n7O39hyOdnCZ85QcaVvWrc3JGlX1F2eepQD6u0W3M yYkDTT+Ll67+h14S2CD7zfXwsDCpwdIWCkMMRYU6Zzafcgv+5Z2F+RdtT3V3Wros QlRyiERGYH9iU4zMZa37TiTMrzMrAlnbKcLEQUaQ2H7Ft6Nwar35YY+ZQr411eCQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddviedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehgtderredtredtnecuhfhrohhmpeforghrihhu shcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmqeenucfkphepke egrdehvddrvddviedruddtvdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgv sehfrghsthhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (84-52-226.102.3p.ntebredband.no [84.52.226.102]) by mail.messagingengine.com (Postfix) with ESMTPA id 8EBB0306005B; Sun, 10 Nov 2019 17:45:55 -0500 (EST) From: Marius Bakke To: Alexandros Theodotou , 38115@debbugs.gnu.org Subject: Re: [bug#38115] [PATCH] gnu: Add dpf-plugins. In-Reply-To: References: User-Agent: Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sun, 10 Nov 2019 23:45:54 +0100 Message-ID: <87k187jqot.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38115 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alexandros Theodotou writes: > From aebc4cded75e51f6c453a52cae10c9224d9e7df9 Mon Sep 17 00:00:00 2001 > From: Alexandros Theodotou > Date: Fri, 8 Nov 2019 08:55:22 +0000 > Subject: [PATCH] gnu: Add dpf-plugins. > > * gnu/packages/music.scm: (dpf-plugins): New variable. [...] > + (arguments > + `(#:tests? #f ; no "check" target > + #:make-flags > + (list (string-append "PREFIX=3D" (assoc-ref %outputs "out"))) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'skip-dssi-binaries > + (lambda _ > + (substitute* "Makefile" > + (("cp -r bin.*-dssi.*$") ":;\n")) > + #t)) Can you expand on this comment? What are these binaries, and why do we need to prevent them from being installed? > + (license `(license:isc license:gpl3 license:lgpl3 license:mit=20 > license:gpl2)))) Does this work? I would expect each of the license entries to have to be 'unquoted', i.e. `(,license:isc). Alternatively you can use (list ...) here. When a package has multiple licenses like here, please add a comment about it. Is there a "main" license, (roughly) which files are under what license? Apart from that LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3IkyIACgkQoqBt8qM6 VPr2ggf/eCZ2tAyyyKkDgKZKujtJ4NcsYSeJuoZ9cmjTBZw7rq6GGotC9xg/rNDU dNAkyF4DcNp0SCkLN10elaXgqWoZE+qSxNLkUoNmF6JP07rLUrILFrP0WZ5crWlf 1zWGXA9gG2ekF/KEJjA96uVy1BRWfYoPo0f50mo6zqieL/ZdDAanifFypTPAvBxB md8kFiF1cWLCzbyvtqvv4qJGAJnJPaLHiGEyJ8AQv4jRwDdR/phFatFL3rdhTfrQ WuuctU9Dr4hbnKw7iri3JbkK7ix609/us6b0YFC0tOwrCAAtehPPVEjEYxY5Jtya U+r/2RD72Rq1yYLxHFoojDMJQhxVJA== =olNE -----END PGP SIGNATURE----- --=-=-=--