From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 20:53:17 2019 Received: (at 38127) by debbugs.gnu.org; 11 Nov 2019 01:53:17 +0000 Received: from localhost ([127.0.0.1]:52899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTytJ-0004EJ-AZ for submit@debbugs.gnu.org; Sun, 10 Nov 2019 20:53:17 -0500 Received: from mout02.posteo.de ([185.67.36.142]:41433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTytE-0004E2-VV for 38127@debbugs.gnu.org; Sun, 10 Nov 2019 20:53:16 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 818E22400FB for <38127@debbugs.gnu.org>; Mon, 11 Nov 2019 02:53:06 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47BDRP1cg1z9rxH; Mon, 11 Nov 2019 02:53:04 +0100 (CET) Message-ID: Subject: Re: [bug#38127] [PATCH] gnu: Add x42-plugins. From: Alexandros Theodotou To: Marius Bakke , 38127@debbugs.gnu.org Date: Mon, 11 Nov 2019 01:53:02 +0000 In-Reply-To: <87a793l7do.fsf@devup.no> References: <452ecadc3842a20e4e6c768649855525@posteo.net> <87a793l7do.fsf@devup.no> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-moxqAm/i+6xnMj1umLvF" User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38127 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-moxqAm/i+6xnMj1umLvF Content-Type: multipart/mixed; boundary="=-Y89NcXDjanQJcKkwubn5" --=-Y89NcXDjanQJcKkwubn5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the pointers! > The patch LGTM overall, but indentation seems to be off. Can you run > this through "./etc/indent-code.el"? That script gives me weird indentation that I don't see in any packages, like: (define-public dpf-plugins (package (name ^ missing space Hopefully the updated patch looks better, I tried to match the other packages in music.scm. > > +audio and MIDI plugins that can also run as standalone JACK=20 > > applications.") > > + (home-page "https://x42-plugins.com/x42/") > > + (license license:gpl2+))) >=20 > I notice in the FAQ that "Some binaries are provided as demo. A > license/signature file is required to remove the evaluation > restrictions". >=20 > If there are such binaries in the source tarball, they must be > removed > with a source 'snippet' to ensure 'guix build --source' contains only > free software. This tarball only contains sources and is specifically targeted at distro packagers (see https://github.com/x42/x42-plugins). I believe the binaries are provided as separate downloads on the website. --=-Y89NcXDjanQJcKkwubn5 Content-Disposition: attachment; filename="0001-gnu-Add-x42-plugins.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-gnu-Add-x42-plugins.patch"; charset="UTF-8" RnJvbSAwNWZmYzk0YzgzNGY5OWIzY2I1NmE5ZWJjOTcwOTY5NThhMDc5ODFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kcm9zIFRoZW9kb3RvdSA8YWxleEB6cnl0aG0ub3Jn PgpEYXRlOiBGcmksIDggTm92IDIwMTkgMTA6NTQ6MDAgKzAwMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IEFkZCB4NDItcGx1Z2lucy4KCiogZ251L3BhY2thZ2VzL211c2ljLnNjbTogKHg0Mi1wbHVn aW5zKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9tdXNpYy5zY20gfCA1NSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1 NSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL211c2ljLnNjbSBiL2du dS9wYWNrYWdlcy9tdXNpYy5zY20KaW5kZXggMmYwMjM2ODVkZi4uNWVmZGFlMzFlNCAxMDA2NDQK LS0tIGEvZ251L3BhY2thZ2VzL211c2ljLnNjbQorKysgYi9nbnUvcGFja2FnZXMvbXVzaWMuc2Nt CkBAIC00NzM3LDMgKzQ3MzcsNTggQEAgZm9yIGludGVncmF0aW9uIGludG8gc3RhdHVzIGxpbmUg Z2VuZXJhdG9ycyBvciBvdGhlciBjb21tYW5kLWxpbmUgdG9vbHMuIikKIGVmZmVjdHMuICBJdCBj b250YWlucyBhIGJpdGNydXNoZXIsIGRlbGF5LCBkaXN0b3J0aW9uLCBlcXVhbGl6ZXIsIGNvbXBy ZXNzb3IsCiBhbmQgcmV2ZXJiLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwyKykpKQorCiso ZGVmaW5lLXB1YmxpYyB4NDItcGx1Z2lucworICAocGFja2FnZQorICAgIChuYW1lICJ4NDItcGx1 Z2lucyIpCisgICAgKHZlcnNpb24gIjIwMTkxMDEzIikKKyAgICAoc291cmNlCisgICAgICAob3Jp Z2luCisgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAodXJpCisgICAgICAgICAg KHN0cmluZy1hcHBlbmQgImh0dHA6Ly9nYXJldXMub3JnL21pc2MveDQyLXBsdWdpbnMveDQyLXBs dWdpbnMtIgorICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi50YXIueHoiKSkKKyAg ICAgICAgKHNoYTI1NgorICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICIxOGtuMWJtYzBz NmRwODM0a2M1MWliaWZ6em4zYnh3eWE0cDhzOHlxOWY0bXBta2doaTI0IikpKSkKKyAgICAoYnVp bGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICBgKCM6dGVz dHM/ICNmICA7IG5vICJjaGVjayIgdGFyZ2V0CisgICAgICAgIzptYWtlLWZsYWdzCisgICAgICAg KGxpc3QgKHN0cmluZy1hcHBlbmQgIlBSRUZJWD0iIChhc3NvYy1yZWYgJW91dHB1dHMgIm91dCIp KQorICAgICAgICAgICAgICJMSUJaSVRBQ09OVk9MVkVSPS1seml0YS1jb252b2x2ZXIiCisgICAg ICAgICAgICAgKHN0cmluZy1hcHBlbmQgIkZPTlRGSUxFPSIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoYXNzb2MtcmVmICVidWlsZC1pbnB1dHMgImZvbnQtZGVqYXZ1IikKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiL3NoYXJlL2ZvbnRzL3RydWV0eXBlL0RlamFWdVNhbnMtQm9s ZC50dGYiKSkKKyAgICAgICAjOnBoYXNlcworICAgICAgIChtb2RpZnktcGhhc2VzICVzdGFuZGFy ZC1waGFzZXMKKyAgICAgICAgIChhZGQtYmVmb3JlICdidWlsZCAnc2V0LUNDLXZhcmlhYmxlCisg ICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgIChzZXRlbnYgIkNDIiAiZ2NjIikKKyAg ICAgICAgICAgICAjdCkpCisgICAgICAgICAoZGVsZXRlICdjb25maWd1cmUpKSkpCisgICAgKGlu cHV0cworICAgICBgKCgiY2Fpcm8iICxjYWlybykKKyAgICAgICAoImZmdHdmIiAsZmZ0d2YpCisg ICAgICAgKCJqYWNrIiAsamFjay0xKQorICAgICAgICgiZmZ0dyIgLGZmdHcpCisgICAgICAgKCJm dGdsIiAsZnRnbCkKKyAgICAgICAoImdsaWIiICxnbGliKQorICAgICAgICgiZ2x1IiAsZ2x1KQor ICAgICAgICgiaGljb2xvci1pY29uLXRoZW1lIiAsaGljb2xvci1pY29uLXRoZW1lKQorICAgICAg ICgibGlic2FtcGxlcmF0ZSIgLGxpYnNhbXBsZXJhdGUpCisgICAgICAgKCJsaWJ4MTEiICxsaWJ4 MTEpCisgICAgICAgKCJsaWJsdGMiICxsaWJsdGMpCisgICAgICAgKCJwYW5nbyIgLHBhbmdvKQor ICAgICAgICgieml0YS1jb252b2x2ZXIiICx6aXRhLWNvbnZvbHZlcikpKQorICAgIChuYXRpdmUt aW5wdXRzCisgICAgIGAoKCJoZWxwMm1hbiIgLGhlbHAybWFuKQorICAgICAgICgibGlibG8iICxs aWJsbykKKyAgICAgICAoImx2MiIgLGx2MikKKyAgICAgICAoImZvbnQtZGVqYXZ1IiAsZm9udC1k ZWphdnUpCisgICAgICAgKCJwa2ctY29uZmlnIiAscGtnLWNvbmZpZykpKQorICAgIChzeW5vcHNp cyAiQ29sbGVjdGlvbiBvZiBMVjIvSkFDSyBhdWRpby9NSURJIHByb2Nlc3NpbmcgcGx1Z2lucyIp CisgICAgKGRlc2NyaXB0aW9uICJ4NDItcGx1Z2lucyBpcyBhIGNvbGxlY3Rpb24gb2Ygb3ZlciA4 MCBjcm9zcy1wbGF0Zm9ybSBMVjIKK2F1ZGlvIGFuZCBNSURJIHBsdWdpbnMgdGhhdCBjYW4gYWxz byBydW4gYXMgc3RhbmRhbG9uZSBKQUNLIGFwcGxpY2F0aW9ucy4iKQorICAgIChob21lLXBhZ2Ug Imh0dHBzOi8veDQyLXBsdWdpbnMuY29tL3g0Mi8iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3Bs MispKSkKLS0gCjIuMjQuMAoK --=-Y89NcXDjanQJcKkwubn5-- --=-moxqAm/i+6xnMj1umLvF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl3Ivv4ACgkQAi6uQjE9 cPMiTQgApRWNAGTZz5Jf8nkZj6kR1WdzaBL66/lU3zZuTEd0LrRn5+jZzr4+pnsy bLpuJHfuF8B4wVNi/PQHFbrk6mRfRmIPBSS9hl3I5y+k72AfBY/2g+oYh9DDpjt7 aUkMDx1Npt9bIgvnwe2x3RB53JpJPe0a5ks3hCGagRmjb++uhl0J0OmTKI7EGFdv 85FzNKGu5/CaV8mdasokCE/XYVVFE5UfhDSFjzCqWqQXHWjNgWZmNyYQHEbs5qXy i66PTQYZUQOv3N8ZUo+U+RQNFbFfrYq4Y8K90gXv/rxa9S7G0U7ld+3a+9awObtg Gq9fJWPlNsZ7V1g/S88GIk3er/OV/g== =TYOA -----END PGP SIGNATURE----- --=-moxqAm/i+6xnMj1umLvF--