From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 25 17:54:36 2020 Received: (at 40227-done) by debbugs.gnu.org; 25 Mar 2020 21:54:36 +0000 Received: from localhost ([127.0.0.1]:57918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHDyt-0001Gr-Qg for submit@debbugs.gnu.org; Wed, 25 Mar 2020 17:54:35 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHDys-0001Ga-LT for 40227-done@debbugs.gnu.org; Wed, 25 Mar 2020 17:54:35 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3C1605C0156; Wed, 25 Mar 2020 17:54:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 25 Mar 2020 17:54:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=1n81DfIhCud61kqHhdSeaMhT 4GdhtrM8rPNy0Cf+beM=; b=sZKxHHiK82NPoytH59ZvZU7lvIlptMqQJfa+2ODu pFRTYgrj7fLp3VND5yn2MPpebbGr7eS+elWvPoLgZCEr41Wt47dpVSsWr6RsYBZU Vi2u2hS7OHa0bYrMeWzV0avLKZImWN7ohXnGvxW5A2wDOTOZanRTrKIZHfgJeCsp MIs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=1n81Df IhCud61kqHhdSeaMhT4GdhtrM8rPNy0Cf+beM=; b=iGten/ehWLNHUjrSfi6e6I bmKb50xS9D4xOiRuBoNhi0EeNMXMY4h5pUbR+PorrIYOqeOmDPuePAq+ev8nMx2i moZ/VYuKW9Fwju80POD2okMl8TQj4jzv0PonQxvcT9MCSmOhPzdI19Fr2i7+DhoU Njjla9W8PJRxCW5qs+iE7q49YwiszMmyauA8AE5ka9LyzWaMi2gFSItZ7m7wRprh 0Bm1NzQNrBPY4TcOR69XFkuHcTFSnut5MUa7bymhPZ2Rml8+EkxkSbQH9j6DriZn gJ71ztvX1UM8yuI9khIHW2frRwNKZztNplwS8WCGsYQZ+pgPNqIHU4hOhPP8j+zA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehgedguddvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecukfhppeejie druddvgedrudefkedrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-76-124-138-63.hsd1.pa.comcast.net [76.124.138.63]) by mail.messagingengine.com (Postfix) with ESMTPA id ED3BA3067191; Wed, 25 Mar 2020 17:54:28 -0400 (EDT) Date: Wed, 25 Mar 2020 17:54:27 -0400 From: Leo Famulari To: Marius Bakke Subject: Re: [bug#40227] [PATCH] gnu: icu4c: Fix CVE-2020-10531. Message-ID: <20200325215427.GA29579@jasmine.lan> References: <87v9msyyii.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <87v9msyyii.fsf@devup.no> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40227-done Cc: 40227-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 25, 2020 at 09:23:33PM +0100, Marius Bakke wrote: > I'm not sure if the new test case as well as this git commit header is > necessary. IMO it mostly adds noise to the patch. I.e. the whole file > could be shortened to 6 lines + your comments at the top. >=20 > But no strong opinion, there is an argument to be made for preserving > upstream commits in their entirety too (I think). >=20 > So, LGTM either way. Thank you! I commented out the changes to the test suite and pushed as 7d57a190f6896c04b5dad66bf4360bc48a4052ff. Thanks for the review! --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl570xMACgkQJkb6MLrK fwjB7RAAgIPq4a6n6FB4Gu76PpFDAOvGoCsQlLviPSVeP43OkkgvpR/g2GjlLLSt HZDKLYeec1uOAZj9fuGz+aJzRIclrLTdWls8THXXXF/L5FXUhoBWQubSvj54/yiu o5R9K1/w5pvnHE1gSwGZJGRB8aFH+hcZxMqtnpk7J+XkbQik12PxlNjAh7iubbp5 d/9IDNxdnjoDCH94w3VbSEPTSY+iKSCLLh1bsD8jVL4F2/u3ocO051x+D2NGexMT 0ftnLIU5HQ/PFpWS1hcHXW0MXWn1/hU1yBvjDKksYfwVfV8fM/7a2LeB3qeva63/ K/e17QLnCv5ridxNnO9ndUzSfuHMzaIx3y9en4JrmHQVcPw56flnrbn2BPtmBZN9 AKwWJ//kkYsjcmHjyHOmnbG/LiDCVkfQGc8jt33DLvwFmQuTCiIgvKXJE3UDyyYc PQe0lmhz2/GjkC/fEdwyXSeA10RU8povQCBqeYemzTug1zi0ncveAIziYaTeBLut MMJwehgIvdQdul2ALSRUiLTin+p0bfZhqnHDMVEgyUCZzzx256cecSbzsol3NgE4 nl5dZFxrncZ4RIBOpqdoXF0fM5m+In4YVYlUHNq0D+Z1pogAGlovt2/7pxUYjh4w FvJQEVBnVEVRsobJrfilTBWQnCYHN0d8OciW1Yq2IaIZlgfJCCk= =ab6S -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--