From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 30 15:03:33 2020 Received: (at 40300) by debbugs.gnu.org; 30 Mar 2020 19:03:33 +0000 Received: from localhost ([127.0.0.1]:35074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIzh6-0000iN-WD for submit@debbugs.gnu.org; Mon, 30 Mar 2020 15:03:33 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIzh5-0000i9-By for 40300@debbugs.gnu.org; Mon, 30 Mar 2020 15:03:32 -0400 Received: by mail-pg1-f193.google.com with SMTP id c23so726630pgj.3 for <40300@debbugs.gnu.org>; Mon, 30 Mar 2020 12:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jugQa8B0l6dIsEUo920SlN9d3jxsbRJSd7eNeylq5/w=; b=ZJ3o1U07410blYYyyrkwEo7VptVQpG9qDCEG6HFfXf4+Y+CyexfJ1etyznEQiA2MNe EAmYbf3FTeYyesWrWDJ2nXr7rgtrXj2n6794p7N9wZboT+njA1sdarKmdCkzqpY5dzHL PVaK/zLjexSPEu0a3ICjzK9LTA3qNcJN3X0hG7uthzCSiGBrNsJmTqp3kMzO6X1zTqmq Nepa3IBBOZp+gzkE/hhqjT8wqTp+3uduu3BkWtMP+f2XUnSMfQkhKH+oMRmAMvUeEuH0 9y67T2ROpcWpm48K1j2jhW5hEYSwuWutEseyPoovLVVVOcDN9nqCj7UqgGJK5Zs/8a5H nThg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jugQa8B0l6dIsEUo920SlN9d3jxsbRJSd7eNeylq5/w=; b=YsB70WkaX2dNXzQleSEYOtdqMPa4vcQ5N9ypWYEVw+RheYWyTuOiCky3QBvicDDOVA BYdr0cM1+GjgMh65xMJC8IB0eLNOGMXikXIay6fY/OLoSdjwrUSQfm4l8xGGMGjNwcLz 4BGAZd0o3VVe3WfDot6m/7y3GAx+YKtU2m5MAE9WhYlY7vOwabyRSmG2R+gc40lCCqii v59nV4dKddoDkinNGwdlJ7FTcsvQsXQp4fC+bUyY0mmo45Lh4IH5L6MsJ2I8zu73PJEg N9OCmQfZVNCsz4AhNc03AqEfNNvoGqVWNmcUVHJZM4s4KnFcCTKv/r121GNkVsSsTUcg WDng== X-Gm-Message-State: ANhLgQ0KnkIIR7jqCFu5ALZYGiFwmu8XZQQrO/rgrY6hXaktp7p3aDOF Nz+7IjFhFdhXoEglF8zJE7aAOHWGC9yyuQ== X-Google-Smtp-Source: ADFU+vsfveWf/zu/Iro6NBZbMOLfu4s7NJl20ku1H6uQdQ6tqFaNFvlT9fUVz7rKEqOZ25PiMTzBwQ== X-Received: by 2002:a63:705d:: with SMTP id a29mr11912195pgn.304.1585595005141; Mon, 30 Mar 2020 12:03:25 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::6c3]) by smtp.gmail.com with ESMTPSA id s12sm10205342pgi.38.2020.03.30.12.03.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Mar 2020 12:03:24 -0700 (PDT) From: John Soo To: Nicolas Goaziou Subject: Re: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets. References: <87k1342cl1.fsf@asu.edu> <871rp97ofd.fsf@nicolasgoaziou.fr> <877dz1wxom.fsf@asu.edu> <87sghp6882.fsf@nicolasgoaziou.fr> Date: Mon, 30 Mar 2020 12:03:23 -0700 In-Reply-To: <87sghp6882.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 30 Mar 2020 19:52:29 +0200") Message-ID: <87tv25vf5w.fsf@asu.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40300 Cc: 40300@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Hello, > > John Soo writes: > >> +(define-public emacs-haskell-snippets >> + (package >> + (name "emacs-haskell-snippets") >> + (version "0.1.0") > > Would it make sense to package HEAD instead. I'm looking in particular > at upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5. I think so. Done. >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://github.com/haskell/haskell-snippets") >> + (commit version))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6")))) > > Usual nitpick: please put string on the same line as `base32'. Done. >> + (inputs >> + `(("emacs-yasnippet" ,emacs-yasnippet))) >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-after 'install 'install-snippets >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (snippets >> + (string-append >> + out "/share/emacs/site-lisp/snippets/haskell-mode"))) >> + (mkdir-p snippets) >> + (copy-recursively "snippets/haskell-mode" snippets) >> + #t)))))) >> + (build-system emacs-build-system) > > Nitpick: could you move parts in this order: build-system -> > arguments -> inputs. Yes I can. Done. I also changed inputs -> propagated-inputs. Thanks again, John --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-haskell-snippets.patch Content-Description: add emacs-haskell-snippets. From 1984fc60cc5045c50ae9f913b13ebbc93101f731 Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 24 Mar 2020 07:21:35 -0700 Subject: [PATCH] gnu: Add emacs-haskell-snippets. * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): New variable. --- gnu/packages/emacs-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c029d1ed3d..1d46f540ad 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21965,3 +21965,39 @@ enables modal editing and composition of commands, too. It combines ideas of other Editors like Vim or Kakoune and tries to align them with regular Emacs conventions.") (license license:gpl3+))) + +(define-public emacs-haskell-snippets + (let ((commit "07b0f460b946fd1be26c29652cb0468b47782f3a")) + (package + (name "emacs-haskell-snippets") + (version (git-version "0.1.0" "0" commit)) + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/haskell/haskell-snippets") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0a7y3awi9hcyahggf0ghsdwvsmrhr9yq634wy9lkqjzrm2hqj0ci")))) + (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'install-snippets + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (snippets + (string-append + out "/share/emacs/site-lisp/snippets/haskell-mode"))) + (mkdir-p snippets) + (copy-recursively "snippets/haskell-mode" snippets) + #t)))))) + (propagated-inputs + `(("emacs-yasnippet" ,emacs-yasnippet))) + (home-page "https://github.com/haskell/haskell-snippets") + (synopsis "Official collection of YASnippet Haskell snippets for Emacs") + (description "Haskell-Snippets is a collection of YASnippet Haskell +snippets for Emacs.") + (license license:expat)))) -- 2.26.0 --=-=-=--