From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 01 03:36:28 2020 Received: (at 40364) by debbugs.gnu.org; 1 Apr 2020 07:36:28 +0000 Received: from localhost ([127.0.0.1]:37414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJXvC-00027y-It for submit@debbugs.gnu.org; Wed, 01 Apr 2020 03:36:28 -0400 Received: from mira.cbaines.net ([212.71.252.8]:33762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJXv9-00027c-87 for 40364@debbugs.gnu.org; Wed, 01 Apr 2020 03:36:20 -0400 Received: from localhost (unknown [46.237.163.68]) by mira.cbaines.net (Postfix) with ESMTPSA id CE11627BBE1; Wed, 1 Apr 2020 08:36:17 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b8dc2276; Wed, 1 Apr 2020 07:36:15 +0000 (UTC) References: <20200401040053.9054-1-jackhill@jackhill.us> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: 40364@debbugs.gnu.org, Jack Hill Subject: Re: [bug#40364] [PATCH] gnu: Add gnome-chess In-reply-to: <20200401040053.9054-1-jackhill@jackhill.us> Date: Wed, 01 Apr 2020 08:36:12 +0100 Message-ID: <87d08rac9f.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40364 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jack Hill writes: > * gnu/packages/games.scm (gnome-chess): New variable. > --- > gnu/packages/games.scm | 40 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) Thanks for the patch Jack! > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index e818b851f4..dbc9e899b8 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -49,6 +49,7 @@ > ;;; Copyright =C2=A9 2020 Alberto Eleuterio Flores Guerrero > ;;; Copyright =C2=A9 2020 Naga Malleswari > ;;; Copyright =C2=A9 2020 Vitaliy Shatrov > +;;; Copyright =C2=A9 2020 Jack Hill > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -1095,6 +1096,45 @@ destroying an ancient book using a special wand.") > ;; license. The whole package is released under GPLv3+. > (license license:gpl3+))) > > +(define-public gnome-chess > + (package > + (name "gnome-chess") > + (version "3.36.0") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://gnome/sources/" name "/" > + (version-major+minor version) "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "1a9fgi749gy1f60vbcyrqqkab9vqs42hji70q73k1xx8rv0agmg0"))= )) > + (build-system meson-build-system) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'skip-gtk-update-icon-cache > + ;; Don't create 'icon-theme.cache'. > + (lambda _ > + (substitute* "meson_post_install.py" > + (("gtk-update-icon-cache") "true")) > + #t)))) It would be good to wrap gnome-chess to include it's own share directory in the XDG_DATA_DIRS environment variable. Without that, I can't just run it [1], but when I set that variable correctly [2], it works :) 1: =E2=86=92 /gnu/store/jv8jpq23iic13j7zdl8mdc30vcv508wh-gnome-chess-3.36.0/bi= n/gnome-chess (gnome-chess:10039): GLib-GIO-ERROR **: 08:31:52.482: Settings schema 'org.= gnome.Chess' is not installed Trace/breakpoint trap 2: =E2=86=92 XDG_DATA_DIRS=3D"$XDG_DATA_DIRS:/gnu/store/jv8jpq23iic13j7zdl8mdc= 30vcv508wh-gnome-chess-3.36.0/share" /gnu/store/jv8jpq23iic13j7zdl8mdc30vcv= 508wh-gnome-chess-3.36.0/bin/gnome-chess This wrapping is something that would automatically be done through the glib-or-gtk-build-system, but maybe not automatically through the meson build system. > + (inputs > + `(("gtk+" ,gtk+) > + ("librsvg" ,librsvg))) > + (native-inputs > + `(("gettext" ,gettext-minimal) > + ("glib:bin" ,glib "bin") ; for desktop-file-validate and appstrea= m-util > + ("itstool" ,itstool) > + ("pkg-config" ,pkg-config) > + ("vala" ,vala))) > + (home-page "https://wiki.gnome.org/Apps/Chess") > + (synopsis "Chess board for GNOME") > + (description "GNOME Chess provides a 2D board for playing chess games > +against human or computer players. It supports loading and saving games= in > +Portable Game Notation. To play against a computer, install a chess eng= ine > +such as chess or stockfish.") > + (license license:gpl3+))) > + > (define-public gnubg > (package > (name "gnubg") Apart from the wrapping I mentioned above, this looks good to me :) Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6ERGxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XebnhAAi6jfjYnmQMdiFj+3FzA/LGtztdrIXjSiOWCRra/uiGatBTIQ1sbFc12h Bt0tjAACn77C0kdIVO+MHvqXbHGC3v4mnvSQny373+TTIa8QsLNHRBXdxImI7y2N 3FiEjMOfklHPPTrHQAsGzWrMbw1Xbr1vTx3dD8uv6mzyGt8MxNy8FGy9RG4a3KqU QpCWbBeRaVvERH1O+YZwTUDSHqbJ5TiP+x960INc06HaDN50E2peLOXDE5BjajRR 5QkXYUXDNdMlWdg9o8GMfFjhuFRH8Am1cQFFav+Ubyw/2Gf/apC0cRRxfQIKW8hs NJt3d+fvxBVvUx2r4M/szaQcAJDdEohUqC5nnaocQAb8owhO6bV5DtdvNRJBbsaw 1IF9GzVomEUK0l6LPp1PzHRCT158kbg7DfBnqHGiLJp4UgBx4AqW5/e1y1kd8g4y eVgykmctl4TdATqIDaahCxxz9vsYZFFyRlW+3s/esWe4D23k3hCyX+s9DL2U8/GL kldiEQXLcOzU/o7yHXqHWwkhDSkldxpRqf1fq/JXeNc+Rw72cjpzs9FWFl3xnChW vMtW83pYw4VG5FWi4D9+ByYpFB31r2bPagvOzv/zeF/MvA+YIGh+bLZj9RcFu6uM xRddvtRJKfxDapPLyYH3QQmGarNs4DH4rUt37g725V/dzRlrKVk= =UGxl -----END PGP SIGNATURE----- --=-=-=--