From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 15:11:40 2020 Received: (at 41431) by debbugs.gnu.org; 23 May 2020 19:11:40 +0000 Received: from localhost ([127.0.0.1]:35690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZYU-0000a0-A2 for submit@debbugs.gnu.org; Sat, 23 May 2020 15:11:40 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:35525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZYP-0000Zi-Da for 41431@debbugs.gnu.org; Sat, 23 May 2020 15:11:32 -0400 Date: Sat, 23 May 2020 19:11:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1590261083; bh=veZcTUV2WpUJLL/1M2dHGkJY+Rq6SRxGveW3JqxgaXY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=MVbIoA3qxvTCofo+An+j0ARq14GOBAmmN9rleeiDNc3EC278s4kUjmv7LVeh/QaHo t+8fB30HNDaXBr9Thgv5SyR5vtvBFyBPV5v9Z13vu3AwH+8YGJxovkYDtaRDyXSvCH vCBzrSauCAf1lZyTAIPJs3283OQzGtL2NlYZv/dI= To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= From: Ryan Prior Subject: Re: [bug#41431] [PATCH] gnu: Add protonvpn-cli. Message-ID: In-Reply-To: <87o8qe68hh.fsf@gnu.org> References: <20200521032943.26115-1-rprior@protonmail.com> <87o8qe68hh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_3e227dc87ec24481037db3b50e049c2d" X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41431 Cc: 41431@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ryan Prior Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_3e227dc87ec24481037db3b50e049c2d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Saturday, May 23, 2020 2:17 PM, Ludovic Court=C3=A8s wrot= e: > there are definitely tests What makes you so sure? `grep -r '\Wtest' .` suggests that the only referen= ce to testing in the whole repo is in protonvpn_cli/utils.py (wait_for_netw= ork) which tests for a network connection at runtime. I don't think they ar= e shipping any tests; setup.py can test to make sure you can actually insta= ll your dependencies, but that's not a meaningful upstream test, it's a def= ault behavior. > > - (license license:gpl3))) > > This is =E2=80=98gpl3+=E2=80=99 AFAICS since nothing says =E2=80=9Cversio= n 3 only.=E2=80=9D Nothing says "or any later version" either=E2=80=94I had been under the imp= ression that the "plus" was opt-in, but reading GPLv3 again it appears to b= e opt-out. I don't know, that's not my area of expertise. I've updated the = patch to gpl3+ with your recommendation in any case. > Could you send an updated patch? > > Bonus points if you expound the description a bit. :-) Of course! Here you go. Thanks, Ryan --b1_3e227dc87ec24481037db3b50e049c2d Content-Type: text/x-patch; name="0001-gnu-Add-protonvpn-cli.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-Add-protonvpn-cli.patch RnJvbSBlMjRjYTAwNzczN2FiN2Y2ZTc1NzJjZWUyYjgyNzU3OGZmNDJhMzZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIFByaW9yIDxycHJpb3JAcHJvdG9ubWFpbC5jb20+CkRh dGU6IFdlZCwgMjAgTWF5IDIwMjAgMjI6Mjg6MTEgLTA1MDAKU3ViamVjdDogW1BBVENIXSBnbnU6 IEFkZCBwcm90b252cG4tY2xpLgoKKiBnbnUvcGFja2FnZXMvdnBuLnNjbSAocHJvdG9udnBuLWNs aSk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvdnBuLnNjbSB8IDM2ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDM2IGluc2VydGlv bnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvdnBuLnNjbSBiL2dudS9wYWNrYWdlcy92 cG4uc2NtCmluZGV4IGRhODgxNDkzYmYuLjhmN2ZiM2I1NzcgMTAwNjQ0Ci0tLSBhL2dudS9wYWNr YWdlcy92cG4uc2NtCisrKyBiL2dudS9wYWNrYWdlcy92cG4uc2NtCkBAIC0xMiw2ICsxMiw3IEBA CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTkgUnV0Z2VyIEhlbGxpbmcgPHJoZWxsaW5nQG15a29sYWIu Y29tPgogOzs7IENvcHlyaWdodCDCqSAyMDE5IFJpY2FyZG8gV3VybXVzIDxyZWthZG9AZWxlcGhs eS5uZXQ+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjAgQnJpY2UgV2FlZ2VuZWlyZSA8YnJpY2VAd2Fl Z2VuZWkucmU+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjAgUnlhbiBQcmlvciA8cnByaW9yQHByb3Rv bm1haWwuY29tPgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsK QEAgLTU1LDYgKzU2LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcGtnLWNvbmZp ZykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcHl0aG9uKQogICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyBweXRob24teHl6KQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBw eXRob24td2ViKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB0bHMpCiAgICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIHhtbCkpCiAKQEAgLTMxMSw2ICszMTMsNDAgQEAgc2VjdXJpdHkg cHJvdG9jb2wgdGhhdCB1dGlsaXplcyBTU0wvVExTIGZvciBrZXkgZXhjaGFuZ2UuICBJdCBpcyBj YXBhYmxlIG9mCiB0cmF2ZXJzaW5nIG5ldHdvcmsgYWRkcmVzcyB0cmFuc2xhdG9ycyAoQGRmbntO QVR9cykgYW5kIGZpcmV3YWxscy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMikpKQogCiso ZGVmaW5lLXB1YmxpYyBwcm90b252cG4tY2xpCisgIChwYWNrYWdlCisgICAgKG5hbWUgInByb3Rv bnZwbi1jbGkiKQorICAgICh2ZXJzaW9uICIyLjIuMiIpCisgICAgKHNvdXJjZQorICAgICAob3Jp Z2luCisgICAgICAgOzsgUHlQSSBoYXMgYSAiLndobCIgZmlsZSBidXQgbm90IGEgcHJvcGVyIHNv dXJjZSByZWxlYXNlLgorICAgICAgIDs7IFRodXMsIGZldGNoIGNvZGUgZnJvbSBHaXQuCisgICAg ICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAg ICAgICAgICh1cmwgImh0dHBzOi8vZ2l0aHViLmNvbS9Qcm90b25WUE4vbGludXgtY2xpLmdpdCIp CisgICAgICAgICAgICAgKGNvbW1pdCAoc3RyaW5nLWFwcGVuZCAidiIgdmVyc2lvbikpKSkKKyAg ICAgICAoZmlsZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCisgICAgICAgKHNo YTI1NgorICAgICAgICAoYmFzZTMyCisgICAgICAgICAiMGl4amIwMmtqNHo3OXdobTFpemQ4bXJu MmgwcnA5Y213NGltMXF2cDkzcmFocXhkZDRuOCIpKSkpCisgICAgKGJ1aWxkLXN5c3RlbSBweXRo b24tYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMgJygjOnRlc3RzPyAjZikpIDsgbm8gdGVz dHMgaW4gcmVwbworICAgIChuYXRpdmUtaW5wdXRzCisgICAgIGAoKCJkb2NvcHQiICxweXRob24t ZG9jb3B0KSkpCisgICAgKGlucHV0cworICAgICBgKCgicHl0aG9uZGlhbG9nIiAscHl0aG9uLXB5 dGhvbmRpYWxvZykKKyAgICAgICAoInJlcXVlc3RzIiAscHl0aG9uLXJlcXVlc3RzKSkpCisgICAg KHByb3BhZ2F0ZWQtaW5wdXRzCisgICAgIGAoKCJvcGVudnBuIiAsb3BlbnZwbikpKQorICAgIChz eW5vcHNpcyAiQ29tbWFuZC1saW5lIGNsaWVudCBmb3IgUHJvdG9uVlBOIikKKyAgICAoZGVzY3Jp cHRpb24KKyAgICAgIk9mZmljaWFsIENMSSBmb3IgUHJvdG9uVlBOLCBhIHNlY3VyZSBwb2ludC10 by1wb2ludCB2aXJ0dWFsIHByaXZhdGUKK25ldHdvcmtpbmcgc2VydmljZSB3aXRoIGEgZ3JhdGlz IHRpZXIuICBJdCBjYW4gYXV0b21hdGljYWxseSBmaW5kIGFuZCBjb25uZWN0Cit0byB0aGUgZmFz dGVzdCBzZXJ2ZXJzIG9yIHVzZSBUT1Igb3ZlciBWUE4uICBUaGUgZ3JhdGlzIHRpZXIgb2ZmZXJz IHVubGltaXRlZAorYmFuZHdpZHRoIGZvciB1cCB0byAxMCBkZXZpY2VzLiIpCisgICAgKGhvbWUt cGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL1Byb3RvblZQTi9saW51eC1jbGkiKQorICAgIChsaWNl bnNlIGxpY2Vuc2U6Z3BsMyspKSkKKwogKGRlZmluZS1wdWJsaWMgdGluYwogICAocGFja2FnZQog ICAgIChuYW1lICJ0aW5jIikKLS0gCjIuMjYuMgoK --b1_3e227dc87ec24481037db3b50e049c2d--