From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 13:56:00 2020 Received: (at 41551) by debbugs.gnu.org; 30 May 2020 17:56:00 +0000 Received: from localhost ([127.0.0.1]:59163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf5iC-00027W-1o for submit@debbugs.gnu.org; Sat, 30 May 2020 13:56:00 -0400 Received: from wp224.webpack.hosteurope.de ([80.237.132.231]:56546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf5iA-00027O-TU for 41551@debbugs.gnu.org; Sat, 30 May 2020 13:55:59 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jf5i8-0003SP-KW; Sat, 30 May 2020 19:55:56 +0200 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jf5i8-0000iJ-0j; Sat, 30 May 2020 19:55:56 +0200 From: Michael Rohleder To: Marius Bakke Subject: Re: [bug#41551] [PATCH] gnu: Add emacs-bm. References: <87imgixo1a.fsf@rohleder.de> <87ftbh3alu.fsf@gnu.org> X-PGP-Fingerprint: 755E 2DE5 D0D5 85C5 2E78 2830 7C7A FFBE FEF2 CB25 X-PGP-Key: https://www.rohleder.de/~mike/pgpkey.asc Date: Sat, 30 May 2020 19:55:31 +0200 In-Reply-To: <87ftbh3alu.fsf@gnu.org> (Marius Bakke's message of "Sat, 30 May 2020 13:50:37 +0200") Message-ID: <87o8q5z4rw.fsf@rohleder.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1590861358;f5fd09e0; X-HE-SMSGID: 1jf5i8-0003SP-KW X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41551 Cc: 41551@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hi Marius, you have an impressive pensum! Thanks for the review! Marius Bakke writes: >> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable. > > Thanks! It LGTM but no longer applies, can you rebase it on the current > master branch? done. >> + (synopsis "Visual Bookmarks for Emacs") > ^^^ > Lowercase 'b'. done. >> + (description "This package provides visible, buffer local, bookmarks and >> +the ability to jump forward and backward to the next bookmark.") > > The description reads a bit weird, I wonder if... > > "visible, buffer local bookmarks" (without the second comma) > > ...is more correct? seems more correct, yes => done. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-emacs-bm.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] gnu: Add emacs-bm. From=20b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001 From: Michael Rohleder Date: Sat, 30 May 2020 19:50:02 +0200 Subject: [PATCH] gnu: Add emacs-bm. * gnu/packages/emacs-xyz.scm (emacs-bm): New variable. =2D-- gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 6d82e1921c..9cf4cdd6a1 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1918,6 +1918,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlink= s and doing full-text searches. Unlike code@{emacs-wiki.el}, it can be combined with any format= .") (license license:gpl1+))) =20 +(define-public emacs-bm + (package + (name "emacs-bm") + (version "201905") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/joodland/bm.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn")))) + (build-system emacs-build-system) + (home-page "https://github.com/joodland/bm") + (synopsis "Visual bookmarks for Emacs") + (description "This package provides visible, buffer local bookmarks and +the ability to jump forward and backward to the next bookmark.") + (license license:gpl2+))) + (define-public emacs-calfw (package (name "emacs-calfw") =2D-=20 2.26.2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 In short, I think gcc should be fixed, or at the very least it should be a _documented_ bug at which point I have no gripe with fixing it in the kernel. But I refuse to work around undocumented bugs - that starts to smell too much like microsoft, and then I might as well start using Windows myself.=20 Linus --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl7SnhMACgkQfHr/vv7y yyWXwgf9E6UTdgVjlbf/PRGlHC33Und17h7/7wrNaW2c12zXSedHTb4cZ7vHZS1D C+WHrpfd3b3S71ITy71YXsjdAM02yupNZ2BalzJr34+e78ROKvJfNy7i1OMbbb7z 644FXLciXoZqJPcRLhp6xtPmOTjrZqJq+NFgvJNcac1DlB9BZbIbadyvEIriHiHl CKhCgaYDkBa+0AQyCuF13eiPMvrY8NRqZHyXeVX9t0xODU/cOMEeVuS16ABo/KDc 4w6PVeF9y+O45t5hhzDu7iPa5EeLuYI2rH6UTuNy9gzQj9KjeEQDjsxTjuP90uxw 0VdNs6QkvenSZupeZYFTiBZQcOUXcQ== =0ttF -----END PGP SIGNATURE----- --==-=-=--