From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 05:05:26 2020 Received: (at 41643) by debbugs.gnu.org; 2 Jun 2020 09:05:26 +0000 Received: from localhost ([127.0.0.1]:37883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg2rO-00029v-HZ for submit@debbugs.gnu.org; Tue, 02 Jun 2020 05:05:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg2rN-00029g-7R for 41643@debbugs.gnu.org; Tue, 02 Jun 2020 05:05:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40856) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg2rH-0008T4-H7; Tue, 02 Jun 2020 05:05:19 -0400 Received: from [2a01:e0a:fa:a50:a896:aee9:1571:f8a1] (port=51520 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jg2rF-0005q0-Hi; Tue, 02 Jun 2020 05:05:18 -0400 From: Mathieu Othacehe To: Danny Milosavljevic Subject: Re: [bug#41643] [PATCH] build-system: linux-module: Allow passing #:make-flags argument. References: <20200601125910.12840-1-dannym@scratchpost.org> Date: Tue, 02 Jun 2020 11:05:16 +0200 In-Reply-To: <20200601125910.12840-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Mon, 1 Jun 2020 14:59:10 +0200") Message-ID: <87zh9lx2gj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41643 Cc: 41643@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Danny, > (string-append "INSTALL_PATH=" out) > (string-append "INSTALL_MOD_PATH=" out) > "INSTALL_MOD_STRIP=1" > - "modules_install"))) > + "modules_install" > + (or make-flags '())))) Maybe it would be clearer to have the flags before the make 'target'. Otherwise this looks ok, Thanks, Mathieu