From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 03 03:42:28 2020 Received: (at 42122) by debbugs.gnu.org; 3 Jul 2020 07:42:28 +0000 Received: from localhost ([127.0.0.1]:56340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrGL6-0003Bq-KV for submit@debbugs.gnu.org; Fri, 03 Jul 2020 03:42:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrGL4-0003Be-Dy for 42122@debbugs.gnu.org; Fri, 03 Jul 2020 03:42:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49395) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrGKz-0002bR-5d; Fri, 03 Jul 2020 03:42:21 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=36790 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jrGKy-000796-GG; Fri, 03 Jul 2020 03:42:20 -0400 From: Jan Nieuwenhuizen To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#42122] [PATCH 2/3] services: system-service-type: Add entries support for the Hurd. Organization: AvatarAcademy.nl References: <20200629135817.12784-1-janneke@gnu.org> <20200629135817.12784-2-janneke@gnu.org> <87r1ttpowh.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Fri, 03 Jul 2020 09:42:19 +0200 In-Reply-To: <87r1ttpowh.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 02 Jul 2020 23:50:38 +0200") Message-ID: <877dvl2gf8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42122 Cc: 42122@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s writes: > "Jan (janneke) Nieuwenhuizen" skribis: > >> When creating a disk-image using --save-provenance, "guix system describ= e" >> now works. >> >> * gnu/system.scm (operating-system-directory-base-entries): Add conditio= nal >> "hurd" parameter, make "initrd" parameter conditional. >> (hurd-default-essential-services): Use them. >> (operating-system-boot-parameters-file): Only add 'initrd' when set. > > LGTM! I hadn=E2=80=99t realized there were no =E2=80=98system=E2=80=99 e= ntries. Yeah, I guess they were present once and removed during our cross-build woes to make a smaller patch series. Anyway... >> + (let ((entries (operating-system-directory-base-entries os))) >> + (list (service system-service-type entries) > ^ > One missing space for indentation. :-) Oh! Thanks. Fixed. Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com