From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 09:47:15 2020 Received: (at 43101) by debbugs.gnu.org; 30 Aug 2020 13:47:15 +0000 Received: from localhost ([127.0.0.1]:49663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNfu-0000eg-L2 for submit@debbugs.gnu.org; Sun, 30 Aug 2020 09:47:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCNfr-0000Xd-JY for 43101@debbugs.gnu.org; Sun, 30 Aug 2020 09:47:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39985) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCNfl-0003Dv-OO; Sun, 30 Aug 2020 09:47:05 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41834 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCNfl-0003B7-Bq; Sun, 30 Aug 2020 09:47:05 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: [bug#43101] [PATCH] Add version number in release ISO References: <20200829154445.5512d99a@tachikoma.lepiller.eu> Date: Sun, 30 Aug 2020 15:47:04 +0200 In-Reply-To: <20200829154445.5512d99a@tachikoma.lepiller.eu> (Julien Lepiller's message of "Sat, 29 Aug 2020 15:44:45 +0200") Message-ID: <87d038i6uf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43101 Cc: 43101@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Julien Lepiller skribis: > I've recently proposed a patch to libosinfo database, and they > suggested that we add the version number to the ISO label, so the tool > can differentiate and identify the ISOs. See > https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/202 Good idea. >>From a6d4cb90825b9e45c0baeaeaa653c57a9100b21a Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sat, 29 Aug 2020 15:34:56 +0200 > Subject: [PATCH 1/2] guix: system: Add `--label' option. > > * guix/scripts/system.scm (%options): Add `--label'. Please describe the other changes (to =E2=80=98system-derivation-for-action= =E2=80=99, etc.) > + (partitions (match (image-partitions base-image) > + ((boot others ...) > + (cons > + ((@ (gnu image) partition) > + (inherit boot) > + (label (or label (partition-label boot)))) Please include (gnu image) and avoid =E2=80=98@=E2=80=99. > + (display (G_ " > + --label=3DLABEL for 'disk-image', label disk image with LABEL= ")) Make sure to add it to doc/guix.texi as well. >>From cd47229d93b6dd0d7a793230e6a103a40034f6a7 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sat, 29 Aug 2020 15:36:40 +0200 > Subject: [PATCH 2/2] Makefile.am: Set iso label. > > * Makefile.am (release): Add version number in disk image label. LGTM. Thank you! :-) Ludo=E2=80=99.