From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 18:22:05 2020 Received: (at 44778) by debbugs.gnu.org; 26 Nov 2020 23:22:05 +0000 Received: from localhost ([127.0.0.1]:43217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiQaP-0001Au-Ek for submit@debbugs.gnu.org; Thu, 26 Nov 2020 18:22:05 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:29690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiQaK-0001Aj-OV for 44778@debbugs.gnu.org; Thu, 26 Nov 2020 18:22:00 -0500 Received: from [IPv6:2a01:e0a:2a2:1350:9527:5c74:ee6c:113c] (unknown [IPv6:2a01:e0a:2a2:1350:9527:5c74:ee6c:113c]) (Authenticated sender: dftxbs3e) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 12F2419F57B; Fri, 27 Nov 2020 00:21:49 +0100 (CET) Message-ID: <11a5a9a494b22c5036b6863c6333fdfaa965bbac.camel@free.fr> Subject: Re: [bug#44778] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le. From: dftxbs3e To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Fri, 27 Nov 2020 00:21:49 +0100 In-Reply-To: <87lfenzr5i.fsf@gnu.org> References: <87lfenzr5i.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-2OABAbE4BrT1jPj4g/AG" User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) MIME-Version: 1.0 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 44778 Cc: 44778@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --=-2OABAbE4BrT1jPj4g/AG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Thu, 2020-11-26 at 23:31 +0100, Ludovic Courtès wrote: > Hi, Hello! > dftxbs3e skribis: > > > From e195e9e9fe0409dd4b76cac87244cb2b5d7636e0 Mon Sep 17 00:00:00 > > 2001 > > From: John Doe > > Date: Sat, 21 Nov 2020 17:06:07 +0100 > > Subject: [PATCH] gnu: libffi: Add unreleased patch to fix float128 > > on > >  powerpc64le. > > > > Patch fetched from https://github.com/libffi/libffi/pull/561.patch > > Bonus points for a ChangeLog-style commit message.  :-) >   > https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html > Sorry, it's not clear to me yet what that is yet, will read again. > The patch LGTM, but I vaguely remember seeing similar patches by > Efraim > in a branch (?), or was it for 32-bit PowerPC? > > If there’s no collision with other patches in this area, we can > happily > apply it. > There's no collision, Efraim's patch is and mine is . Efraim's patch is about POWER7 and earlier. There's quite a few PRs relating to PowerPC bugs on libffi: https://github.com/libffi/libffi/pulls?q=is%3Apr+powerpc+is%3Aclosed > Ludo’. Thanks a lot for the review! Attached new patch version, I hope it is better with the commit message now. --=-2OABAbE4BrT1jPj4g/AG Content-Disposition: attachment; filename*0=0001-gnu-libffi-Add-unreleased-patch-to-fix-float128-on-p.pat; filename*1=ch Content-Type: text/x-patch; name="0001-gnu-libffi-Add-unreleased-patch-to-fix-float128-on-p.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA1NjhmZjU3MGI4MDc3YTNjNTY5MTEzOWQ3MjUzMmViYjg3OGYzMDk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2huIERvZSA8ZGZ0eGJzM2VAZnJlZS5mcj4KRGF0ZTogRnJp LCAyNyBOb3YgMjAyMCAwMDoxMjowOCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGdudTogbGliZmZp OiBBZGQgdW5yZWxlYXNlZCBwYXRjaCB0byBmaXggZmxvYXQxMjggb24KIHBvd2VycGM2NGxlLgoK KiBnbnUvcGFja2FnZXMvcGF0Y2hlcy9saWJmZmktZmxvYXQxMjgtcG93ZXJwYzY0bGUucGF0Y2g6 IEltcG9ydCBwYXRjaAogIGZpbGUgZnJvbSA8aHR0cHM6Ly9naXRodWIuY29tL2xpYmZmaS9saWJm ZmkvcHVsbC81NjEucGF0Y2g+LgoqIGdudS9wYWNrYWdlcy9saWJmZmkuc2NtIChsaWJmZmkpW3Bh dGNoZXNdOiBBcHBseSBwYXRjaC4KKiBnbnUvbG9jYWwubWsgKGRpc3RfcGF0Y2hfREFUQSk6IEFk ZCBwYXRjaCBmaWxlIHRvIGJ1aWxkIHN5c3RlbS4KLS0tCiBnbnUvbG9jYWwubWsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgMyArLQogZ251L3BhY2thZ2VzL2xpYmZmaS5zY20g ICAgICAgICAgICAgICAgICAgICAgIHwgIDEgKwogLi4uL3BhdGNoZXMvbGliZmZpLWZsb2F0MTI4 LXBvd2VycGM2NGxlLnBhdGNoIHwgNTggKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFu Z2VkLCA2MSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQg Z251L3BhY2thZ2VzL3BhdGNoZXMvbGliZmZpLWZsb2F0MTI4LXBvd2VycGM2NGxlLnBhdGNoCgpk aWZmIC0tZ2l0IGEvZ251L2xvY2FsLm1rIGIvZ251L2xvY2FsLm1rCmluZGV4IDI4OWY1MTBjMTEu LjU1YzY4NmYxNWMgMTAwNjQ0Ci0tLSBhL2dudS9sb2NhbC5taworKysgYi9nbnUvbG9jYWwubWsK QEAgLTE3MzUsNyArMTczNSw4IEBAIGRpc3RfcGF0Y2hfREFUQSA9CQkJCQkJXAogICAlRCUvcGFj a2FnZXMvcGF0Y2hlcy94c2FuZS1zdXBwb3J0LWlwdjYucGF0Y2gJCQlcCiAgICVEJS9wYWNrYWdl cy9wYXRjaGVzL3hzYW5lLXRpZ2h0ZW4tZGVmYXVsdC11bWFzay5wYXRjaAlcCiAgICVEJS9wYWNr YWdlcy9wYXRjaGVzL3lnZ2RyYXNpbC1leHRyYS1jb25maWcucGF0Y2gJXAotICAlRCUvcGFja2Fn ZXMvcGF0Y2hlcy96emlwbGliLUNWRS0yMDE4LTE2NTQ4LnBhdGNoCisgICVEJS9wYWNrYWdlcy9w YXRjaGVzL3p6aXBsaWItQ1ZFLTIwMTgtMTY1NDgucGF0Y2gJXAorICAlRCUvcGFja2FnZXMvcGF0 Y2hlcy9saWJmZmktZmxvYXQxMjgtcG93ZXJwYzY0bGUucGF0Y2gKIAogTUlTQ19ESVNUUk9fRklM RVMgPQkJCQlcCiAgICVEJS9wYWNrYWdlcy9sZC13cmFwcGVyLmluCmRpZmYgLS1naXQgYS9nbnUv cGFja2FnZXMvbGliZmZpLnNjbSBiL2dudS9wYWNrYWdlcy9saWJmZmkuc2NtCmluZGV4IGQzMjQ4 OTIzMzAuLmY2ZTJlZmFiZTAgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9saWJmZmkuc2NtCisr KyBiL2dudS9wYWNrYWdlcy9saWJmZmkuc2NtCkBAIC00OCw2ICs0OCw3IEBACiAgICAgICAgICAg ICAgICh1cmkKICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kICJmdHA6Ly9zb3VyY2V3YXJl Lm9yZy9wdWIvbGliZmZpLyIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5hbWUgIi0i IHZlcnNpb24gIi50YXIuZ3oiKSkKKwkgICAgICAocGF0Y2hlcyAoc2VhcmNoLXBhdGNoZXMgImxp YmZmaS1mbG9hdDEyOC1wb3dlcnBjNjRsZS5wYXRjaCIpKQogICAgICAgICAgICAgICAoc2hhMjU2 CiAgICAgICAgICAgICAgICAoYmFzZTMyCiAgICAgICAgICAgICAgICAgIjBtaTBjcGY4YWE0MGxq am16eGI3aW02ZGJqNDViYjBrbGxjZDA5eGdtcDgzNHk5YWd5dmoiKSkpKQpkaWZmIC0tZ2l0IGEv Z251L3BhY2thZ2VzL3BhdGNoZXMvbGliZmZpLWZsb2F0MTI4LXBvd2VycGM2NGxlLnBhdGNoIGIv Z251L3BhY2thZ2VzL3BhdGNoZXMvbGliZmZpLWZsb2F0MTI4LXBvd2VycGM2NGxlLnBhdGNoCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjRmZDMyYjAxMDIKLS0tIC9kZXYv bnVsbAorKysgYi9nbnUvcGFja2FnZXMvcGF0Y2hlcy9saWJmZmktZmxvYXQxMjgtcG93ZXJwYzY0 bGUucGF0Y2gKQEAgLTAsMCArMSw1OCBAQAorRnJvbSBkZTkzYWRmYjZmNDgxMDA5NDZiYmEyYzNh YmFkMmE3N2EwY2ZkZTBiIE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQorRnJvbTogRmFicmljZSBG b250YWluZSA8Zm9udGFpbmUuZmFicmljZUBnbWFpbC5jb20+CitEYXRlOiBTdW4sIDI0IE5vdiAy MDE5IDA5OjUyOjAxICswMTAwCitTdWJqZWN0OiBbUEFUQ0hdIGZmaV9wb3dlcnBjLmg6IGZpeCBi dWlsZCBmYWlsdXJlIHdpdGggcG93ZXJwYzcKKworVGhpcyBpcyBhIHBhdGNoIHB1bGxlZCBkb3du IGZyb20gdGhlIGZvbGxvd2luZzoKK2h0dHBzOi8vZ2l0aHViLmNvbS9idWlsZHJvb3QvYnVpbGRy b290L2Jsb2IvNzg5MjZmNjEwYjE0MTFiMDM0NjQxNTI0NzJmZDQzMDAxMmRlYjlhYy9wYWNrYWdl L2xpYmZmaS8wMDA0LWZmaV9wb3dlcnBjLmgtZml4LWJ1aWxkLWZhaWx1cmUtd2l0aC1wb3dlcnBj Ny5wYXRjaAorCitUaGlzIGlzc3VlIGlzIGJlaW5nIGhpdCBvbiBPcGVuQk1DIGNvZGUgd2hlbiBw dWxsaW5nIHRoZSBsYXRlc3QKK2xpYmZmaSB0YWcgYW5kIGJ1aWxkaW5nIG9uIGEgUDggcHBjNjRs ZSBtYWNoaW5lLiBJIHZlcmlmaWVkIHRoaXMKK3BhdGNoIGZpeGVzIHRoZSBpc3N1ZSB3ZSBhcmUg c2VlaW5nLgorCitCZWxvdyBpcyB0aGUgb3JpZ2luYWwgY29tbWl0IG1lc3NhZ2U6CisKK1NpY25l IGNvbW1pdCA3M2RkNDNhZmM4YTQ0N2JhOThlYTAyZTlhYWQ0YzY4OThkYzc3ZmIwLCBidWlsZCBv biBwb3dlcnBjNworZmFpbHMgb246CisKK0luIGZpbGUgaW5jbHVkZWQgZnJvbSAuLi9zcmMvcG93 ZXJwYy9mZmkuYzozMzowOgorLi4vc3JjL3Bvd2VycGMvZmZpX3Bvd2VycGMuaDo2MTo5OiBlcnJv cjogJ19GbG9hdDEyOCcgaXMgbm90IHN1cHBvcnRlZCBvbiB0aGlzIHRhcmdldAorIHR5cGVkZWYg X0Zsb2F0MTI4IGZsb2F0MTI4OworICAgICAgICAgXn5+fn5+fn5+CisKK0ZpeCB0aGlzIGJ1aWxk IGZhaWx1cmUgYnkgY2hlY2tpbmcgZm9yIF9fSEFWRV9GTE9BVDEyOCBiZWZvcmUgdXNpbmcKK19G bG9hdDEyOCwgYXMgX0Zsb2F0MTI4IGlzIGVuYWJsZWQgb25seSBvbiBzcGVjaWZpYyBjb25kaXRp b25zLCBzZWUKK291dHB1dC9ob3N0L3Bvd2VycGM2NC1idWlsZHJvb3QtbGludXgtZ251L3N5c3Jv b3QvdXNyL2luY2x1ZGUvYml0cy9mbG9hdG4uaDoKKworIC8qIERlZmluZWQgdG8gMSBpZiB0aGUg Y3VycmVudCBjb21waWxlciBpbnZvY2F0aW9uIHByb3ZpZGVzIGEKKyAgICBmbG9hdGluZy1wb2lu dCB0eXBlIHdpdGggdGhlIElFRUUgNzU0IGJpbmFyeTEyOCBmb3JtYXQsIGFuZCB0aGlzIGdsaWJj CisgICAgaW5jbHVkZXMgY29ycmVzcG9uZGluZyAqZjEyOCBpbnRlcmZhY2VzIGZvciBpdC4gICov CisgI2lmIGRlZmluZWQgX0FSQ0hfUFdSOCAmJiBkZWZpbmVkIF9fTElUVExFX0VORElBTl9fICYm IChfQ0FMTF9FTEYgPT0gMikgXAorICAgICAmJiBkZWZpbmVkIF9fRkxPQVQxMjhfXyAmJiAhZGVm aW5lZCBfX05PX0xPTkdfRE9VQkxFX01BVEgKKyAjIGRlZmluZSBfX0hBVkVfRkxPQVQxMjggMQor ICNlbHNlCisgIyBkZWZpbmUgX19IQVZFX0ZMT0FUMTI4IDAKKyAjZW5kaWYKKworRml4ZXM6Cisg LSBodHRwOi8vYXV0b2J1aWxkLmJ1aWxkcm9vdC5vcmcvcmVzdWx0cy81YzlkZDhmYjNiNmExMjg4 ODJiNjI1MGYxOTdjODAyMzJkOGEzYjUzCisKK1NpZ25lZC1vZmYtYnk6IEZhYnJpY2UgRm9udGFp bmUgPGZvbnRhaW5lLmZhYnJpY2VAZ21haWwuY29tPgorU2lnbmVkLW9mZi1ieTogQW5kcmV3IEdl aXNzbGVyIDxnZWlzc29uYXRvckB5YWhvby5jb20+CistLS0KKyBzcmMvcG93ZXJwYy9mZmlfcG93 ZXJwYy5oIHwgMiArLQorIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv bigtKQorCitkaWZmIC0tZ2l0IGEvc3JjL3Bvd2VycGMvZmZpX3Bvd2VycGMuaCBiL3NyYy9wb3dl cnBjL2ZmaV9wb3dlcnBjLmgKK2luZGV4IDhlMmYyZjBlLi45NjBhNWM0MiAxMDA2NDQKKy0tLSBh L3NyYy9wb3dlcnBjL2ZmaV9wb3dlcnBjLmgKKysrKyBiL3NyYy9wb3dlcnBjL2ZmaV9wb3dlcnBj LmgKK0BAIC01Nyw3ICs1Nyw3IEBAIHR5cGVkZWYgdW5pb24KKyAgIGRvdWJsZSBkOworIH0gZmZp X2RibGZsOworIAorLSNpZiBkZWZpbmVkKF9fRkxPQVQxMjhfVFlQRV9fKQorKyNpZiBkZWZpbmVk KF9fRkxPQVQxMjhfVFlQRV9fKSAmJiBkZWZpbmVkKF9fSEFWRV9GTE9BVDEyOCkKKyB0eXBlZGVm IF9GbG9hdDEyOCBmbG9hdDEyODsKKyAjZWxpZiBkZWZpbmVkKF9fRkxPQVQxMjhfXykKKyB0eXBl ZGVmIF9fZmxvYXQxMjggZmxvYXQxMjg7Ci0tIAoyLjI4LjAKCg== --=-2OABAbE4BrT1jPj4g/AG--