I've had reviewing these patches on my TODO for a while, finally made itaround to it.
On Fri, Nov 20, 2020 at 08:27:16AM -0600, Joseph LaFreniere wrote:
Toggle quote (11 lines)
> * gnu/packages/rust-apps.scm (ripgrep-all): New variable.> ---> gnu/packages/rust-apps.scm | 80 +++++++++++++++++++++++++++++++++++++-> 1 file changed, 79 insertions(+), 1 deletion(-)> > diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm> + (add-after 'unpack 'enable-unstable-features> + (lambda _> + (setenv "RUSTC_BOOTSTRAP" "1")> + #t)))))
Is this necessary, or is it because we were using an older version ofrust for building packages?
Toggle quote (13 lines)
> + (native-inputs> + `(("pkg-config" ,pkg-config)> + ("xz" ,xz)))> + (propagated-inputs> + `(("ffmpeg" ,ffmpeg)> + ("pandoc" ,pandoc)> + ("poppler" ,poppler)> + ("ripgrep" ,ripgrep)> + ("sqlite" ,sqlite)> + ("tar" ,tar)> + ("unzip" ,unzip)> + ("zip" ,zip)))
We prefer to not propagate packages, and in particular I try not to usepandoc as an input because it limits the package to architectures thatcan build haskell programs. Looking through the code a bit it looks likeit shells out to the commands. So it'd be better to substitute thecommands to the full path name of the package (what I'd suggest forripgrep) and/or adding a note to the description suggesting that peoplealso install some of the other packages for more features.
Toggle quote (19 lines)
> + (home-page "https://github.com/phiresky/ripgrep-all")> + (synopsis "Wrapper around @code{ripgrep} with support for rich file types")> + (description> + "ripgrep-all (rga) is a line-oriented search tool that allows you to look> +for a regex in a multitude of file types. rga wraps @code{ripgrep} and> +enables it to search in @file{pdf}, @file{docx}, @file{sqlite}, @file{jpg},> +movie subtitles (@file{mkv}, @file{mp4}), etc.")> + (license license:agpl3+)))> +> (define-public rust-cbindgen> (package> (name "rust-cbindgen")> -- > 2.29.1> > > >
-- Efraim Flashner <efraim@flashner.co.il> אפרים פלשנרGPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351Confidentiality cannot be guaranteed on emails sent or received unencrypted