[PATCH 3/6] services: pulseaudio-configuration: Set flat-volumes to no.

  • Done
  • quality assurance status badge
Details
2 participants
  • Leo Prikler
  • Marius Bakke
Owner
unassigned
Submitted by
Leo Prikler
Severity
normal
Merged with
L
L
Leo Prikler wrote on 10 Jan 2020 02:48
(address . guix-patches@gnu.org)(address . 39053@debbugs.gnu.org)
20200110014823.10595-3-leo.prikler@student.tugraz.at
* gnu/services/sound (pulseaudio-configuration) [daemon-conf]:
Disable flat-volumes. Enabling flat-volumes, as is the upstream default,
causes unpleasant experiences to users when applications inadvertently max
out the system volume (e.g. as in #38172).
---
gnu/services/sound.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 6b2b345a44..5d72b3ada2 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -113,7 +113,7 @@ ctl.!default {
(client-conf pulseaudio-client-conf
(default '()))
(daemon-conf pulseaudio-daemon-conf
- (default '()))
+ (default '((flat-volumes . no))))
(script-file pulseaudio-script-file
(default (file-append pulseaudio "/etc/pulse/default.pa")))
(system-script-file pulseaudio-system-script-file
--
2.24.1
M
M
Marius Bakke wrote on 11 Jan 2020 17:54
(address . control@debbugs.gnu.org)
87v9piyluy.fsf@devup.no
merge 39053 39052 39054 39055 39062 39061 39063 39065 39064
thanks
M
M
Marius Bakke wrote on 11 Jan 2020 17:59
(address . 39053@debbugs.gnu.org)
87r206yln8.fsf@devup.no
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (5 lines)
> * gnu/services/sound (pulseaudio-configuration) [daemon-conf]:
> Disable flat-volumes. Enabling flat-volumes, as is the upstream default,
> causes unpleasant experiences to users when applications inadvertently max
> out the system volume (e.g. as in #38172).

I moved this comment inside the service definition code so that we don't
have to reach for 'git blame' when we forget why it was added.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4Z/usACgkQoqBt8qM6
VPp9GQf/RnyCLb7b/Voc6gEI+SJXKOIibzpQTDoRa94/CE+XxmaNs/NwiiAOt0i7
xCf2DfQiVH2T+jAQsO38HfG7nWp8XhjYqVXuTMdtaf4LABW6/gmTNrl+xVOTe2au
hGNq26yzLvdlSBZMdw/OZllqQ+UEezIKHnCwnrI3czNbx5AspdygI3CiTpIB0883
aMatJvb5D08eKyNCJxoJEBvwG0htq6e+Rzu0bzBrjRMYvSpD3B0hSehdQvOgBPPH
Y/ZnCtCrTm90MYFI3dRS7QpRgIDMtxBm5G2dGzMuEvc28sddPMFWveeYt5TwSzeD
O1K9zd9fjH6jHhIJlYdvYD/94QbZeg==
=m7/s
-----END PGP SIGNATURE-----

?