Hello,
John Soo <jsoo1@asu.edu> writes:
Toggle quote (5 lines)
> +(define-public emacs-haskell-snippets> + (package> + (name "emacs-haskell-snippets")> + (version "0.1.0")
Would it make sense to package HEAD instead. I'm looking in particularat upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5.
Toggle quote (12 lines)
> + (source> + (origin> + (method git-fetch)> + (uri> + (git-reference> + (url "https://github.com/haskell/haskell-snippets")> + (commit version)))> + (file-name (git-file-name name version))> + (sha256> + (base32> + "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6"))))
Usual nitpick: please put string on the same line as `base32'.
Toggle quote (16 lines)
> + (inputs> + `(("emacs-yasnippet" ,emacs-yasnippet)))> + (arguments> + `(#:phases> + (modify-phases %standard-phases> + (add-after 'install 'install-snippets> + (lambda* (#:key outputs #:allow-other-keys)> + (let* ((out (assoc-ref outputs "out"))> + (snippets> + (string-append> + out "/share/emacs/site-lisp/snippets/haskell-mode")))> + (mkdir-p snippets)> + (copy-recursively "snippets/haskell-mode" snippets)> + #t))))))> + (build-system emacs-build-system)
Nitpick: could you move parts in this order: build-system ->arguments -> inputs.
Regards,
-- Nicolas Goaziou